From patchwork Fri Aug 31 18:24:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10584353 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4C8075A4 for ; Fri, 31 Aug 2018 18:25:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3ACA92C5B3 for ; Fri, 31 Aug 2018 18:25:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2EEB82C5B4; Fri, 31 Aug 2018 18:25:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B061A2C5B2 for ; Fri, 31 Aug 2018 18:25:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727597AbeHaWdl (ORCPT ); Fri, 31 Aug 2018 18:33:41 -0400 Received: from mail-bl2nam02on0058.outbound.protection.outlook.com ([104.47.38.58]:40512 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727557AbeHaWdk (ORCPT ); Fri, 31 Aug 2018 18:33:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bz8tKx1asbp/u40hzfPZyiwl9ImTUMDy/6nav7v5PsQ=; b=g90QtQkSpUQgxWDiaSP494ilMNuSFpkd67J6qPXoTFqzivhumC8fL2Ze3fEHZNNIpqLhc5F82LCxqgRM8OJBilpdMNY/X3o1e2CXxZUdhM/fh8bBGzGlcw3dBpXbE29Xdhcnjg7KZ2dNeVFW1XMFU3iUYx6hPtkN6MAYjzCaRrc= Received: from DM5PR07CA0113.namprd07.prod.outlook.com (52.132.138.42) by BYAPR07MB4389.namprd07.prod.outlook.com (52.135.224.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.15; Fri, 31 Aug 2018 18:24:55 +0000 Received: from DM3NAM05FT030.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::203) by DM5PR07CA0113.outlook.office365.com (2603:10b6:4:ae::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1101.16 via Frontend Transport; Fri, 31 Aug 2018 18:24:55 +0000 Authentication-Results: spf=pass (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=cavium.com; Received-SPF: Pass (protection.outlook.com: domain of cavium.com designates 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by DM3NAM05FT030.mail.protection.outlook.com (10.152.98.142) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P256) id 15.20.1122.2 via Frontend Transport; Fri, 31 Aug 2018 18:24:55 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Fri, 31 Aug 2018 11:24:41 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w7VIOfMq024261; Fri, 31 Aug 2018 11:24:41 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w7VIOf6w024260; Fri, 31 Aug 2018 11:24:41 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH v2 11/14] qla2xxx: Fix iIDMA error Date: Fri, 31 Aug 2018 11:24:36 -0700 Message-ID: <20180831182439.24182-12-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180831182439.24182-1-himanshu.madhani@cavium.com> References: <20180831182439.24182-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(39860400002)(346002)(376002)(136003)(396003)(2980300002)(438002)(189003)(199004)(2906002)(305945005)(106466001)(5660300001)(42186006)(26005)(81156014)(81166006)(54906003)(16586007)(316002)(72206003)(356003)(186003)(110136005)(4326008)(47776003)(8676002)(8936002)(50226002)(1076002)(106002)(69596002)(11346002)(476003)(446003)(44832011)(2616005)(36756003)(80596001)(48376002)(50466002)(126002)(336012)(486006)(87636003)(76176011)(86362001)(51416003)(478600001)(6666003);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR07MB4389;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Pass;LANG:en;PTR:50-232-66-26-static.hfc.comcastbusiness.net;MX:1;A:1; X-Microsoft-Exchange-Diagnostics: 1;DM3NAM05FT030;1:ZGdPKeT5DjIbf03LI1aPfp/uMmNnqqYq58XBLNXEEIm8/cI7gBh0WffYTyvG1vAngk10+0KM6fe03wonakQgXcl2qgAH77iUrN3GL4tw6cMsOLpvdzmXgPzyXs5GpsUO X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7c8da201-d355-4317-09e6-08d60f6f0d43 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4608076)(2017052603328)(7153060);SRVR:BYAPR07MB4389; X-Microsoft-Exchange-Diagnostics: 1;BYAPR07MB4389;3:6iUp+CKzXAkQBbUel6qhiFIYZtg8f9QvEMXI1pYN36v48/7kuuepI4lkG6aozuX7z2rPYiTYeCyx1eYpuZDy96NW+8s/l/UnlUP9WFeRvx3vEvMaiQVM2e8w1lA//EEvZ6mbN1YtCykx8bfHNZFNd0UhrdbftanbrkPAtD3BLu5fSgO70Ge+4jvxoa7QlMdSSKIMpfQfPplprnqyktbwhxvM8wb43csf4UukNM+9qufjIe6fjtqFueuS9ulYs4Asv6BtACuJeC3i78OWkdhJvL/zAhNpp2bucjqtB+hSEriNUo6KBignC59N/QPOf1rvo6ur0Keu7mFgARlB1QUxxbgBIM08WctxIejvl2pv0dQ=;25:pUjO8I7tft9kPCWysQb4cM9GeqeNUVVP6GnKWzcWEvaVBvDOK5vPMJ7YgaAO/5fOvOspPaEpZhScIXo4CxjKsF8fN9eEq4y5xIYM9znFyQdwZsC0MDw/pQTOTWdRvlxwfvlEGFr35TAFr3UHdfiABuJCHWg+qPJdMoWn+/ZVPR1flrVBgoL4ckfWG4t1LoqUd1MHKco6v1k4U6ZyWLdM15yrYZKSOCvx5yH3tbjAXgenby9p1ZkqVSj4FhmyCMYdKDTtQC8s4X4oszgyVbhurtlspU6zxUUhg8YB8DeVfNYi0QtNlolefyfGJ3HqBBuOWSPQu23v73Ny/lcsq68TXw== X-MS-TrafficTypeDiagnostic: BYAPR07MB4389: X-Microsoft-Exchange-Diagnostics: 1;BYAPR07MB4389;31:FLoAfTXMErOEiO08GkcjC6uUGOwdtxu3WPg9pkJ7TgD/87EcbYsMitdzcP12p8bGo3NpJTtPVETY0oPBoECwIOpHNX4n8LQm5jrAni13eaFINfxBk3Y+UQZ39VrcObqihSSr8nNxEfQ0G5ZFw/r4UR99YPoue67NctzbipuMDdF/iGQbmX22e9GGRPsi6x0PKxlJ9nHlhNso0+9tHGIVLQlh1VO6+3hlVZcZujZyx28=;20:SE7mZnRhStonSfPiITSI1UkMlnY/j5ktwHISO3bUz4hUwTZYP3TB+IVIC6WjvNp6QP9njYfXDjTBKPKazTsHRu/cl4rm3sey/3y3MzEYYPTIUzdxD5xJHo3DGmxBlG+P8GB1cexpHWzGaiGpgLmf7xNzxtGlU4UnXoqjngmNInHC5OlxKk4f3IUcNBZN2RBtnnSLjnnF1IznyAVcfxDr3YGDuxjL4HREpQ1eRZn4Jl3M/cZkGX0gjcD9RwgRL147AGhdOOfHyoekJz6rxh4ZYFb6kKCdtC43XBOyZ5v6AcnMCYnK21gAYjEhdVWCrGMAhowrxB3DeHShE0yy6LcIII7Brug6Rs6FeFePXUk8JqUDV+u22/Pkgj/JcmuxWQIq41hM+ju9lw8w42gNZ+5495OvErCkFFa3J3JArWmX9wgEucc+vad8DJzIN/1ivd4pV2lFtx7wDGvkfqaAxmQ+WW9/q0WOafq7d25leAAqn7HXU5RIIZmkP5X9YNIJb4Fx X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93004095)(3231311)(944501410)(52105095)(3002001)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(201708071742011)(7699016);SRVR:BYAPR07MB4389;BCL:0;PCL:0;RULEID:;SRVR:BYAPR07MB4389; X-Microsoft-Exchange-Diagnostics: 1;BYAPR07MB4389;4:Lpfsp25TEDpMHgFvGoZn9LF3Kuk8ub44aQFv0ZJwjW5c7VLsCGBbO7kKzKeCSlph3PKIDQfOyvndARM9rCteIiPpCEc3fGzwL2tMrYDWfHoeZHRwUPfB1tkH0i9gu8peYL90WTrv6K2zPQh9l+XXjeyjSNxq54u7ELkDdVnNQf+XDi3JZm4gTFm5WdIWNjrbLvrqifuiNQWvlpRddLBlYThvEw+pS5v+p0gAJfb1FhWZ49pufV4taXOZJie9XYBSP3254Y1KOxhQ1yIXGjtYag== X-Forefront-PRVS: 07817FCC2D X-Microsoft-Exchange-Diagnostics: 1;BYAPR07MB4389;23:eHHhFWZ0W6ki0cClZ7Ik7CHYZfuRQ5ASxUBftYOfJqtLLh9ITDW27j/mQ6ggDPYERhOKDGOWwOYRkyIqEw+jex5rLRv3omFXjdgwUuD4w8FHvLk31bVC3vNYDlGxjQfaahVIBFJlVF7gU27cGUrHuheuBnTHcv4wI4ibp89MgW+M1AV/l+8mNqWRmfItIBMkeMfoo/J7g6xUMi323pQnkhXvsXuEOWRLOO35qxY5Po6h9IEo1e3x3T6cSaQ4njj7HFEzGAZGN0juccf1Ek72U+c9KyAfYNv27HSV/p+g/kJLRmV5BW7qIM1jvXJpOWERaKxaPD+CtwuC19s8EZhsylHaxdZ3JuzhW0A6QmJJ7hfZsSCUX7JAyXtJxBcqw+mslIyWH50b7YAHyE6pOvQAfdYiFduO0Pe3Yuiu/TTXVh4pGq0BUbEFQ2wCFe5Ibky32A8OjlerIOzHVwJ6aWGj71YCu+QD1rtSMy2yHKWBFc23gvz1jqEl0DjFnOkPPTt+BECUth3HoyH1smq0AVVCTh41smpsuh3ihAArsNuL97HfR4c7DfuIyWOzN5eaR8ak8uT3Qe6UoqSOF6se9DoMeKHdLEMsCyBL9OXToEaJBY0p3A/p3gyg56XJkiOhYqEROJeIt/UBEsX9E6FPnhegn9nfmiyV8uMlekD1RFJI7vMyK2VbJlC/WgxjtfuGX2asxN4H4XjedEgB8dbvUeQzMB19u2bG06fYnPo+HGLTfenFDJJB6GDIkoqtCDhf1WSwbSEdH5tisCUOl6S/RProLst2eZD5cvnGC1yb0CUn6PM98Db9c4Nb1eSdxj04oSrtcDHajEkjToP20w7OIT34QOYPC40+G3AoEbfBTp37Wdsg6GIzoM04yISbaWtXA8smsApdJwW8ZtBTbM84bQP9JYFbq/IVwm8Ay5KmkokIjiPiRBhf/xLQv6L9b8hApM3xiZYhuX7BGzUtQcpVAPIm0jhUW4o1/kBckApJfxDGbvhsN1ylBCg52JuDdCK/8q2Hw4vHDckoct1QlaqsmLYIAJCaAdkMUMtFIIQEZ67WcEyfvXa8OYM+iDJ/MurppjgSNWcPUm014hMUkNXlHDngGJeT8lJeAcli0CUCteuA3l4= X-Microsoft-Antispam-Message-Info: MF6yXjZYBjrawBEMDSFI20dYlvM8zt6riJKvT53Z2MVo7lOCh4jfjrMjeZyIY5dWBRX2QJZSA/mJ0q1WEUNaBzMyie8M1ZscgcN0q5jBsyri0duLbZVMCg/5rPVz5BWlMuLYEQ4UMY3Ixtity0/IScB3ZfhOJrh5NjFQhNjfzhhdEQWKAen2GnFxTj7xOu1OyEqBTLIySFHUhUXrdImqC+QtakXWjHyaMKeYUfoEtu7XOL9zbAw0z4+Z6txPJsIUNa7r44xb38Ph7cK8K73WIE/mZDsLlB3hlDQBWo0vkUVbEH4k9QEQPxx97I3fe9cHitfhlt0kKQ9o/u0uq3qSr5U8v8ajOdfrcu6eA30QTQQ= X-Microsoft-Exchange-Diagnostics: 1;BYAPR07MB4389;6:C1iTt7sRUKgYusP4WFe5mExOUXshgVqbWYnyHWoEmPl/ZltV8ecOr3yEtXvvbUc1By4089Wos0buJD4k5GUtcHnw15ZBEITxBioFBNJxH0qORvNw2ts96pIjQL74NVKTVd7pBYntLESHTMd1+0LLXJGJH4yKyfXE9IQMA8ubwYCfr7YMnIy41tLn0H+w2vVAT+dThZgcWIg2eGsEdMZzfWSyXXMDDKv7JrwK470Bv1rvRj5YMhfKl0t3IoIUpOuHFoW+tq2gNbFfeFYoFhWD1rs0DJPYDeuhprjqvC5zGQdmLgYT16z/WfnXyOPkazzDEJd8ZFvwC+0GlvnGRdsnnZTnfVdWI20R3TBs8sbzXC8wRahYRuvV9yu7rRKzB/R2XusQCV6T9aS6O/A27iAy09cEyupiN5CI+Yr7NExS9w1fj9E3QZtS6LMwcX6QJuZGO4Rwl3uQDgBABvdJ8HSCpw==;5:9E2gJ3uiPMBP+DB6kViF1TqM/iv8GI46XGeZlz7++OuAMOb9mcjTaWj+W15ldFvW2UlsQVEhV/zzE1jXvJBfGgsxY1GYkiEIF69YZ2iiyPGlJUr/PbdBySLbk6eb2H8G/D2WrDzIQOoscC9IJZY4ROzoi2iHgjNCG3tynn9EWto=;7:aQmI3pw0PhvE3nCTxg98+8Slee9p0RJH8oxuaE2IZJK2ItT2w9JWP99Tveu88pJ/5CK8iuUTsS6DJ4pRYKhNik8p86H31TiszBrCK7nOeJ4JyDmfQvF+QFd09LYSCvyetORDbc60FprmUM66BRN0Xd7RRktSwSDnKmutxVTYj3KCc4cHnU2WAVxvdQQPBqLfn4bSrjSpOEoO2udMKtuLQBnA4H59YRilfhKonzmfsZs0+H1cxzouTjSorddIH663 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2018 18:24:55.4818 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c8da201-d355-4317-09e6-08d60f6f0d43 X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194;Ip=[50.232.66.26];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4389 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran when switch responds with error for Get Port Speed Command (GPSC), driver should not proceed with telling FW about the speed of the remote port. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c index 85cbe59b4f58..902106f97020 100644 --- a/drivers/scsi/qla2xxx/qla_gs.c +++ b/drivers/scsi/qla2xxx/qla_gs.c @@ -3272,7 +3272,7 @@ static void qla24xx_async_gpsc_sp_done(void *s, int res) ql_dbg(ql_dbg_disc, vha, 0x2019, "GPSC command unsupported, disabling query.\n"); ha->flags.gpsc_supported = 0; - res = QLA_SUCCESS; + goto done; } } else { switch (be16_to_cpu(ct_rsp->rsp.gpsc.speed)) { @@ -3305,7 +3305,6 @@ static void qla24xx_async_gpsc_sp_done(void *s, int res) be16_to_cpu(ct_rsp->rsp.gpsc.speeds), be16_to_cpu(ct_rsp->rsp.gpsc.speed)); } -done: memset(&ea, 0, sizeof(ea)); ea.event = FCME_GPSC_DONE; ea.rc = res; @@ -3313,6 +3312,7 @@ static void qla24xx_async_gpsc_sp_done(void *s, int res) ea.sp = sp; qla2x00_fcport_event_handler(vha, &ea); +done: sp->free(sp); }