From patchwork Fri Aug 31 18:24:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10584329 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C709A112B for ; Fri, 31 Aug 2018 18:24:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B5A392C5B2 for ; Fri, 31 Aug 2018 18:24:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A65542C535; Fri, 31 Aug 2018 18:24:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0F8532C535 for ; Fri, 31 Aug 2018 18:24:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727528AbeHaWd2 (ORCPT ); Fri, 31 Aug 2018 18:33:28 -0400 Received: from mail-eopbgr680084.outbound.protection.outlook.com ([40.107.68.84]:63488 "EHLO NAM04-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727518AbeHaWd2 (ORCPT ); Fri, 31 Aug 2018 18:33:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CfJomuxMO0Ykf32dJ6beHDUOvEtGG8fEuCEx6D76pVI=; b=GNCc/KGT6U7Zz/qMOS4xx0CJDFKmf12IkWQnwgBbScu01sj2Q1hZu6tbYf8OTFo2aYVzE1An3bB9ccPQ17N1u1D1fKbRPxM9opwAD4TvAPF6NmvgXlkcSsO4TrOiOUeiH4LKucWOdZjdrslRbvfLCwjXGDewBJkdaeJZkkJvQsw= Received: from DM5PR07CA0110.namprd07.prod.outlook.com (2603:10b6:4:ae::39) by SN6PR07MB4671.namprd07.prod.outlook.com (2603:10b6:805:3b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1101.17; Fri, 31 Aug 2018 18:24:43 +0000 Received: from DM3NAM05FT030.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::207) by DM5PR07CA0110.outlook.office365.com (2603:10b6:4:ae::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1101.17 via Frontend Transport; Fri, 31 Aug 2018 18:24:43 +0000 Authentication-Results: spf=pass (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=cavium.com; Received-SPF: Pass (protection.outlook.com: domain of cavium.com designates 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by DM3NAM05FT030.mail.protection.outlook.com (10.152.98.142) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P256) id 15.20.1122.2 via Frontend Transport; Fri, 31 Aug 2018 18:24:42 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Fri, 31 Aug 2018 11:24:39 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w7VIOdUq024221; Fri, 31 Aug 2018 11:24:39 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w7VIOdKk024220; Fri, 31 Aug 2018 11:24:39 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH v2 01/14] qla2xxx: Fix process response queue for ISP26XX and above Date: Fri, 31 Aug 2018 11:24:26 -0700 Message-ID: <20180831182439.24182-2-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180831182439.24182-1-himanshu.madhani@cavium.com> References: <20180831182439.24182-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(136003)(346002)(39850400004)(396003)(376002)(2980300002)(438002)(199004)(189003)(2906002)(86362001)(81166006)(81156014)(6666003)(186003)(5660300001)(1076002)(305945005)(8936002)(106466001)(356003)(4326008)(26005)(126002)(486006)(48376002)(76176011)(50466002)(72206003)(106002)(51416003)(2616005)(11346002)(44832011)(36756003)(446003)(476003)(110136005)(42186006)(316002)(8676002)(54906003)(478600001)(16586007)(336012)(87636003)(50226002)(80596001)(14444005)(69596002)(47776003);DIR:OUT;SFP:1101;SCL:1;SRVR:SN6PR07MB4671;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Pass;LANG:en;PTR:50-232-66-26-static.hfc.comcastbusiness.net;A:1;MX:1; X-Microsoft-Exchange-Diagnostics: 1;DM3NAM05FT030;1:Bgsqku7lPqO45xZHNuFMD8desPOuNZuej97FiHQk7S2CGBPOSmn2CcGtMTe28z/vTdCgqGZUcUEo6cSNKVSmVVi7WXPtUd8+53VSxYw+08iq0jX728U4txQgBOU/EfrN X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e3a5dea-a25d-4836-9982-08d60f6f05c3 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4608076)(2017052603328)(7153060);SRVR:SN6PR07MB4671; X-Microsoft-Exchange-Diagnostics: 1;SN6PR07MB4671;3:c107rkRiCY2ia+MA7Rg006hQqSw7/W/QZo4/nP7ap4dBdoDItzvBMHJiPbiCD0a+ecGk/dhAaNOUiwMryJ9RyhQQB9bVBiYv6wswaHUcJmIGb74PF2N3W96U/6WpzBgBvCU4FYi1ZGMumPTDD+dEfse/ZgLGNmcfy4cS/KINasI9rvr5P/0HHERfGPd34tkQNBW2yDqhbOBd8VuJYeYrfMx0gT8WKtIopJmAW6KLo1/aoKW/AeLT4xx4UimYxx/HSRUjsItjbnp1SCJ33Q41tnXIFN4UBuK8pWjkPecQf6GAcm/tyKcektf578kdbhG1lPk/QO2RpljKTDhT3at0ZFVGReWjKGuXcooi7XZmwb8=;25:1HtQbzdc3UmTpEv9Uv23oSRUDPQBO3gmlpuGGadyAFn28B2paDqqyvvwdlHMUDKaTOTo3hcnh6I9mRjR+L5GGIQyfKaeZ087PRA4xbGQh9M2W19GrgSt6emkgjmuOiRMz/jQEoJWLfVLRXjDL4TzeUZ9v31E5EaNNtxX1UlvB9ZwQuQoYf29cecFuAalacX56XcelSHvKYfQsG9Xxqm1sRObPe2ey5Pixwn99vxB4x0MX9/wahhknbsMxEqzlaaq3DkMUqzqoKizcj67gvJ9DwpSC1vf663mT5NiYTRVzWBgEKgDBp6ZnaPqlb+8VQrdYivYNUUO9hrQkmorCcD5PA== X-MS-TrafficTypeDiagnostic: SN6PR07MB4671: X-Microsoft-Exchange-Diagnostics: 1;SN6PR07MB4671;31:+ztwzz1xvAO7lLCvknEpcdvWgMnXFKHTpyxgmqIGPwcvq+R0HiuI2TfebimwjT47QWluYVGgX04RTE7mlzbLx5EBn2s3WqJBVMt88Jvyl3sNlb0uezt2kxJjY4PAb9fVCxRYx/7poQOU1MZE5CRzbjOmEUjcU944eJZLy21HKhBrUvksCXZF7+DH1d5w/YKOHEklakxUHG0G71yEKrRtbrtUw5FEMDhcXJtBiadWYEY=;20:I8NCbtXRKhqi95Rpu0WIsg5QBDY5RY088EWTKC5mjMg2mxCsedUd+v7RTDX/3EIiFtz26yOTczY+uH0kuyHmEzPyLOCaNQ0faOB1cTRGbM9J2f+Y6+zvmG4nKILMULdwo0b1R+FlEJAbvcFmfNDAIS0SY1qFlLQaaNGSZZtpWiXsMOZAATA26Ctu77jiDv1iJAjG+Cg0KedA8SwQyCCMVxwbsB2wz8Om6FxGPWyOX/krUilV/gSCiAGM+PaMImsAJdhYViswzJDoEiOzXe+UC61OARzn1LX5aZ+YmMAEOlUhw+ksL5UGMXs+41I1xxZKKxe1AsrJkilUs4JD9S2KgQKbmhmVUpy/Fiy1A1TopsIRolzAV9bdNmcVosz6uiJse7z54kU0b0le9TpZ2bExNQBfzgmGsQqhld06fEaeINEVD21n0nRTRSKdL0PJPYt1j7Nn7pCDkIcOqa61lC8DTRpDC1unX5fsTzO01PtdXIi4x9J2wTHYVMnLufBxKnP9 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231311)(944501410)(52105095)(93006095)(93004095)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699016);SRVR:SN6PR07MB4671;BCL:0;PCL:0;RULEID:;SRVR:SN6PR07MB4671; X-Microsoft-Exchange-Diagnostics: 1;SN6PR07MB4671;4:6EAJcZ4l9AtNAGw2+id8UPi5YyUG7zyOcjhLd0XpX5jWdIw2YhKjComdJu+kwyr60xj+uLZ9VJOVEjAczLYcD1S9Nb4gQCRWXxA2BJl27cPoGnaWHoxYJ3XMIBuDImgovhB786Jo2HlPzFS1JWr30utRTmJ8z9X/UGGS2QM7ouSGjQHgMuWgsdI09PMT1vlvEIjdJ5O9dTEa0l3TftXEUbvLD2SpSqNPQoSSS9F8RLrLeLustOXcMyGU6oOVRq+LjmGnG+83IIGkbgERGjqfOiW/zWTC7aT4fgJ4aETFKG561eraAFuRdt/H3Mpx3oP9 X-Forefront-PRVS: 07817FCC2D X-Microsoft-Exchange-Diagnostics: 1;SN6PR07MB4671;23:6QO/me7mtmci/VwO/J9kWyuyLFMnt8KwRko2YbGEwc5HsznSjNzjodrrKsrqsEu2Mf9cRfr9amgDQILilq/UEiYr2gLqDWtQKgUpoYPhDaZzBHf8+SmQ1jluEgfPLLDPEpOSBBOnOWhR98nIWRftten9oarxRgC7Key4edphOuYzj1EcTSLbZPlTuRwL2WgmakvfA/gMbqr+Y+2yBj5yqLZAYnffI+ysDGwHjKQAwQsHTdh474YSvTYMyMu3XDPXDbP8wIRsOoSRQR2EMaDcI6od4r01lgN80HUnCRj1szlD1HKVkPXYuzjnKAwXTjCcydtVP4loMB4MCqJiIgJNwjlfT9unwdgHkkEyhwco9mxkNxxjkwr43f6QfQj8KnaUwQZm9IMEc2qMO36kM+6HWNkNQ1xriTUy0eZgzLxaj+UvW0NH4lMzS/j9sPQ5ubFaZ4GFtojtNDjHB/WY947gYBYnyv4Sq+VOvP3HaSrqjmGGkyMznAbh/dxmHNZfsCfdcY0AdFcSrWbQX7CUjVc70DQXhJvnj5yMnB/mEPZRkS7WLFRMgkHu7jtTTpi8ZIca/9ZJhnvel+iKH3SeMBc5IbiVHojhe8GJZrHY/XJXtcjVJNnErfXuuKu7hfTGkdoTEBlpk57JSmHUg8fTW9A4Fz78VdbXHGNniHD8gQXx+MuIWvlft77MHyFO8S3LmOe/n9gi7epHJppY7pmbBGop5f4PkHorAMNgPu/feoUqJahg0J7dy5c3hUgiEDo2xz63H5O09wEdJty3qXHv5wV/mX9xJ4RrBcUx8RBbPCDhWRqkrB+O6hxkmoHbo0E5VZr8ZDNY5lbhhyJjyxo+ZDNOOxilPn+FuuOFFjT4cxwisXkYtDB6xchLBiGHOWGLqsgC3qEo3kBfargnKuIIyezzQU2ggy8uzq7KmCyWDOZpJxeuHubDEf5fi2wHnPasghmyVhoP0164u5E4Cv92wNDjOo2/YttNkqGkTdcsMln13Sz+3TFZZ7t2nKkNzJB5lpapU7O2lrmUt1BUCeSmaVbLjR7YzjkwaH2nZstPRWZVxe8aZmHBCuNNHpQ+c5bOj6bInkdZhganl9O/9wtkyAALwjzG2sR3ZsNtZzF3Cx253OUc+zwEqtKQBt6MQ8Y6iGVr X-Microsoft-Antispam-Message-Info: So+MNgHTAyIrdNqmX6qQdra7j9AV+LcnIjM0dLbAPw1VaF3zB7QMy/1SxEwdyFBaiHOqDKkqlLEprtTJMwDm/OyODWggUqg0L5vh+Ah5QR44wcy1YNi2PpQ9N+fbfsHcS6e9M80Vbzv1rKHTjlQU9fEiel9wJ6awy78VHasP148spk9wH8YscPn9tkirSjrYf1hns7w5KquShuUAUxyc9NzJPxm6B6DbkpUVDDwn9Y7Sm7wd3IurjkZ8mGm+RD7pphIDozMlNJ4TL7iJj57pF3kLRBc9ud+W/Wgs2B3kVx1IPBYMuKmLt2flX4I8Lj0pRGxRGozsp9IVHJ9FmTEtU/z0D4P/+r7x91MXbAPR58E= X-Microsoft-Exchange-Diagnostics: 1;SN6PR07MB4671;6:SZe+1yYiOzdwCG8Q1dvfoC43gwXBaN+Y5OsP6RwvuoblvV2/5ZclkuX5vWE08P503pzL8wFnIQzZ/SvUTh/9RvbFTCYYPy418wffoheaHwp/tSwWUKo5QLWWh0LNXFf6aH12ba5AIUrvr/uDt1AK7h32P8OO3he9DRpSMOG4bZH0WSjLBlbscDIZHCIQ8VGktmo2iHpiVCRDeeqFJA9aZTgla2SjjFNudH3j7EpGjLfR7dQFdWStENFbBEq+DoyQuaGzY90mOYS5ROGgHb9MZ3YJZzUC4cD7qeuBfE4KmyFdj1hZFSqDDf9R50FyAYZ6mZxKtoIjbeXvxL1CG6KUIoUW4zl7xt4sT8Y1uT8lSycr5zWIZZJSKbhmqiuxpqbjG/FXmxs6pEVau51zs/CuB5czKVE1h9TeJIbO5LiK8e0IC6iF39oGpScJfnS4oiMQgMY7GB0zaYCeajLqZlrK4g==;5:pHWQhoULZHfoPv6F3iGVGElRfNP2/wob659a55mS4lNQMQdJAFDdnHJzNEyaIsROqCNjhPuzg1v6gWWdzX6h6Jym5v/zIupa9MP3nQsJSczmtIoXVGXf4xIOM1CZC9Y6ARZKiL6XnaU5tsxl2PdcCm69bD/x8GQLJ5+Ff74QEuw=;7:WOlFJG+9iY+h0PnbwGYkiy2GNE24CRTt2Pupbt1ATFxs1BGMG6f+8BYEBMMavi9969BhMge9wGr6AZ2k4W/oOXt4pA2MKROMZ9b/ZO18W+mzRG6XvoGWyq69ODaHAE2oIpxLmR5b6ZCBBZ/vzGFvFj40BZKTtOouxhESjHzovJyvBCvkdesYlZDGPLCNwzZ7UO/1uvpEKnevNlZOjZ5vp56WnTiqzIfOS+RKWp+yMNbNceSqeqLTi+zEUQ41rNLG SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2018 18:24:42.9182 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e3a5dea-a25d-4836-9982-08d60f6f05c3 X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194;Ip=[50.232.66.26];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4671 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran This patch improves performance for 16G and above adaper by removing additional call to process_response_queue(). Cc: Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 2 -- drivers/scsi/qla2xxx/qla_iocb.c | 17 ----------------- 2 files changed, 19 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index b934977c5c26..4686fb5f26aa 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -7142,7 +7142,6 @@ qla24xx_nvram_config(scsi_qla_host_t *vha) } icb->firmware_options_2 &= cpu_to_le32( ~(BIT_3 | BIT_2 | BIT_1 | BIT_0)); - vha->flags.process_response_queue = 0; if (ha->zio_mode != QLA_ZIO_DISABLED) { ha->zio_mode = QLA_ZIO_MODE_6; @@ -7153,7 +7152,6 @@ qla24xx_nvram_config(scsi_qla_host_t *vha) icb->firmware_options_2 |= cpu_to_le32( (uint32_t)ha->zio_mode); icb->interrupt_delay_timer = cpu_to_le16(ha->zio_timer); - vha->flags.process_response_queue = 1; } if (rval) { diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 42ac8e097419..119927220299 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c @@ -1526,12 +1526,6 @@ qla24xx_start_scsi(srb_t *sp) /* Set chip new ring index. */ WRT_REG_DWORD(req->req_q_in, req->ring_index); - RD_REG_DWORD_RELAXED(&ha->iobase->isp24.hccr); - - /* Manage unprocessed RIO/ZIO commands in response queue. */ - if (vha->flags.process_response_queue && - rsp->ring_ptr->signature != RESPONSE_PROCESSED) - qla24xx_process_response_queue(vha, rsp); spin_unlock_irqrestore(&ha->hardware_lock, flags); return QLA_SUCCESS; @@ -1725,12 +1719,6 @@ qla24xx_dif_start_scsi(srb_t *sp) /* Set chip new ring index. */ WRT_REG_DWORD(req->req_q_in, req->ring_index); - RD_REG_DWORD_RELAXED(&ha->iobase->isp24.hccr); - - /* Manage unprocessed RIO/ZIO commands in response queue. */ - if (vha->flags.process_response_queue && - rsp->ring_ptr->signature != RESPONSE_PROCESSED) - qla24xx_process_response_queue(vha, rsp); spin_unlock_irqrestore(&ha->hardware_lock, flags); @@ -1880,11 +1868,6 @@ qla2xxx_start_scsi_mq(srb_t *sp) /* Set chip new ring index. */ WRT_REG_DWORD(req->req_q_in, req->ring_index); - /* Manage unprocessed RIO/ZIO commands in response queue. */ - if (vha->flags.process_response_queue && - rsp->ring_ptr->signature != RESPONSE_PROCESSED) - qla24xx_process_response_queue(vha, rsp); - spin_unlock_irqrestore(&qpair->qp_lock, flags); return QLA_SUCCESS;