From patchwork Fri Aug 31 18:24:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10584331 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 524EF1709 for ; Fri, 31 Aug 2018 18:24:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3FFC02C535 for ; Fri, 31 Aug 2018 18:24:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3450B2C5B3; Fri, 31 Aug 2018 18:24:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C5BEF2C535 for ; Fri, 31 Aug 2018 18:24:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727530AbeHaWd3 (ORCPT ); Fri, 31 Aug 2018 18:33:29 -0400 Received: from mail-sn1nam02on0052.outbound.protection.outlook.com ([104.47.36.52]:29088 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727405AbeHaWd2 (ORCPT ); Fri, 31 Aug 2018 18:33:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4La41tnfV9u0wn1/1YbSomSa6Krp2LHn3GNuW/Ka1DQ=; b=Fv6+W4frVt5UtZY6fWdSZWYYbBfoLaf8Vgy/hlG1ulguG8YRYRv4zYwwhisaD3/XkGU0m2Bmne2YZ6CWUWOQP5U0w9ej2pSbHaIk2kJWiZz+HVpsqDakNN0nPofX1RDDbYXUEJqL+0Zp2VNoKxDuOvFFTrMun7+rB+v6FGuD30w= Received: from DM5PR07CA0110.namprd07.prod.outlook.com (2603:10b6:4:ae::39) by DM6PR07MB4668.namprd07.prod.outlook.com (2603:10b6:5:a0::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Fri, 31 Aug 2018 18:24:44 +0000 Received: from DM3NAM05FT030.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::207) by DM5PR07CA0110.outlook.office365.com (2603:10b6:4:ae::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1101.17 via Frontend Transport; Fri, 31 Aug 2018 18:24:44 +0000 Authentication-Results: spf=pass (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=cavium.com; Received-SPF: Pass (protection.outlook.com: domain of cavium.com designates 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by DM3NAM05FT030.mail.protection.outlook.com (10.152.98.142) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P256) id 15.20.1122.2 via Frontend Transport; Fri, 31 Aug 2018 18:24:44 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Fri, 31 Aug 2018 11:24:40 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w7VIOd3x024225; Fri, 31 Aug 2018 11:24:39 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w7VIOdc6024224; Fri, 31 Aug 2018 11:24:39 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH v2 02/14] qla2xxx: Fix incorrect port speed being set for FC adapters Date: Fri, 31 Aug 2018 11:24:27 -0700 Message-ID: <20180831182439.24182-3-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180831182439.24182-1-himanshu.madhani@cavium.com> References: <20180831182439.24182-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(39860400002)(136003)(396003)(376002)(346002)(2980300002)(438002)(189003)(199004)(54906003)(72206003)(106002)(316002)(42186006)(16586007)(478600001)(76176011)(51416003)(87636003)(106466001)(14444005)(8936002)(110136005)(5660300001)(50226002)(36756003)(47776003)(26005)(86362001)(575784001)(336012)(186003)(44832011)(476003)(486006)(126002)(69596002)(50466002)(356003)(6666003)(446003)(11346002)(2616005)(305945005)(1076002)(4326008)(81166006)(81156014)(48376002)(8676002)(2906002)(80596001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR07MB4668;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Pass;LANG:en;PTR:50-232-66-26-static.hfc.comcastbusiness.net;MX:1;A:1; X-Microsoft-Exchange-Diagnostics: 1;DM3NAM05FT030;1:ZVOpSNZBnpOlDB5CJzF+yXkxecM9CUDV++zfnE0OWzlHIeUkB4ZmuQyjR/3VkBoxHOK+h8Ez0bmdBqdakBRP3uaHne3YssMio86Lqna5Y9AYN+B3vNwhzXSEn16fZhet X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1c025c8c-bf1a-4fa0-90c7-08d60f6f06bb X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4608076)(2017052603328)(7153060);SRVR:DM6PR07MB4668; X-Microsoft-Exchange-Diagnostics: 1;DM6PR07MB4668;3:629aAc62ZOGjEoAqiu9n9y0GA6hisWBLmfu6JTb7NeanLoObA3sQJ5V8Hnxx+QmduULoauPgh5ZXvLLUXFDA2brgAFvFYa4PFuesdk1iPclxir1G/casP+Z3RuDpXEWAZuUnWUYVPnK6d+2FFJHJC+FaxBWpe7NB5+aapityyz/ZKJiFAHcTmlWQqmUXIvcrE5x9e28FZIDabhCMRXcUB/sjVBKPcpwS6RJQCzg16oblnO1Cq13CvCJBqRcNqdmgG6D00MJck1NMc6sBN8vc2DW+vgHTr/lzJQYmbNQofclK1ZMhUtcxlc5bBCuJ05S5jtHh00J6fQePkJ3LaRAQ1aTRTIVjfUUOcW4gA78brjY=;25:vW6qVspRr3zzm32XaGZ0tpprDJWpTUCdcDYYGVAZtd1GEOsovYLoeHUB2JukEKp3zh8GKHzu40gBWjeM1m50ISKjIUKETS5UkEP2eYT+fKxYCbKvAYQ0OsxdNBtaDvSck9MOzu5nMuHN/t6bAKR5NXh/JLkt458r/QGb90/KnG4PMm3GCFu8570hsUQwqmKqzccsKHCgWGFD86N1UcRMLG1j9fsejc0BKD1CDUX5mv/Z0s/XTSEnNPyw7bOQhlaOzvL9q58zvYZAQKTcv+MlOx8W1gCpjHoyKStNq6lCytAA8myKLD5RH0OHD9vS1gymEUHdjssF0q+7P3B5Q0LkOw== X-MS-TrafficTypeDiagnostic: DM6PR07MB4668: X-Microsoft-Exchange-Diagnostics: 1;DM6PR07MB4668;31:VUlM2U1D9R47J0yuliNsh9y/uN+GUtmb7uWbf28+jMuRb1faJPoNrKeyLJr6X9tdWF6Sr8AxOnvXupgRugeKmP/guNv44xG7ocJns+zwIUGAkcaWGlhX+WHEsCsSLxeXi58atdHnz3tdkcZqnS+xxbHkY+eLfc+nrxchJerF/g7hCf3x0ef+rmKTGJpHtxhQchFxBAvGjK47DO9AKW/WQArV4rjAIM2SHKbRS+ACbnk=;20:D5y6vNY8ZEewE9zcwNfjE+XNhulW6SLBEY7HnsROc6VZt3IbcqdQq0nKNQmAtia7GyqiJO60aPgcl2SCFN6rHmB5rA16P4eZxbP6cfwwc1gK2GDAdcrfAsZJV/tNCDCCF6LKXpNLLELaEkU4OpsH5vHGnLmVAMaHaNBN7cLW4M1GCgHnwa2G3Pm1H9PBIGekgSQm0NclE8UjYGC3sXhgXkcUaDrZlcG2U9xRaOWuCZzXW+Aw63mxUklF5G27H3DHMhkr6bZypkt+hRfts8jhnMDfynZBhMM4yXoMMD7Io1UeQohrKP65owieebtJTuFaO4sfOhzxBonmzk/r3pIHSHTGsXY4QzfxaaNfzey2Qdekyt+azAz9TniyxKFNWZdBpNfZtNJYKA+RXb+A2HtAD9ap/GPmoFc79RbgzcPa5LwO1NObgUlh/XUf5yi0EIFM7m7wAMJooPbFwGz2eYgIFVCwurwmyC6QHiur60f7++rrOqO8W/mZCFKiAvgeoo/U X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93004095)(10201501046)(3002001)(3231311)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(201708071742011)(7699016);SRVR:DM6PR07MB4668;BCL:0;PCL:0;RULEID:;SRVR:DM6PR07MB4668; X-Microsoft-Exchange-Diagnostics: 1;DM6PR07MB4668;4:S99pww8iUr2uMseKI+pZXRM6SZ4oeC5OwygbVzdu83efzPcnf7p5zK20FHxZ05n+XFavGGOCC8WCRK+CK3lJaYsc5KT+b5uAN65W8HGtpdVDuhPhLev5GrmiuZjuS4E8T3/l+dyt+tSVEopHOL6URMt+WzyIVee/hHe3mdalz+au8d2jBfjBWXql6tWq75USbbG8EKENQN/ngEG6YRaL2Lmqpu9oOHMzjHCWpOHRP/7hUD0UZKE9BhG3FuLViRYHwB5EfrDtZ8diokTsjyILZ7RFMUPHdFSmGX2bTZfxUSyzzBe0vR7DmXGF+sVNprrU X-Forefront-PRVS: 07817FCC2D X-Microsoft-Exchange-Diagnostics: 1;DM6PR07MB4668;23:SeGwdz2Oi7vLHPHuKizbd7GryDy+/f4qq/Hd+tGV4Ig0XWYCvHfKnbCaiaRHAMZ7KbpvdacKEyHmHcoBknMWtcRdkL13shMWK8u5skOb0KThJoHyHarws6N0pe1hAAX0OCXnDSf7vaDUdeKPK96vSfc/z0yZCtBn/McnxXPIofPxne6oqzryUDE6oSr0uP5LuR9lXhOSqhhJPyW2CM9bfwdzXzIskOPk8yoiOm4gSXfnKB/eS7ajKG3kmkXhjY4Zg0YyV0GroBPwJsXrrw3Gmynbeuuv/PeZ1/7QLZkXkjzgV0DRJ4cgErEh3tb8MExlvm07KWrbXowPKOQXWHecOUThLjKeFjtjFCibcPuyWFWiPIp5BHIfSGc4CGsCp60Qdz1zBYu27iJpGczcG5NMsxYDub+/SO0VmQ/eXvkxyPzeE7oYGh5zS+8QBc0ycUT0q6Q8wEixlp6Yx+hjVlY5Nre2RDfdW9Gkk54MsH1acZb5p9/bwQDg4TY0WjSOU3dysaVh863dCumc+96dyagLDiToPkRUrnUS9/3yDiKLKIETC1Oh97Ly8ykW6OQ7HSlfWHGDTuAJajLriiAdKvjmKhmI5XOfAaFzU+5uRmCMEoQB9AqbL7JC+klchAC+u6GgAJCJge+FcwGlXgVwPn5YuncmXAK8t4I0oMdbc+yXJ+nMHU5I2NxvQ57uJ3031lMjRZdVb7SMimTtmpQE/SBFzaHeZzMtVWXSEHGJNJ3bmXVIn4EApWI+OGqt/YU8VBWoYDg/NhN8hO3Lz4jOYJecZ+7DJ/xw0f8otMRgIf9EUuf8mEjZOXYAMSyo7NCzfCIwGRExMUKSTS4r91xSa5uK/DZAh5T3t99hn1B1aBUWtswueio5TB6i1NCKZVnT7ObUWSSvJ8xdIQ1dlfmyZRMbN0drcrzfNgcnQiU3/+GSX2ADkosq+8HnXanj/BmtcDc+C/JG83WpktPiw7W4IyzBuHJIdTRxVituhDI3PFdQDuSjKCJPS7drH2C93qBhNOPyJkHhFCBsDpIMG1OW/bmntmR4iGpQXdpERc5o2W/ijL18+4Yp0Mh+OrB3eBrzz0RzzWudVODw2cI3WAtyvXoANtIbHC/8oyueVWxRC5lSPDzkLmJUM21xCunPIKd1EKBlrWnHbm2shB7mNSfMzJakmA== X-Microsoft-Antispam-Message-Info: f21LWyAG7jZodiTwX5b10/7A7KcQ0DO88GltEZ+FzuzYCXlyKCbPV2zARrS4SbfYWC/Y+IAhrmRSAiwG+N+1m1bwD0ITVRRSFF5di7pyde1DI5xjIDwsVk6Ho7uA2yVT5un7Evt44680jqy+vJep6t3g7te2/AslGLP8tRUitTqqV4j7gqet6koQlAUMVM9HZrjal0WaRUzOyQjq8gnVcY148WTtBCqDTOZeKyEUj4XzWzysZHwW4HJlZSQfYgvay2mqdKkuxDUAAbb/IBi95xtqmUG5vI8E0H75WYHn5onD/gomxAwvBCMjp03oe9RNzD+OCfwywQkysT0O96k0+nBV/OS/81rqrnCntjhtRZo= X-Microsoft-Exchange-Diagnostics: 1;DM6PR07MB4668;6:lSmmSxUzKO0kHrc84W3hsKzbIGICXzFFYfyIN6Dv0SlstZF6KWIGwjUK4m4Mo+8fOfuhwuVo0OTdOHuMQ/mTg5NaVEHgUxuErmKt82n3oc+hWgICj8Kh2qrp/SnRnxVep3u8OzAwyi80/cArcw4Rh/0kQyJgLQvpgELxCg893nRxkRjAoTCP2SJwo02fxS7gFGL3g6qKGUFsnib6Ql1hyZrC4Mrage1Ulg701R+qWTmL/6zMQVPQXcvrNlv5qJ+NB3I2mGz+HDB3vCCGsoYF+gKkE44ThQR/tyxVF4xheOH8ght6YFEiRN4aNKMaEtEYQ64ZoF7NbYCxU8XT6eh6NcICu33A4vPoex/HgzeNblAcyi5d2W67UJEsd5QpIQTdQM3265nKRu6iCmYR7thDdYDgLTGH/gsb3VY9EbLARtip6XhYrepwXCuhSGmFqB5MlFqA02xMqSygznkBXfyS5g==;5:t1hM4GJim3E63Keir973A2fIbTv3d19A3ZCNaNHYvjSLqWVKNE5ZOZQNubljH5GDNhEqLSReAiYUXz3jD1EhR+B49Qegpt+OKyLULOmOUYFLNqYJf3R3lr49JJlkrDSqnRSdQ9AbgnDP6rrKkn67FX9XmzYNsVS8XToVr+JkAZo=;7:45ZDWPSO/1LLqiB9P3Aa/rXjL0Z0EKastZ/EeX4feDpe7QRe94L3GFuVQSmDvS8ZmnnqLYYboxtK1ERa1hn+2Z9E9LQpUV7CzbY8zc4R744hVJPEaM1LupZz6vHwD4ORIQra+h+pVFFkkTsaLgXE2lOyckZJhhGhyZXxEHDcF/ylxT9yHopg6wZuZxxqnaTEquRpA9rYCOxVHbRaj6H2s0BBGH10A84zKfCAnpnRcpRnhlsmO28VYly2EQFoW6iH SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2018 18:24:44.5277 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1c025c8c-bf1a-4fa0-90c7-08d60f6f06bb X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194;Ip=[50.232.66.26];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB4668 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fixes: 6246b8a1d26c7c ("[SCSI] qla2xxx: Enhancements to support ISP83xx.") Fixes: 1bb395485160d2 ("qla2xxx: Correct iiDMA-update calling conventions.") Cc: Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mbx.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 2c6c2cd5a0d0..c73039916c03 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -3762,10 +3762,7 @@ qla2x00_set_idma_speed(scsi_qla_host_t *vha, uint16_t loop_id, mcp->mb[0] = MBC_PORT_PARAMS; mcp->mb[1] = loop_id; mcp->mb[2] = BIT_0; - if (IS_CNA_CAPABLE(vha->hw)) - mcp->mb[3] = port_speed & (BIT_5|BIT_4|BIT_3|BIT_2|BIT_1|BIT_0); - else - mcp->mb[3] = port_speed & (BIT_2|BIT_1|BIT_0); + mcp->mb[3] = port_speed & (BIT_5|BIT_4|BIT_3|BIT_2|BIT_1|BIT_0); mcp->mb[9] = vha->vp_idx; mcp->out_mb = MBX_9|MBX_3|MBX_2|MBX_1|MBX_0; mcp->in_mb = MBX_3|MBX_1|MBX_0;