From patchwork Thu Sep 27 05:05:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10617235 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 22BC9180E for ; Thu, 27 Sep 2018 05:05:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1250F2B199 for ; Thu, 27 Sep 2018 05:05:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 066662B247; Thu, 27 Sep 2018 05:05:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5A9FF2B199 for ; Thu, 27 Sep 2018 05:05:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726708AbeI0LV7 (ORCPT ); Thu, 27 Sep 2018 07:21:59 -0400 Received: from mail-dm3nam03on0046.outbound.protection.outlook.com ([104.47.41.46]:9132 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726469AbeI0LV7 (ORCPT ); Thu, 27 Sep 2018 07:21:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nPy+n8Kqkiopo4Zjt2PhJ+fTm7Z5roiECKh4YF92FNA=; b=PguMY0IRMBH14ZRmcACX1ujCUClgkNatTrjIzg+18vhSPKE/Ej/Q6VoHwyu50TWtIEDmADpuwEo4P97r0s9dKR0w/kbb5xXnwFRJvgdtMQNmmNehOad5NONT3JYxFQ8jBAKO8PH8DLB6FUq0QorfUB1EGfuJwTYjUp5/4AH0KWQ= Received: from CO2PR07CA0052.namprd07.prod.outlook.com (2603:10b6:100::20) by DM6PR07MB4393.namprd07.prod.outlook.com (2603:10b6:5:bf::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.17; Thu, 27 Sep 2018 05:05:34 +0000 Received: from DM3NAM05FT007.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::207) by CO2PR07CA0052.outlook.office365.com (2603:10b6:100::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1164.22 via Frontend Transport; Thu, 27 Sep 2018 05:05:34 +0000 Authentication-Results: spf=pass (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=cavium.com; Received-SPF: Pass (protection.outlook.com: domain of cavium.com designates 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by DM3NAM05FT007.mail.protection.outlook.com (10.152.98.113) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.1185.5 via Frontend Transport; Thu, 27 Sep 2018 05:05:34 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 26 Sep 2018 22:05:20 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w8R55J71007202; Wed, 26 Sep 2018 22:05:19 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w8R55JKE007201; Wed, 26 Sep 2018 22:05:19 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH 5/8] qla2xxx: Fix driver hang when FC-NVMe LUNs are configured Date: Wed, 26 Sep 2018 22:05:15 -0700 Message-ID: <20180927050518.7147-6-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180927050518.7147-1-himanshu.madhani@cavium.com> References: <20180927050518.7147-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(376002)(346002)(39860400002)(396003)(136003)(2980300002)(438002)(189003)(199004)(478600001)(48376002)(2906002)(1076002)(106466001)(50466002)(36756003)(72206003)(47776003)(76176011)(87636003)(51416003)(80596001)(486006)(34290500001)(44832011)(126002)(476003)(2616005)(446003)(11346002)(336012)(4326008)(110136005)(50226002)(14444005)(81166006)(26005)(186003)(54906003)(8936002)(16586007)(8676002)(42186006)(86362001)(81156014)(316002)(356003)(5660300001)(305945005)(69596002)(6666003)(106002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR07MB4393;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Pass;LANG:en;PTR:50-232-66-26-static.hfc.comcastbusiness.net;MX:1;A:1; X-Microsoft-Exchange-Diagnostics: 1;DM3NAM05FT007;1:9IpA7YuGwNrlvIu1zx+UnfPv2VO9Gvy1Sl38UGWvPqOqAhOsy0xWD+QQtxxOzTxa7sv5G++5QXWBfHaZ8NdmseAt7vjuc+dT50x58hiSO5v5ijuG85tQKGGIPu+1Shuu X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 02878cc4-07ff-4843-862a-08d62436db4e X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4608076)(2017052603328)(7153060);SRVR:DM6PR07MB4393; X-Microsoft-Exchange-Diagnostics: 1;DM6PR07MB4393;3:K96unQyxbjbO6wq3+FrPuMlP/LyDJNTZfP3dwHvrCkpp2MHnKAZDIt+UbVlboWBj4w3/airPgIa+uSRmvLYUE5cYoIdqHmm1iexC/A7ZC0UkCyTNLJuHDSCt2R1ugJm8sYBSjFD7cnU/zH1GM2SplgzhPWbmUEbccxHm48VEbmzff4tITa1cGjCzDYcqxhNFWZAO7cVJmwAox1wiadxKdcuGc65npGjqrnoTpO+tlOqF8F+xL4iA/F6mmBmkHyLBG7G0YoPdznez3taiD6qRXjcU6U6BDuc85yPS10vb9BhMtMXEM+Y1R9ffQppL91TtzUKsThsRqGvDmrw2KbBwYX8LLTlgkCE664AZIHg6rco=;25:RB1d+tjQnW/ydlgMEj50dAhGhtdlh3WsVFLowNoWn7K2w0jjmHY3B9LbGv5nS0mnxYIRtJRS92haXl+fY9a9OBLLawsi1CfOYeinZ7q7Q75e+ekj9dt7wVwRBFfnICj9JbQ2no0MYIgMzTFWrnpXolP/hQnGx0uBrXL/6Y1rg6nFqr4qUSxxMgati6PJ7DDb/xmbhjuWjULQdMJcBS3dYNjG6lzrOnqdeTcyV4Quw5sTVcCXvr0ZDzeslfrpHnZkdtVRl1CK56BHRt8bJ+pBLkvgEBifp9ocHrG3E0GBOcJLZoRyEntK4cmuun5c9Dd5CvsGskaEpof7lSN5IVSpVA== X-MS-TrafficTypeDiagnostic: DM6PR07MB4393: X-Microsoft-Exchange-Diagnostics: 1;DM6PR07MB4393;31:jRyC5+bVrEGLaJoBaDn/1x1UEqYdcXclMRfwJy83qo+QnCH0UzyZHi2aO69A8+POlrSoEKrI353XURpWFu0kFR1o/XfvhzE1LGV5HDritPquwnid0w8rmBCZ7MjCamg8rPOLY+O2B65Gzap2f7hL1wBPb5ijCfmtRHrPQUj8lGcJN8I42hZgOxdWFsAAeGJ1TsTEuKWUDnixJm5+PtpKcXJv5Y/Jhh7mnSoaN7V33N4=;20:o3rUUHRT39f5JpvcdBDeATqVtNhgWeF4jh7NunU6KT2DCQnIzNMpzUVNUk2vZ1T3Cb2TnTG3N4V0oQDAeNWg3iruHUcuYkRV80a2HqYTiiFQ1IUnJQ2xHoWiap1Hy1H0pi9d43q2vmNAzj+/0LMxfEMROSknxMtyfslxCXIWIGq9K0tdINgHaxJtU8OsPiNPpmK2VPNah5o/I6KFYQ0al/e9KEinSPbnbI2D8H1IQCipuHAun3u9gfD2vzokmlG/izjuJfm9U/+dsNPJ4Ko+vtwjFSMM0PwEwM3cjpyzKAAe/xz4NEML1Se0XSw8n/4zl8Pnva/wJPAdwwgh3LIOiwuFk0SdLOJ147bybS1udRWfKzi3kSUR4DCN0s5qdLR74ztPf+M38nXZtRRI/jZnJIpAJHaMg13oDy6ho3wiXq3sg2rKp4HxuqLMEW3LhvGuptr532x7Ewc0Jtwol933Fj2y0KABN6TQj9TTsigofPj/mWYQKJx2typ+FjV4cAyI X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(93006095)(93004095)(10201501046)(149066)(150057)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123564045)(201708071742011)(7699051);SRVR:DM6PR07MB4393;BCL:0;PCL:0;RULEID:;SRVR:DM6PR07MB4393; X-Microsoft-Exchange-Diagnostics: 1;DM6PR07MB4393;4:8ndpmGprAKsJpO4I3PnKRKOYTPQ6sT3qdoAN2o3cwGUPRecO8WwzAk8ekZyn8WGag2svQAMBuTKdygtfsOiL96EK4TI6og+QdgkPG4ixC/aMKC1wOaNiv6MWo1u4V22OFydd5g16fmd6xRmlc/5tbGPBm8wL71NzhWbBmkEbWHAA6ogS/OGNI9MzdADRBpxPY8tSIDnY9Vm4pw0U8w6v4MqenRYX5+toeF5dOCXKc5bCCN/VAKFgrF47DQJBvBB81VgL4gmW+qSio2idvjL7tTnidioZfCd7p3MNiutog+rLDChIsV4uUF/6zl7to+E9 X-Forefront-PRVS: 0808323E97 X-Microsoft-Exchange-Diagnostics: 1;DM6PR07MB4393;23:Jz62q1Exf8iL8vO2+o7SUkS68qjUN+gT4dWIC8kEXnN/hpO3kvdnjExmHGUiq45rwHg4vGZbxy2wR1E2Z8RIZYwzahLgX96fs97IkUuRC104iYjBSjZGFXo1px2CZC2k9+UPdIsG1X5eC6mwQz7MfEIo1bSLq/WCH9CzirT6jbCBiC0RYJsahiCtNuwzzD+jHMmBNUG8RZhKCcAiPN1jd6pXmAuzlbJBTkvJmI81Ywyo5oEV7KQcm3oAuhRuyU7KlhM8IYniHaaIa+EMzbNos/Fyo1ppl1qqnHbZjt8uUcYcayJpQ1TUiuMY6KtheVtic9bQU9eK0yspE5JfGMYJrpX7wDXvuXbTkCKxEfCxKWX9vp7uLAAAkuEN3d3PKR2jvmmfIY/u4nTf6IlhTDjCskGbYDcmFRE7q3zheG2rXBJ+grEn8ciW0kfL5+BACsdd3mHBPG3dQb13jWOQnBkIMRSEg1tOMixkIJhgSUDKm3xXo4l1mFN7AcqMSa399O+TJP+DdHz7si947YhLR6p6SNTkBhv8dEUWYcUotyZpjUQDBRv4PLHmcRKER5nz1oZqvrUyi20tRAZnxqHbQRRTL+RLAGU0bf5LKwC1LRT/nGvhPk25wH8JuJ+1oiy9TcAG6hlaCQF2OAlhKaAG1WLTrjag4BHY/RGDocGq67CYaTpmJVaC3Y5mtbwkPUKECS9xl/o5HBhFZ3OabD47o4raWYy0zfx40nin1YHtSaiLtYT+fVd1X2kgnuUvDCroeQXIlS2GKtL7XTDjtgTvTwMRbro5TcWzOu9eK8QWa9jIssNXheDpEhcNywr5qNsgon/edo8OWGI6IIaizzn8w7QIlXABWtT8IqiEFfK8OFh2poHYDEb4iUA/QTR8nqgC9W9WSLE4WxWvFeG49VmRP4DGluvKJ41TCt5H2bD5s76qCi2LIKZSbL+pUVmMxmb0DOlvibzyNy8eKks8NnYh5GA2ilfaIMMnZL5wXyAt53kFRc3o6330WqK9mnz77Ryd5yQZHboI1u6Vplo5u1TCAeXOt0NX5+U1mKPDS3Dn8trd3SlvqY1l9TDwrHIBdkfb9BSujs905a1u1f4BM122ONjesSONEH65pgnFfzkOZBznz47peY0TBio5iDvbvQRBeguKtKhV3cXbV6IibItUTo7V0g== X-Microsoft-Antispam-Message-Info: t5V7NbIxP4F7hotd+C/kXny0ZfwQBtjUUc6wli//j3NaFz4/z+aUlx/v8rf/Dt/VcpDBuDeK9yRWI6DXuKkDAONncaLcnyS+mBe9nFTarG40YRACZXIQSn17bazzijlG2AfCISnEqE87nzHQ3eQ7ErJro6FuOJSKtFHkIrmjtc7vmuIhPydGr1UbO4iMp0/02KsDJuBZf2EXqF/gW47iFbbxMbyGw+Fk8pIpDNMawd3xpBlxnC6mdbVNjvpFfG55f3uariyUITWBBbA6tTK8TrwCQKTLNm02UYHg86C5T6SHinzTirn54f15CSUdgDE9qLQT0Ccl/CZUwUn0O/H7oYahvPGnVw6giPazPT/jMKE= X-Microsoft-Exchange-Diagnostics: 1;DM6PR07MB4393;6:tygh5vbcXwerYIwp3dJPt9Urz/WE1rAw00rxbpOxlcqKOxUIQn6iMF/X/9mKv3IQ9SODbtiY9sWS3RZRIpJ0kjRrQiVs720lo4dbDW65Aixu2NeWsGRFzQeKMCrzzzgvLbSmcIBFNRljFCKbPZn1bx7P+fyiD06D0HiknYcDHgYJVCnFAU4s4mWDPcQc67vAimUfU3ktTqTKEzlcT4SFVfunmPSlq5ysyanxM3fRm1fUb+UDRUtL01KX2/kGK58ETzWA9d4PdDNsGwzxadM1cvTnWpEABulLcsFHbiuJ9afGtS0GVI9MihtyMHYNVf0C5We17lBzg8zSpSM4oUNXg8TAT32OOLTv7+JHXNo3wuZ+0Nh7kTC7J3iFESgbXnS8SK4IpbEg3St1ffqkqd7wUYzBmzxWhZpRL9vrqTKcFhGmH9CkPnMJbwtLm1ajtRTZHcQyVkyXwfAp8DZxE5CxyQ==;5:sChwATR+suUySk7ASybNgI1kOLHpS8tf5PQkTMai/skbdK7ZAAzZX3znBu7el3GEYJpwGTBE9jkyxX8qC/CmjWlyGvO3MsMspmrhdRw9iK+eokViXA7qf1CHsSHv7Sn493j+gzMIKMN1jFjn5SYM3Onu6YyQdZfkkRoSV5Zgyrc=;7:Ezo4GQzZG9bb97cNofWUiXL9nbnS/tNzPGdzL/rgmuQAYpruDcc8/4oMV345CDrfgY2Gtb4rw56k23PgIDLU1md5TxryHC3R3dI45sSxF4kAMPxYAneJuejQXtQXCFjQbndwqsYl8sDh12ZlUeC+MUUaZRvFsWzGdkk5oqkDeXZV/TDixTXYFEq2dDMI3N3TOlgCNNAtj7geiqG0hhM+LsSixxmxsKp07bCaQoj509f61+tI0qc+ep40BScCNNZI SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2018 05:05:34.2569 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 02878cc4-07ff-4843-862a-08d62436db4e X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194;Ip=[50.232.66.26];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB4393 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes multiple call for qla_nvme_unregister_remote_port() as part of qlt_schedule_session_for_deletion(), Do not call it again during qla_nvme_delete() Fixes: e473b3074104 ("scsi: qla2xxx: Add FC-NVMe abort processing") Cc: Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index 8dc7a5c64800..e6545cb9a2c1 100644 --- a/drivers/scsi/qla2xxx/qla_nvme.c +++ b/drivers/scsi/qla2xxx/qla_nvme.c @@ -660,9 +660,6 @@ void qla_nvme_delete(struct scsi_qla_host *vha) __func__, fcport); nvme_fc_set_remoteport_devloss(fcport->nvme_remote_port, 0); - init_completion(&fcport->nvme_del_done); - nvme_fc_unregister_remoteport(fcport->nvme_remote_port); - wait_for_completion(&fcport->nvme_del_done); } if (vha->nvme_local_port) {