From patchwork Thu Sep 27 05:05:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10617237 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BD6FD3E9D for ; Thu, 27 Sep 2018 05:05:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A4CE52B199 for ; Thu, 27 Sep 2018 05:05:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 98F0C2B247; Thu, 27 Sep 2018 05:05:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2F47E2B1E7 for ; Thu, 27 Sep 2018 05:05:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727027AbeI0LWA (ORCPT ); Thu, 27 Sep 2018 07:22:00 -0400 Received: from mail-eopbgr680078.outbound.protection.outlook.com ([40.107.68.78]:50720 "EHLO NAM04-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726669AbeI0LV7 (ORCPT ); Thu, 27 Sep 2018 07:21:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AfAvXqv2ylo1SUhD9VcF2WhD71cU56a6DXwL0uDf5Sw=; b=MTTwZrmQWXTZi3RLhuluBNSlhxTu7Bm3M7tgRsYf7MSiMBMc4wkbBe59qiu5z66YdpfRZCjBdMPdHqnvA16as+iM7gXmG9IVXGZOqcL1JZMzPru8jj4vWccFjIzAg/x8esXTG1r7eGjauyzeRIHbIX+GELTbpe3nZ6bKDhD3C5Q= Received: from CO2PR07CA0070.namprd07.prod.outlook.com (2603:10b6:100::38) by BYAPR07MB4662.namprd07.prod.outlook.com (2603:10b6:a02:f1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.15; Thu, 27 Sep 2018 05:05:36 +0000 Received: from DM3NAM05FT007.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::209) by CO2PR07CA0070.outlook.office365.com (2603:10b6:100::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1164.20 via Frontend Transport; Thu, 27 Sep 2018 05:05:36 +0000 Authentication-Results: spf=pass (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=cavium.com; Received-SPF: Pass (protection.outlook.com: domain of cavium.com designates 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by DM3NAM05FT007.mail.protection.outlook.com (10.152.98.113) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.1185.5 via Frontend Transport; Thu, 27 Sep 2018 05:05:36 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 26 Sep 2018 22:05:21 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w8R55Kr3007206; Wed, 26 Sep 2018 22:05:20 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w8R55KJ2007205; Wed, 26 Sep 2018 22:05:20 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH 6/8] qla2xxx: Fix recursive mailbox timeout Date: Wed, 26 Sep 2018 22:05:16 -0700 Message-ID: <20180927050518.7147-7-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180927050518.7147-1-himanshu.madhani@cavium.com> References: <20180927050518.7147-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(376002)(136003)(39850400004)(346002)(396003)(2980300002)(438002)(189003)(199004)(106466001)(2616005)(8676002)(446003)(476003)(126002)(4326008)(44832011)(486006)(356003)(72206003)(47776003)(87636003)(6666003)(11346002)(48376002)(2906002)(305945005)(50466002)(478600001)(1076002)(110136005)(54906003)(80596001)(8936002)(15650500001)(316002)(42186006)(16586007)(81156014)(336012)(106002)(86362001)(26005)(575784001)(5660300001)(69596002)(34290500001)(186003)(81166006)(76176011)(51416003)(50226002)(36756003)(14444005);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR07MB4662;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Pass;LANG:en;PTR:50-232-66-26-static.hfc.comcastbusiness.net;MX:1;A:1; X-Microsoft-Exchange-Diagnostics: 1;DM3NAM05FT007;1:u+J0ALnAN7bhUzp6wWfiAyYrO8+SKb7Uk1O2ASWzfFrfWDxEjdMZ1/Fx616oRjESzNWMQWy07RTk+dvnpl4QWoDKqiAGf7mtEc51xIZwTpIwTPnOfFE5Uiy45Ok048fa X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f77826e-f6c9-4d3e-b49a-08d62436dc9e X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4608076)(2017052603328)(7153060);SRVR:BYAPR07MB4662; X-Microsoft-Exchange-Diagnostics: 1;BYAPR07MB4662;3:Ijo6WrY6VC0bZnFrGcyIUmSlK4mU5RBZkBz/rX3i4vQjkvJUR0b966ctUJyFIvHNrAXfibYarHSiJW+7M5HeAi5pnKnm/LXCKrtG7JgZTXKAPR1p2XNn5Iq9pSXK/D5YHwaqnjdwQbSMaKSXVt35uludYy7kbqHwSg2s6Q0gUNPYE4hz0BC6/lP6qxlwruVuvoiM74B3fjw/SW5uE8U/dJlLy2wwn3K81SKXmq8JWCN8DNxbejy/ytF8Z0ajDqghpRnt22VM5A4bpZa5KuPvz5/rI05h2mW/qTFun5nV861oCcgX2K/BnVdd8atAduzR5gEjSBqjgChI8vNDCdEIJrx+75Pe8cfhuHBvzO8HHzI=;25:lPKuAOHeRtNp5DACOc6WxAc+CLqWotQnclUI3QCxJaOWomXIK7CS1okjes0XFM1Ay12JQFhCnqu1rgfifG1xDC1GUdb2HNgnMAw682sya5a8UdWyWWHPOzW9qdTxt7eHLBTHY+NQ9D/bp4hDqFxrdJEQDXLvrYLpt10codIFe7lZZH9ieZqig/YqzLcHt+q+h4EXbbhPk6+8gwJ60Z69QBGaj2asGGTFzgye1bIzcnWqnETJKQLcehcuhuTxoZRTHDl3XDTkbd+4T1RheeZCQlKyUkEpEZklblYeHUiyCWUJ0qMLWLmeBZiJQCFB8KooI/sDCWeSjF6Tsoolx5fyrw== X-MS-TrafficTypeDiagnostic: BYAPR07MB4662: X-Microsoft-Exchange-Diagnostics: 1;BYAPR07MB4662;31:tOn6IoaCoCMsYRPOXrLYTmNtsxmuMvKA36/Z90kb0JxQo/3Ab61zI3t9DDCq+69gJz0GBTWvujcOT8suwZEB+N94uSEAUEaa0k7rY7lCjc9pzdvhrktM7NFD5CQPd/j7FzX7origxCKBn4DE+lBIS91nqORxeYtCnTy+GQrLAHqRN0SvsvPNdTgbtbdlbnykwAKLTLA1ptrnYzLPUA3DL5VnpMI3m6enJW347yPdwR0=;20:xJ6GH+/oJrR1yul15HfVL+SNupj2SvJ8DpzZvgl5poXJ5i8+pycecpYMI4GS8GuWxPFg16B9Ho9x33uCKgX6zhcRTA3SB81cH+G55ioG/X7ZG1OQVHSyya69v9q+Ka1ZWeTofBFErHvkEcDzjBRSSpDdhUP1GR/+GbDUVz6HTBjpBnX8QdKkNSCAHiIsVxjAJyRboh4mA/Vb5GX5rREzD3lkKKe8Cpjov8LgewsyUfNELRXdL0z5Mf//3L/ShGrIvDPh4BS/xH5ms+lC4IzI1GJ6pgtctf/jgjjO+D4fM3d9PGKzuNZvcM+K0Kj5sKdB+dkYGmQ26kiCgseY6V7mO6InFgGQ5oEkToVpE3oPIfWhWeddBcUuk1Q2fJu45wUag7tu/Mg/OQbL/gnPKZngnCyBWiv5nEa3YV8ZRPbB/RVNxtVqI0SrW8v1fr9hdx8iXxa/fyBB5H6GMnSVkIjq+doBZ7shbHedjiYs9vz596TxOrkx/f9Phh5R6/2q3jGo X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(10201501046)(93006095)(93004095)(3002001)(149066)(150057)(6041310)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(201708071742011)(7699051);SRVR:BYAPR07MB4662;BCL:0;PCL:0;RULEID:;SRVR:BYAPR07MB4662; X-Microsoft-Exchange-Diagnostics: 1;BYAPR07MB4662;4:7GwaqSJ7/gWsYEm+1vY13fP4r5Q2N8JyAOU1ux22g8kX59U1IxkzjHIsazSG7AjrHZBcrFV+765XBfbjJeQ+gikOcQ79nrC/nJOP5Ya6GXZcGLeH1Foh8WL3tSAQtTW+EsNX5oebtwAfUERdriZlf1ot2epnVtYlaJfHUfhR9stYIDfNLBOe/EMmU9MOjAgSR9kYpkwlC1KlXEDfQ83q/w6BKWIctuHA6ElpR8bvlqNbsoospn6Gzz2pNCMnPEsZH5+YoQnz6kjpoCPq4Q6A4w== X-Forefront-PRVS: 0808323E97 X-Microsoft-Exchange-Diagnostics: 1;BYAPR07MB4662;23:L68Bov4/zPpmZaIeUWsPiVAMa7u7TqAtGMcSl1GNLvPqFT+T58wCIk+Sk4i/PASqZ+ZpmI4C5WAAxEfGfq5DTk9gG/fqb8iqx6rAtyC/M5ZGdFKaEOFHDA/yPHQ4TxJ1cXnR+tEYwH1YxLx4QWOj99lXq6CAZsISQbPLaqy9rTjK1OwizMlEVhVleDiifiqX5sJZQEevS9glN4qyJd7BTg+6EiqCMJ5oSsgE5XikjxYiWa9QMbwjq772qWySAt8mZ+YZVSFrzoFOED0Jcq61qmMf/0fl0W5cygKclPR9PntA0prdeCzr6xz9BPVkm/sRTEV7qcbhJvNq+dVJhS4IwqKS4rfnZY7vmlCZvq+Q7UFnlrzEHcaZmFfD+39wEc4WSkXGAgm5xDsxwtupcNctUc8ZaHft7T7Zb40LqH3HLW0ci3gLhvny+PuZqCNlmSC5LDu+TJwoHqW1LQM6pYH4A/8O1Fce7O4wACcglaGtoJ8RRLpgucDv0vkkZlV5y5ua8C7UDL0ijhL8F35YnWA7aAA9OZvMeeQT/D1TNlVosWoD9s5CU8m5S6SJa+/eTmUftLHzL9oBkflzDAFMPTeiAXpPdt4Be8UqdZ23HXl59AVGv6fhVMozhwy85qrId9X9WEAqOw1q+VwOzYrTDVr7M0x+JSezkaJZC1vVlGi3ALAZOsWJctd2rEWPqxBm8HmhniNnIGYothWGiS+wV3Q8BvTa1fOgCReu9768LXLGeIk6mO3DflvpntT49OBhuyq7sGG8WnsiXzjPzddnSh2Qcfi1XayyZWv3vTQvdWZv0hYm+8aNw7eQOHsH0ez5FfX7Vhy9HWnYuyuYAPVUAYSJ5YoF+lXBO5cYfB8ZtO5K00rQ4BsWvOgUDUMSUYeTDBDwTFdV/hF3fbQ7A7ETbKtvO0JRhEGxAzSKufsDtUHC4eufREgzOezIjOuUPC1lX8ZzVJjcy6MsQYyCauBTcTe2jtwcHHQrt1UrLY3x+n6/jXORvPSpDbMWQnpqME+D5r/fBEhngNBJjwrMkQEAn6u5eWvBvYn5TF431adxCDPAkx2RRQxYfW7/W254QDqYCqX97CGacgLZc7lo5G3aCDeA/SBOMvpdjD+U/T0JyZPA3qPmb7kgHTEs/q/z2srDSj3U9/7oJwFDL0dKHMP4BBptuDrDxWoC12xSZCXntK9W7mLpnLjf1bStSDGDjTesTZsV X-Microsoft-Antispam-Message-Info: YXn+3eZeAVypHI6g1Qg3Ns65viRAWLnPPfc7BEHPUaHxzj0j9H2prVPhWAt3f9CS5toNaQIcz1Qrl+kf5uTgbhBtnRQnG1XUlmgLAF+hitQLdmuszJUWCVBw/9R2Z/B9zqAxTq7gIBjb8ocmmgKPVyhZg+N+8VTlyb77Rw7eH0U9gGJmhYckPnqmOZqeCIP6yQo2IeAA8cvE+t/XUkx9U+pK39NlR4CLqthrCV2PkYxKlp1cVdwusR13H1NhvJsIjkapvCr+kQ4Id3XRkRepM2g4BfbRGD8ygcWE5h1a9Fv5ehptYkEMGROL7vWebqWa3LrYSfi0pAeK0KF3zp+/xW6gl3KeIRaM1z5rKxorP50= X-Microsoft-Exchange-Diagnostics: 1;BYAPR07MB4662;6:yjlQuok0jb81ap10lJscK1xtlTTTQk1+CQXvJ7AY1Bo1aC/8reX77jknyO4zwp1XlvkDIhU3LEVIIwVe8/vdohOgU5I5G53cVjl9z5IWyVOled1x6GBpoSVq1OLgOCTSX/GBW+psooLO3Y2ONQU2UeSmEp8fraTedugctyhenLNv0lQKgG8hQrRW81vZc9D2nPAb6NII6JCDOZWYpXb6ovJ+Bgv+On+Yp7F9S45kMZiUGXdDHMu4RdxyNYfSJCDtoGnPjXVCk2mmxYhCZCjuJK7ow+EWaGa/cE/jZpynT3IhsEeqCKMBHn7OwPPWJ4v1ZchrWSIOxq33QGBPFsiQ7G9IQerV0YL6+wqkVN/CCorhAUXHQPqdn7vGF82QwHWAmLoOwEFYHXM7DwuJu80S42SwOzQztiaE2NK4+PU3/zP1T9wec0atNs6eoYEIjPc0dOheLTdHU4w4sURniLI/xA==;5:87GDuPhv7mhXlo6AzJGM/hLLz034jw7IbulVtIcP+LLvlkerKQFtY/tJ9uPn5jSCrqf5EiX2UwabN/DDywsWrgsMDTo82IrY6ZDZ8S0/8x+MASUIuI1AzC2+dkWj3/o7NieSuW8E2cIzRr/rA2Ba0cjawA9NDR6t2CzMYN/6wp8=;7:4/1OhG97iwLcs1mJMMnwBrG5j5YpmcdbbEHPJz0z9lvawzRJSpRZbNkl6W5Ux2n4Iw3QbOLc5OuXxtMir/EBSBApE6fIxTN1WgecuyOPnQMd6BRuVO1oE+2XmeJrMIZ71JULGHDO/YRl5fE2t8PuirZVnyhTWtCbDtH9knQD37isujBY+fcihenu6ZT2Ub5NZh18Z4TvA4gxSx4v/byN9oUoSLwKEY7MkvsKNj7QyAg2dpv+SZob3pyRAo01rMVx SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2018 05:05:36.4757 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f77826e-f6c9-4d3e-b49a-08d62436dc9e X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194;Ip=[50.232.66.26];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4662 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran This patch prevents user space mailbox request from doing chip reset if the mailbox timed out. The chip reset is only reserved for the DPC thread to ensure all mailbox requests are flushed properly. The DPC thread is responsible for the flushing all MBs and chip reset. Fixes: b2000805a975 ("scsi: qla2xxx: Flush mailbox commands on chip reset") Cc: Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mbx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 2c6c2cd5a0d0..596a9b214df1 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -493,7 +493,7 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp) set_bit(ISP_ABORT_NEEDED, &vha->dpc_flags); qla2xxx_wake_dpc(vha); } - } else if (!abort_active) { + } else if (current == ha->dpc_thread) { /* call abort directly since we are in the DPC thread */ ql_dbg(ql_dbg_mbx, vha, 0x101d, "Timeout, calling abort_isp.\n");