diff mbox series

[06/23] zfcp: update width in comment for ZFCP_COMMON_FLAGS mask

Message ID 20181108144458.29012-7-maier@linux.ibm.com (mailing list archive)
State Accepted
Headers show
Series zfcp updates for v4.21 | expand

Commit Message

Steffen Maier Nov. 8, 2018, 2:44 p.m. UTC
v2.6.10 history commit 4062e12b2ba2 ("[PATCH] s390: zfcp act enhancements")
extended this mask by one nibble with the introduction of
ZFCP_STATUS_COMMON_ACCESS_DENIED == 0x00800000 for ACT
(access control table).

Signed-off-by: Steffen Maier <maier@linux.ibm.com>
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
---
 drivers/s390/scsi/zfcp_def.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Hannes Reinecke Nov. 16, 2018, 11:08 a.m. UTC | #1
On 11/8/18 3:44 PM, Steffen Maier wrote:
> v2.6.10 history commit 4062e12b2ba2 ("[PATCH] s390: zfcp act enhancements")
> extended this mask by one nibble with the introduction of
> ZFCP_STATUS_COMMON_ACCESS_DENIED == 0x00800000 for ACT
> (access control table).
> 
> Signed-off-by: Steffen Maier <maier@linux.ibm.com>
> Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
> ---
>   drivers/s390/scsi/zfcp_def.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h
> index 87a1fef5568e..13bfc13eb42d 100644
> --- a/drivers/s390/scsi/zfcp_def.h
> +++ b/drivers/s390/scsi/zfcp_def.h
> @@ -49,8 +49,8 @@
>   /*************** ADAPTER/PORT/UNIT AND FSF_REQ STATUS FLAGS ******************/
>   
>   /*
> - * Note, the leftmost status byte is common among adapter, port
> - * and unit
> + * Note, the leftmost 12 status bits (3 nibbles) are common among adapter, port
> + * and unit. This is a mask for bitwise 'and' with status values.
>    */
>   #define ZFCP_COMMON_FLAGS			0xfff00000
>   
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
diff mbox series

Patch

diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h
index 87a1fef5568e..13bfc13eb42d 100644
--- a/drivers/s390/scsi/zfcp_def.h
+++ b/drivers/s390/scsi/zfcp_def.h
@@ -49,8 +49,8 @@ 
 /*************** ADAPTER/PORT/UNIT AND FSF_REQ STATUS FLAGS ******************/
 
 /*
- * Note, the leftmost status byte is common among adapter, port
- * and unit
+ * Note, the leftmost 12 status bits (3 nibbles) are common among adapter, port
+ * and unit. This is a mask for bitwise 'and' with status values.
  */
 #define ZFCP_COMMON_FLAGS			0xfff00000