diff mbox series

[AUTOSEL,4.19,09/36] scsi: NCR5380: Return false instead of NULL

Message ID 20181122195240.13123-9-sashal@kernel.org (mailing list archive)
State Not Applicable
Headers show
Series None | expand

Commit Message

Sasha Levin Nov. 22, 2018, 7:52 p.m. UTC 
From: Finn Thain <fthain@telegraphics.com.au>

[ Upstream commit 96edebd6bb995f2acb7694bed6e01bf6f5a7b634 ]

I overlooked this statement when I recently converted the function result
type from struct scsi_cmnd * to bool. No change to object code.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/scsi/NCR5380.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Finn Thain Nov. 22, 2018, 9:49 p.m. UTC | #1 
This patch is not relevant to any -stable branch. Please don't backport.
Sasha Levin Nov. 23, 2018, 11:27 a.m. UTC | #2 
On Fri, Nov 23, 2018 at 08:49:39AM +1100, Finn Thain wrote:
>
>This patch is not relevant to any -stable branch. Please don't backport.

Heh, I see why. I wonder why git applied it cleanly :/

Now dropped, thank you.

--
Thanks,
Sasha
diff mbox series

Patch

diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index 90ea0f5d9bdb..fbcbd6db371f 100644
--- a/drivers/scsi/NCR5380.c
+++ b/drivers/scsi/NCR5380.c
@@ -1190,7 +1190,7 @@  static struct scsi_cmnd *NCR5380_select(struct Scsi_Host *instance,
 
 out:
 	if (!hostdata->selecting)
-		return NULL;
+		return false;
 	hostdata->selecting = NULL;
 	return cmd;
 }