From patchwork Tue Jan 15 01:09:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Satish Kharat X-Patchwork-Id: 10763693 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E47E891E for ; Tue, 15 Jan 2019 01:25:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D57FE2BAC8 for ; Tue, 15 Jan 2019 01:25:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C8E5E2BAD1; Tue, 15 Jan 2019 01:25:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 78C4E2BAC8 for ; Tue, 15 Jan 2019 01:25:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727781AbfAOBZa (ORCPT ); Mon, 14 Jan 2019 20:25:30 -0500 Received: from rcdn-iport-6.cisco.com ([173.37.86.77]:44237 "EHLO rcdn-iport-6.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727777AbfAOBZa (ORCPT ); Mon, 14 Jan 2019 20:25:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=644; q=dns/txt; s=iport; t=1547515529; x=1548725129; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=q6/gTAUDLjo3OJ/cxpaGNY7eRep0lG/NvvUUZ52qpiA=; b=GBIAAYHr+MHRRaLT4KT3U+GsQaVS74kORi4RV2ugEz0zGvzwW0d6RDEs FZX1QVJpGbCtfiC/wyLbPr+s+byOIDwtneWctXVCfCBvnCtFB1iVCDsms iz7RZeDSGvhFvYgfueDNctqFNF48uO/+Y0dUWXfGT93hjy+RvO1edW9fV U=; X-IronPort-AV: E=Sophos;i="5.56,479,1539648000"; d="scan'208";a="505651151" Received: from alln-core-11.cisco.com ([173.36.13.133]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2019 01:16:04 +0000 Received: from satish-ini-cisco-com.cisco.com (satish-ini.cisco.com [10.193.101.67]) by alln-core-11.cisco.com (8.15.2/8.15.2) with ESMTP id x0F1G2Bn016303; Tue, 15 Jan 2019 01:16:04 GMT From: Satish Kharat To: satishkh@cisco.com, martin.petersen@oracle.com, jejb@linux.vnet.ibm.com Cc: linux-scsi@vger.kernel.org Subject: [PATCH v2 03/10] scsi: fnic: vnic_rq_clean changing BUG_ON to WARN_ON Date: Mon, 14 Jan 2019 17:09:22 -0800 Message-Id: <20190115010929.15347-4-satishkh@cisco.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190115010929.15347-1-satishkh@cisco.com> References: <20190115010929.15347-1-satishkh@cisco.com> X-Outbound-SMTP-Client: 10.193.101.67, satish-ini.cisco.com X-Outbound-Node: alln-core-11.cisco.com Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP rq->ctrl not enabled when this is called is bad but not fatal and can continue. Signed-off-by: Satish Kharat --- drivers/scsi/fnic/vnic_rq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/vnic_rq.c b/drivers/scsi/fnic/vnic_rq.c index fd2068f5ae16..74d2f2cd6370 100644 --- a/drivers/scsi/fnic/vnic_rq.c +++ b/drivers/scsi/fnic/vnic_rq.c @@ -171,7 +171,7 @@ void vnic_rq_clean(struct vnic_rq *rq, struct vnic_rq_buf *buf; u32 fetch_index; - BUG_ON(ioread32(&rq->ctrl->enable)); + WARN_ON(ioread32(&rq->ctrl->enable)); buf = rq->to_clean;