From patchwork Tue Feb 12 23:40:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Himanshu Madhani X-Patchwork-Id: 10808953 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BF9A5188E for ; Tue, 12 Feb 2019 23:42:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AB8512C080 for ; Tue, 12 Feb 2019 23:42:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 96A952C132; Tue, 12 Feb 2019 23:42:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0A7052C080 for ; Tue, 12 Feb 2019 23:42:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732232AbfBLXmI (ORCPT ); Tue, 12 Feb 2019 18:42:08 -0500 Received: from mail-eopbgr780051.outbound.protection.outlook.com ([40.107.78.51]:63952 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732160AbfBLXmI (ORCPT ); Tue, 12 Feb 2019 18:42:08 -0500 Received: from DM5PR07CA0113.namprd07.prod.outlook.com (2603:10b6:4:ae::42) by DM5PR07MB2908.namprd07.prod.outlook.com (2603:10b6:3:9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.22; Tue, 12 Feb 2019 23:42:06 +0000 Received: from CO1NAM05FT058.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e50::200) by DM5PR07CA0113.outlook.office365.com (2603:10b6:4:ae::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1622.16 via Frontend Transport; Tue, 12 Feb 2019 23:42:06 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by CO1NAM05FT058.mail.protection.outlook.com (10.152.96.176) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1580.2 via Frontend Transport; Tue, 12 Feb 2019 23:42:05 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Tue, 12 Feb 2019 15:40:59 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x1CNex09029869; Tue, 12 Feb 2019 15:40:59 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x1CNexPr029868; Tue, 12 Feb 2019 15:40:59 -0800 From: Himanshu Madhani To: , CC: , Subject: [PATCH 04/12] qla2xxx: Check for FW started flag before aborting Date: Tue, 12 Feb 2019 15:40:38 -0800 Message-ID: <20190212234046.29809-5-hmadhani@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190212234046.29809-1-hmadhani@marvell.com> References: <20190212234046.29809-1-hmadhani@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131944885260858874;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(376002)(346002)(136003)(39860400002)(396003)(2980300002)(1110001)(1109001)(339900001)(189003)(199004)(50226002)(110136005)(8936002)(26826003)(87636003)(8676002)(316002)(16586007)(2906002)(54906003)(68736007)(4326008)(36906005)(81166006)(51416003)(81156014)(50466002)(76176011)(336012)(42186006)(498600001)(69596002)(80596001)(26005)(305945005)(48376002)(126002)(476003)(2616005)(6666004)(356004)(446003)(106466001)(486006)(47776003)(86362001)(4744005)(53936002)(105606002)(1076003)(36756003)(85426001)(11346002)(97736004);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR07MB2908;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-Microsoft-Exchange-Diagnostics: 1;CO1NAM05FT058;1:Vi7LLAhZIv/pNilck/yG/R4JoGrJzsq415kMcmIYQUfDDqjJ3tQ2avUsFMJZohG2Nyow7Ea3C+Zm0PPqDJQ/MKcUzqSEYcXVZKgv79do+EsfzyQTE5+vd20Cndhlbk1JU6eqjW9+kORxVbZn3+cvYNxwsnCGTeR1zADJ5UcV8pk= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 435e9fbc-b1a6-4a6b-e199-08d69143b256 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600110)(711020)(4605077)(2017052603328);SRVR:DM5PR07MB2908; X-MS-TrafficTypeDiagnostic: DM5PR07MB2908: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 0946DC87A1 X-Microsoft-Exchange-Diagnostics: 1;DM5PR07MB2908;23:/92TNurw6JfPaTXitSQC11tt392P1xb10y8OfiwkEtFlWrdjA6e5JRj+geK8JzSmlqxngcbndYfcjDZ+Pa/rKvuVIQOhNU3STWBolPR6NdXHTMZPXNsJcZl1kqDA2aS89iBWBYqx2o2zC8BlCnXMSlmwGaxb1/RJ8DJAjj3Bep9EezHychv0LXQ6osrpG8J3pGVMdL2JCwO8RC1OR5Y+835Jp8iI28tA83CB4mcocCBNG1mqTL/soYtfAN+SgZYV1TdzfVgBAX3XTO2LAINhu92bS2bdbonXaAWQJ/k2xjZoc+jwlyru9ZkMg0oYmTNAy14HpvBYfSHkOe2PCEJU8LjvlBlsRgTlQw8+iiQVHI9V65jHkKu/mD0Nm07eaugneq9fRYy5Pp1EbP/pk2fpxb39q4UfYoIiWlczWAUDjQb8M18t2BDJztCwwiv9QNIZNYfgBTmit+F3IBr3Cw0dhu/A7YNLf9cMTmy/NAugBPyUjrzo0k6PmsYtz2Qkm5W+N7VRKMiqw9LhVY1CKEfoDyNOyiOjvU9Na8y+OjNSQOVsTeK4koNq/ukAtZ9P2vKWII6+TER0aUuK8dSf3xUz9617FMR3Hd3WIk1fFsC+Z9AedlEnmg2bcpIOYRHp3vl3+87ZB8L8TJz+aMEkEc18TJ7wgCn2zQcQhr9nvbAlzlwFwPCTBmxeaSD70fDdB+230Csp5s3fTVwDduC9li7cgzj2XnbuEc6jGyMHoTpSDecSsYEpyPHTZsZkImQgMtGy2zegSv5LeLKhhY8OwgcRkkpAVb2jgbs4smOxfbELx9/AqM0kxJFnUCkn0je24xtEJpOkUCs9ynldI3U93ec9gJgeduUFLMWrm+zSrP73zUPBPS2z4RWJ4IWKlib68752+H5FWzRww97MCWKS0hU+QF2cKD+ZN4HyFTj0l9VQ9dREWOgF1vx/8YSzalWyQGAWz6R4XDh0h+c1FjbQ9SD6SH7lMHibLzYUPXExlDqPya9JLJDszMx+o9UV/DodS0dh3EIYb9S4l1p3yWUD0PzjRHrKWMNt2VLbVMIOEH/C94gKX3tq9v5OpR4CaOsTxuri/ydAnPG2HYaDygbs50q4Q768GASP4wekdKzY8m1jBS51MEWTasjUbOziOXTF+YCP61JdyuSwAtQlMVdMEdc0cmGwXvDuHkqUheqvVOqYpKiXD4LqNtEtUeGFqCYL/OPxaOfMEmye/5Mw8+XL0VUaDQ== X-Microsoft-Antispam-Message-Info: kmEAjaYc587aGjXuQETNX4efrZftKOimgGYjOb02x3Z9WX7fda/V1mjHTO9R0scW9EFsCOE9jChWzwnaQArpC0a/kBWzmkbcqt31M20vgJjZfA9iYJMWSohbbeFRyqbPOQVSM8HpX3E+K0fm9u2VtNGp/5Z4W4ljPNxDSAT0yMkMFipcm9icLah1grbM3edEXsAMSDRNpEc2b4PtGSjDi0OC0GiOrtfb682KTNbfnj9HgEHNc3A7aoa4oJligNaLFSPq0H33AAFV3H5JcudaSiYU2QpMQhGYgO/YhJtl7AFfGuGBqIbgk4Vph7wsM8NDpZhkqKhD3kE3/RTQZPpK6Uz7e75VjajKwzEg4zsBZB7Ol6gXIpWP1MlSDz/Xkn1bkmX28OWoFNZzkXppHahqDmb2iBTPSxfmRnjyvO+wyC0= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2019 23:42:05.7386 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 435e9fbc-b1a6-4a6b-e199-08d69143b256 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB2908 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For FC-NVMe, if the fw_started flag is not set or fcport is deleted, then do not send Abort command Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index 69fb7c605c75..968fd3e66dd9 100644 --- a/drivers/scsi/qla2xxx/qla_nvme.c +++ b/drivers/scsi/qla2xxx/qla_nvme.c @@ -185,6 +185,14 @@ static void qla_nvme_abort_work(struct work_struct *work) struct qla_hw_data *ha = fcport->vha->hw; int rval; + if (fcport) + ql_dbg(ql_dbg_io, fcport->vha, 0xffff, + "%s called for sp=%p, hndl=%x on fcport=%p deleted=%d\n", + __func__, sp, sp->handle, fcport, fcport->deleted); + + if (!ha->flags.fw_started && (fcport && fcport->deleted)) + return; + rval = ha->isp_ops->abort_command(sp); ql_dbg(ql_dbg_io, fcport->vha, 0x212b,