From patchwork Tue Mar 5 10:58:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10839299 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8CF591390 for ; Tue, 5 Mar 2019 11:00:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7BE802B5E4 for ; Tue, 5 Mar 2019 11:00:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 79A3D2B8AE; Tue, 5 Mar 2019 11:00:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4B4B72B5E4 for ; Tue, 5 Mar 2019 11:00:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727450AbfCELAL (ORCPT ); Tue, 5 Mar 2019 06:00:11 -0500 Received: from mail-eopbgr780043.outbound.protection.outlook.com ([40.107.78.43]:13540 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727401AbfCELAK (ORCPT ); Tue, 5 Mar 2019 06:00:10 -0500 Received: from DM6PR07CA0071.namprd07.prod.outlook.com (2603:10b6:5:74::48) by BN7PR07MB4372.namprd07.prod.outlook.com (2603:10b6:406:b5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.15; Tue, 5 Mar 2019 11:00:08 +0000 Received: from BY2NAM05FT020.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::208) by DM6PR07CA0071.outlook.office365.com (2603:10b6:5:74::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1665.16 via Frontend Transport; Tue, 5 Mar 2019 11:00:07 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by BY2NAM05FT020.mail.protection.outlook.com (10.152.100.157) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1686.5 via Frontend Transport; Tue, 5 Mar 2019 11:00:06 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Tue, 5 Mar 2019 03:00:02 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x25B02xx013406; Tue, 5 Mar 2019 03:00:02 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x25B02vV013322; Tue, 5 Mar 2019 03:00:02 -0800 From: Saurav Kashyap To: CC: , Subject: [PATCH 20/26] qedf: Don't send ABTS for under run scenario. Date: Tue, 5 Mar 2019 02:58:55 -0800 Message-ID: <20190305105901.13185-21-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190305105901.13185-1-skashyap@marvell.com> References: <20190305105901.13185-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131962572072724854;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(396003)(376002)(346002)(39860400002)(136003)(2980300002)(1109001)(1110001)(339900001)(199004)(189003)(16586007)(5660300002)(86362001)(80596001)(126002)(48376002)(47776003)(305945005)(76176011)(6666004)(51416003)(356004)(36756003)(4326008)(42186006)(54906003)(6862004)(36906005)(2906002)(53936002)(69596002)(336012)(97736004)(316002)(26005)(8676002)(81166006)(2616005)(2351001)(476003)(105606002)(446003)(50226002)(8936002)(11346002)(1076003)(50466002)(68736007)(486006)(85426001)(106466001)(87636003)(498600001)(26826003)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:BN7PR07MB4372;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6864f7cd-754a-4c3f-c3ea-08d6a159ba73 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600127)(711020)(4605104)(2017052603328);SRVR:BN7PR07MB4372; X-MS-TrafficTypeDiagnostic: BN7PR07MB4372: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 0967749BC1 X-Microsoft-Exchange-Diagnostics: 1;BN7PR07MB4372;23:WMalkXqTKbhB+nyeEv7D3Di58KNrLjVcGuwZmtGXoVbiLoI823MBOmXu7boFPHgR6CTpcBZpQlQnNdeTA1C/HB+MIeOuGaz15W01XkXwk2sYmcUzE1fu5r4ShxgTm1XdsJaIIXVKmkDIYERUiWlGdZZ86wcHV2nZti00r0J7ZBANVRNrUuIp5hW2+WVwDREF7kCgTSuTAkVvGcHJostoBtYB2kcef6JFWIpiMpxBNd1QqoG0JV4ASmqCNR8VVKK9XnnHZsmsn+DzGlov+U+ao9MWJIOFvTwxqE2BcZjNMN09OP3QnAWm5D7VlTk3TSc+voW6qFIZTrDdec2LZoja1BgkvXbgvDchlYSKie1Ahw6jPicQnzdVI6gAtluvGqxDQi6p+eFtg4O1AuGc4UvF+gqEfOO0h4tsyXd7QVVshF8cXFxAROn2936PiO5dYDngt9xoQs11/timyxoKfMMBBdjvNhWquzEFpBK15eSSj24LV3DvoseznRJybVbwSs2KKoyztkDqPRvKtD1sLbiaRFSxsqgkoqzZJAT6ORjLKvluXEMhnxV5IfYhzyVUO1vHq6rLQCNJBfyxu3Q8IDFQWaslxk9Mk37ufccDuhkVou5J9gjWqwqAy29NVf1XGic3aZ/frMXWh8ZZnJH1syUNNFghUcZxKza0+ERh6dWtOZcwAe0VsxuhB0vAxD0dBEXY5g4rOECIHIxhPnFRS+qElNSxh7P5rSBK0u0b8+mfWqDPQN2qKhUR5Q+VCpt794qC1UN4vDTRfZ5iC0g1hWbyRYhC2q19r7jUblOiXutc21EM7REZJEj98x25r/2gmzkmVVfAgs73X+OLLbzKv8xNyUWqeJnLrmCaUTqmA0XbL64JzRYbOgEhhS87odErpjWP4jeorQp5XBYXG79XvhmlomC80QF4LHd2Ilfz+PaBmHmsPw1S2xM67nIWkPPLLi1LWkGH64tDY1TRaGKosS77eql06tjZSykdHfIapC/pgm2e/7cHfRMCfD1ryPBoH6bGMm7/XZFzXJoBbMA82/TfODLOZgifjmXMQ3cmp0SdAsjMNsmGmfq3WDAuiM5y54ojl/zaX41iySg0ypsTF/CLl30Cz83QdDDeWrekLrRop8LdTUlxPDFsgCidfHni2tNLpolWD4Q6g2PNB2j8I3ynJ13VMcdIN/e67WtIx1AILwv9Usw1pRuvX90IewjteG1HEpZ891j31kVH0shj/cQaRl39fEfFSidmm5h4xwv6D2Y= X-Microsoft-Antispam-Message-Info: wXt3eGnMtSxzqlBuNEimCXaRIiBzA0RnmJEdiJ9iBpzofqFZpP0BD5IPw33RSkMC+gLjgbZQ/I0zgZsoNRnHTCwN7aC40tQ5Xjr6wh8BFlH1s9QaVc3zwD5kbOqtw92QjTJ2ytTtd22gZbAEKs7kCldIWJvFyuKH3WCOH1TYmAs7ocybprX/+FXGu+4+js1rTqe4IUnZZZXC4EKFb2PH3dcWH+0BkKUtOO+PliGgeBzCiJfsc05RjumAZ/Apo2JbpYMGv0VPNrqmZ3Ocdb3K5yPMOkyw+fJwNleVp1aT7bjDAFUdhvmecfHfqStVjw+m6Po+TKd3G7nWMo5W8B3ziMjB6GWDhnFfInG776TsY3Y+bfLTsAJN2pVeL6d9znEH32SixKzEeLkXhHL5d1HYGzfKwyH5qlw3hPZ+qpCTVQo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2019 11:00:06.8941 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6864f7cd-754a-4c3f-c3ea-08d6a159ba73 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4372 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP - Command is already completed with underrun so no need to send ABTS. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 30932a8..5e7745e 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -1100,7 +1100,7 @@ static void qedf_unmap_sg_list(struct qedf_ctx *qedf, struct qedf_ioreq *io_req) void qedf_scsi_completion(struct qedf_ctx *qedf, struct fcoe_cqe *cqe, struct qedf_ioreq *io_req) { - u16 xid, rval; + u16 xid; struct e4_fcoe_task_context *task_ctx; struct scsi_cmnd *sc_cmd; struct fcoe_cqe_rsp_info *fcp_rsp; @@ -1200,14 +1200,6 @@ void qedf_scsi_completion(struct qedf_ctx *qedf, struct fcoe_cqe *cqe, else sc_cmd->result = (DID_OK << 16) | io_req->cdb_status; - /* Abort the command since we did not get all the data */ - init_completion(&io_req->abts_done); - rval = qedf_initiate_abts(io_req, true); - if (rval) { - QEDF_ERR(&(qedf->dbg_ctx), "Failed to queue ABTS.\n"); - sc_cmd->result = (DID_ERROR << 16) | io_req->cdb_status; - } - /* * Set resid to the whole buffer length so we won't try to resue * any previously data.