Message ID | 20190305105901.13185-26-skashyap@marvell.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show
Return-Path: <linux-scsi-owner@kernel.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8909317E4 for <patchwork-linux-scsi@patchwork.kernel.org>; Tue, 5 Mar 2019 11:00:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 77E872BADB for <patchwork-linux-scsi@patchwork.kernel.org>; Tue, 5 Mar 2019 11:00:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6C1482BC1D; Tue, 5 Mar 2019 11:00:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 146B52BC06 for <patchwork-linux-scsi@patchwork.kernel.org>; Tue, 5 Mar 2019 11:00:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727574AbfCELAg (ORCPT <rfc822;patchwork-linux-scsi@patchwork.kernel.org>); Tue, 5 Mar 2019 06:00:36 -0500 Received: from mail-eopbgr730075.outbound.protection.outlook.com ([40.107.73.75]:33184 "EHLO NAM05-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727401AbfCELAg (ORCPT <rfc822;linux-scsi@vger.kernel.org>); Tue, 5 Mar 2019 06:00:36 -0500 Received: from DM6PR07CA0021.namprd07.prod.outlook.com (20.176.74.34) by DM6PR07MB4377.namprd07.prod.outlook.com (20.176.95.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.19; Tue, 5 Mar 2019 11:00:34 +0000 Received: from BY2NAM05FT011.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::209) by DM6PR07CA0021.outlook.office365.com (2603:10b6:5:94::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1665.15 via Frontend Transport; Tue, 5 Mar 2019 11:00:34 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by BY2NAM05FT011.mail.protection.outlook.com (10.152.100.148) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1686.5 via Frontend Transport; Tue, 5 Mar 2019 11:00:33 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Tue, 5 Mar 2019 03:00:18 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x25B0Hc0013432; Tue, 5 Mar 2019 03:00:17 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x25B0HL4013431; Tue, 5 Mar 2019 03:00:17 -0800 From: Saurav Kashyap <skashyap@marvell.com> To: <martin.petersen@oracle.com> CC: <QLogic-Storage-Upstream@cavium.com>, <linux-scsi@vger.kernel.org> Subject: [PATCH 25/26] qedf: Fix lport may be used uninitialezed warning. Date: Tue, 5 Mar 2019 02:59:00 -0800 Message-ID: <20190305105901.13185-26-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190305105901.13185-1-skashyap@marvell.com> References: <20190305105901.13185-1-skashyap@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Matching-Connectors: 131962572342311714;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(39860400002)(396003)(376002)(346002)(136003)(2980300002)(1110001)(1109001)(339900001)(189003)(199004)(2906002)(81166006)(356004)(8936002)(80596001)(8676002)(6666004)(81156014)(68736007)(26005)(97736004)(48376002)(4326008)(6862004)(50466002)(50226002)(53936002)(486006)(1076003)(2616005)(69596002)(85426001)(126002)(476003)(105606002)(498600001)(106466001)(26826003)(36906005)(446003)(54906003)(47776003)(87636003)(16586007)(2351001)(76176011)(42186006)(86362001)(336012)(11346002)(5660300002)(51416003)(36756003)(14444005)(316002)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR07MB4377;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f0bb1de5-341f-4559-ecf2-08d6a159ca92 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600127)(711020)(4605104)(2017052603328);SRVR:DM6PR07MB4377; X-MS-TrafficTypeDiagnostic: DM6PR07MB4377: X-Microsoft-Antispam-PRVS: <DM6PR07MB43773890EED05ADE55D322FBD2720@DM6PR07MB4377.namprd07.prod.outlook.com> X-Forefront-PRVS: 0967749BC1 X-Microsoft-Exchange-Diagnostics: 1;DM6PR07MB4377;23:l8+pSSek4M9MCM85oeHQXAqgOFNqqOZgp1/ueOPowysWYJ1xJFvvmHkfnDUOIaE8JkmtsuDWpnRm/tw40lwFe8NBqKWjT+v0K1oc2c2VKnZm2hlDZfW3q+nAMBm+wCbtZ0xpG/PEp6PdBAv5F4YUztrg3BJWg4Kvx460Pe0piHdBI6nUfJAqNLPSgIcEH7qzl+o5Hf7f7XjAj5EabOVtqHrEnUgY0CpxYnoPbBE4kJSyKib1xvdaiYDqAz6OOAyf3MJoYUQponbaTpg3w6f9lkbbdtK7dQ5AnZ5NLTO489V5PdjvNffQHT/LhDLF8lfeAoA0epKJCMiH3KfruvF59vYt9Mrgo9/Bu72HauIkQb4ao8ZU3Jyb1aiqsSP0BWHffPZjBEhRt39cPHvzaLbJWQCIP8kpIKMhNIMVcOgK6FUVeArDMkXKKiNLpRfS2agA49h5yqMdVv5cxbkIwE1HucuCWfMdpzJbvytU06nzncFXvQBP9ZOJOpf8vdCfdweqHVt+PkyridfFCHSWc2wkmIiRp3UYqo7DI/jtzOWVYAhemf/Vwv9FPxzMsVGQOmq7eKaLcNBK4bDEx+jfNZboZDPDKmhiB24LX8y3ynQoaT0xte2e3A0ZGZFRQJADe3aG2a+nLQrfvkL/4I/zoTjAIvz1a1pK4OmjgjyclS7ELWlc3Ae4DfoChYhtbfpR/egkvAb6hHDy9oNHhVXjWSP+VLEu/fkIRz8tJJtrdu3w2DdE9G3Zc3+mPPfQPbBIzsC0RsFig10fMLcM4bX/jsDi1iCVazumbyOXMVSRCmJRhvoE7PT+nujvhzqN1zWQVYfjmJYiUt1MHbotzbhfip4Ae/IoVIv1EJZS3TrBmBosD5+MXo+qiVN9tMl2r5TIdI3M6ivasLTDI1ADvQMLz6okZFxcYgfDv47+aIFzrGezH9HFi+cv9UHGxNwkoXgxAp2dbTsQOTwo4huIP4e6zyIRB+WKCXHlZpuf5h9ggaRU58TGFa5NpnGUXHFP5wCXIDEvSPUIru/PQsHIuTnus6st4BXbfz48U16S8ooQ7p2HzCsxkKTbxRV6a7qwGGAYLI8nJMY++V2CpSU8hmHYnYdsmde9UsV9+Xt1LQdg5/SDnMYYps72WzRbVDe7WboHEkFYzBJJgPkXrlPLhFXK+wDqM4cdmjp+CMJiVABkcpD2tH9HHUeb7gh3U6czxv5yWrkj1sbGsqFuKXz2md0d1fqFxDqRKI3krfgail83EhHLJdar+91ZdSNZ69E8fvtS8xB6 X-Microsoft-Antispam-Message-Info: mUB6RP/CXPtzmaa18WwaLiHaHlbNt2fKLVQmLvDi9RfRc/pnAtFyUxr8l1jJWq26LYsg1thjnmFjQViadjGM/w/GkxCq9oiOPcBdITiq/XTPwzZkZ+5KyjPe2lvoe/i3MKdTy3a4qnG5D/Gl4PcwXEHgrKj8562IUXj1bMlhOrCLjWz6i2DDjnOZsMTzzDV1O6LTp/M40mOQClMsIjY2iRRfEDUEiF7Pni7oD9VWQh/Km8p6Dr7O6QUjNEDXtKSUgg3zpAwKsnHE9oGuiSx0KfZ2wVq1jcJg3rbfpnwJDVf5brzIPBVq75wTkpatxxZaNQMOvQB8Wan553r1xZwgKXLN33zfLHm+wxxAoiNE6uId7gn1yC8S/eRpxnidoe4U15IX8B8EFIYCId6yxJZ5kea8Aa2btb/hyerQe9f4ozQ= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2019 11:00:33.9759 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f0bb1de5-341f-4559-ecf2-08d6a159ca92 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB4377 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: <linux-scsi.vger.kernel.org> X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
qedf: Misc fixes for the driver.
|
expand
|
diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index b9877f1..ed149d5 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -2356,7 +2356,7 @@ int qedf_initiate_tmf(struct scsi_cmnd *sc_cmd, u8 tm_flags) struct fc_rport_libfc_priv *rp = rport->dd_data; struct qedf_rport *fcport = (struct qedf_rport *)&rp[1]; struct qedf_ctx *qedf; - struct fc_lport *lport; + struct fc_lport *lport = shost_priv(sc_cmd->device->host); int rc = SUCCESS; int rval; struct qedf_ioreq *io_req = NULL; @@ -2410,8 +2410,6 @@ int qedf_initiate_tmf(struct scsi_cmnd *sc_cmd, u8 tm_flags) goto tmf_err; } - lport = qedf->lport; - if (test_bit(QEDF_RPORT_UPLOADING_CONNECTION, &fcport->flags)) { QEDF_ERR(&qedf->dbg_ctx, "Connection is getting uploaded.\n"); rc = SUCCESS;
- lport was getting used without initialization, initialize it to fix a warning. Signed-off-by: Saurav Kashyap <skashyap@marvell.com> --- drivers/scsi/qedf/qedf_io.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)