Message ID | 20190326073858.26792-21-skashyap@marvell.com (mailing list archive) |
---|---|
State | Accepted |
Headers | show
Return-Path: <linux-scsi-owner@kernel.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3A93B14DE for <patchwork-linux-scsi@patchwork.kernel.org>; Tue, 26 Mar 2019 07:40:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2830029083 for <patchwork-linux-scsi@patchwork.kernel.org>; Tue, 26 Mar 2019 07:40:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1C006290AA; Tue, 26 Mar 2019 07:40:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E16AB290B0 for <patchwork-linux-scsi@patchwork.kernel.org>; Tue, 26 Mar 2019 07:40:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731056AbfCZHkL (ORCPT <rfc822;patchwork-linux-scsi@patchwork.kernel.org>); Tue, 26 Mar 2019 03:40:11 -0400 Received: from mail-eopbgr730070.outbound.protection.outlook.com ([40.107.73.70]:57024 "EHLO NAM05-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726042AbfCZHkL (ORCPT <rfc822;linux-scsi@vger.kernel.org>); Tue, 26 Mar 2019 03:40:11 -0400 Received: from DM5PR07CA0033.namprd07.prod.outlook.com (2603:10b6:3:16::19) by DM6PR07MB5369.namprd07.prod.outlook.com (2603:10b6:5:44::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.18; Tue, 26 Mar 2019 07:40:09 +0000 Received: from DM3NAM05FT029.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::203) by DM5PR07CA0033.outlook.office365.com (2603:10b6:3:16::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.18 via Frontend Transport; Tue, 26 Mar 2019 07:40:09 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT029.mail.protection.outlook.com (10.152.98.140) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1750.4 via Frontend Transport; Tue, 26 Mar 2019 07:40:09 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Tue, 26 Mar 2019 00:39:59 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x2Q7dx1E026915; Tue, 26 Mar 2019 00:39:59 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x2Q7dx5W026914; Tue, 26 Mar 2019 00:39:59 -0700 From: Saurav Kashyap <skashyap@marvell.com> To: <martin.petersen@oracle.com> CC: <QLogic-Storage-Upstream@cavium.com>, <linux-scsi@vger.kernel.org> Subject: [PATCH v2 20/26] qedf: Don't send ABTS for under run scenario. Date: Tue, 26 Mar 2019 00:38:52 -0700 Message-ID: <20190326073858.26792-21-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190326073858.26792-1-skashyap@marvell.com> References: <20190326073858.26792-1-skashyap@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Matching-Connectors: 131980596094788897;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(39860400002)(136003)(376002)(346002)(396003)(2980300002)(1110001)(1109001)(339900001)(199004)(189003)(81156014)(50226002)(53936002)(26005)(86362001)(36756003)(8936002)(5660300002)(1076003)(81166006)(80596001)(8676002)(69596002)(47776003)(87636003)(26826003)(498600001)(305945005)(16586007)(51416003)(54906003)(476003)(76176011)(2906002)(50466002)(85426001)(356004)(68736007)(48376002)(6666004)(105606002)(36906005)(336012)(316002)(42186006)(6862004)(4326008)(11346002)(106466001)(126002)(97736004)(2616005)(2351001)(446003)(486006);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR07MB5369;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fbf027a5-a63a-4994-7a92-08d6b1be45ef X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600127)(711020)(4605104)(2017052603328);SRVR:DM6PR07MB5369; X-MS-TrafficTypeDiagnostic: DM6PR07MB5369: X-Microsoft-Antispam-PRVS: <DM6PR07MB5369DF7329AE9944FE73EB7CD25F0@DM6PR07MB5369.namprd07.prod.outlook.com> X-Forefront-PRVS: 09888BC01D X-Microsoft-Antispam-Message-Info: easL+zTnl7EXPaMmVozOlOgTmD5MCsKVs5A8h8dxA8CVFatCyN8HzMBUVsDaEFY27JFN52kvmKqPypCDn9E7eI2scyrkHOq3YQ7n3tDdMQhexz4FqBni+aQp9Wq0ZzgQZUO83KLd5zgSKUpF/d+HuP5Xv2hU8r9m+pUDO3U3UsEqBjPvUImPmOo5JwZLguaMOY807tmOcgJMVDGLaXYniruR94kv2KMQwm6zyQlukYbQ3d5WY5G2cF8Yg+3sEotZ6lUxbSYKtXZetFpzqL4bUetEmBqHGZLedvr1PWvtnZLnQY0u2pQK5nUiO6USHOG6CtqYo4BwdwxzPm7Jd8ngd1CWfuq+tQrDFjt2fFcTUbKg49Dvw+Vbg1ofcGHYQclb5D2B5VUyilHxJ3vV+BguI44bBYTuHPIipwvYfSkKPoE= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2019 07:40:09.1390 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fbf027a5-a63a-4994-7a92-08d6b1be45ef X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB5369 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: <linux-scsi.vger.kernel.org> X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
qedf: Misc fixes for the driver.
|
expand
|
diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index eeb96c7..889b300 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -1100,7 +1100,7 @@ static void qedf_unmap_sg_list(struct qedf_ctx *qedf, struct qedf_ioreq *io_req) void qedf_scsi_completion(struct qedf_ctx *qedf, struct fcoe_cqe *cqe, struct qedf_ioreq *io_req) { - u16 xid, rval; + u16 xid; struct e4_fcoe_task_context *task_ctx; struct scsi_cmnd *sc_cmd; struct fcoe_cqe_rsp_info *fcp_rsp; @@ -1200,14 +1200,6 @@ void qedf_scsi_completion(struct qedf_ctx *qedf, struct fcoe_cqe *cqe, else sc_cmd->result = (DID_OK << 16) | io_req->cdb_status; - /* Abort the command since we did not get all the data */ - init_completion(&io_req->abts_done); - rval = qedf_initiate_abts(io_req, true); - if (rval) { - QEDF_ERR(&(qedf->dbg_ctx), "Failed to queue ABTS.\n"); - sc_cmd->result = (DID_ERROR << 16) | io_req->cdb_status; - } - /* * Set resid to the whole buffer length so we won't try to resue * any previously data.
- Command is already completed with underrun so no need to send ABTS. Signed-off-by: Saurav Kashyap <skashyap@marvell.com> --- drivers/scsi/qedf/qedf_io.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)