@@ -4653,9 +4653,7 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
return -ENOMEM;
for (i = 0; i < PMCRAID_MAX_CMD; i++) {
- pinstance->cmd_list[i]->ioa_cb =
- dma_pool_alloc(
- pinstance->control_pool,
+ pinstance->cmd_list[i]->ioa_cb = dma_pool_zalloc(pinstance->control_pool,
GFP_KERNEL,
&(pinstance->cmd_list[i]->ioa_cb_bus_addr));
@@ -4663,8 +4661,6 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
pmcraid_release_control_blocks(pinstance, i);
return -ENOMEM;
}
- memset(pinstance->cmd_list[i]->ioa_cb, 0,
- sizeof(struct pmcraid_control_block));
}
return 0;
}
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0 The semantic patch that makes this change is available in scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci. Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com> --- drivers/scsi/pmcraid.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)