| Message ID | 20190830222402.23688-2-hmadhani@marvell.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | qla2xxx: Bug fixes for the driver | expand |
On Fri, 2019-08-30 at 15:23 -0700, Himanshu Madhani wrote: > This patch updates log message which indicates number > of vectors used by driver instead of displaying failure > to get maximum requested vectors. Driver will always > request maximum vectors during initialization. In the > event driver is not able to get maximum requested vectors, > it will adjust the allocated vectors. This is normal and > does not imply failure in driver. > > Signed-off-by: Himanshu Madhani <hmadhani@marvell.com> > --- > drivers/scsi/qla2xxx/qla_isr.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c > index d81b5ecce24b..4c26630c1c3e 100644 > --- a/drivers/scsi/qla2xxx/qla_isr.c > +++ b/drivers/scsi/qla2xxx/qla_isr.c > @@ -3466,10 +3466,8 @@ qla24xx_enable_msix(struct qla_hw_data *ha, struct rsp_que *rsp) > ha->msix_count, ret); > goto msix_out; > } else if (ret < ha->msix_count) { > - ql_log(ql_log_warn, vha, 0x00c6, > - "MSI-X: Failed to enable support " > - "with %d vectors, using %d vectors.\n", > - ha->msix_count, ret); > + ql_log(ql_log_info, vha, 0x00c6, > + "MSI-X: Using %d vectors\n", ret); > ha->msix_count = ret; > /* Recalculate queue values */ > if (ha->mqiobase && (ql2xmqsupport || ql2xnvmeenable)) { Reviewed-by: Ewan D. Milne <emilne@redhat.com>
On 8/30/19 3:23 PM, Himanshu Madhani wrote: > This patch updates log message which indicates number > of vectors used by driver instead of displaying failure > to get maximum requested vectors. Driver will always > request maximum vectors during initialization. In the > event driver is not able to get maximum requested vectors, > it will adjust the allocated vectors. This is normal and > does not imply failure in driver. > > Signed-off-by: Himanshu Madhani <hmadhani@marvell.com> > --- > drivers/scsi/qla2xxx/qla_isr.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c > index d81b5ecce24b..4c26630c1c3e 100644 > --- a/drivers/scsi/qla2xxx/qla_isr.c > +++ b/drivers/scsi/qla2xxx/qla_isr.c > @@ -3466,10 +3466,8 @@ qla24xx_enable_msix(struct qla_hw_data *ha, struct rsp_que *rsp) > ha->msix_count, ret); > goto msix_out; > } else if (ret < ha->msix_count) { > - ql_log(ql_log_warn, vha, 0x00c6, > - "MSI-X: Failed to enable support " > - "with %d vectors, using %d vectors.\n", > - ha->msix_count, ret); > + ql_log(ql_log_info, vha, 0x00c6, > + "MSI-X: Using %d vectors\n", ret); > ha->msix_count = ret; > /* Recalculate queue values */ > if (ha->mqiobase && (ql2xmqsupport || ql2xnvmeenable)) { > Reviewed-by: Lee Duncan <lduncan@suse.com>
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index d81b5ecce24b..4c26630c1c3e 100644 --- a/drivers/scsi/qla2xxx/qla_isr.c +++ b/drivers/scsi/qla2xxx/qla_isr.c @@ -3466,10 +3466,8 @@ qla24xx_enable_msix(struct qla_hw_data *ha, struct rsp_que *rsp) ha->msix_count, ret); goto msix_out; } else if (ret < ha->msix_count) { - ql_log(ql_log_warn, vha, 0x00c6, - "MSI-X: Failed to enable support " - "with %d vectors, using %d vectors.\n", - ha->msix_count, ret); + ql_log(ql_log_info, vha, 0x00c6, + "MSI-X: Using %d vectors\n", ret); ha->msix_count = ret; /* Recalculate queue values */ if (ha->mqiobase && (ql2xmqsupport || ql2xnvmeenable)) {
This patch updates log message which indicates number of vectors used by driver instead of displaying failure to get maximum requested vectors. Driver will always request maximum vectors during initialization. In the event driver is not able to get maximum requested vectors, it will adjust the allocated vectors. This is normal and does not imply failure in driver. Signed-off-by: Himanshu Madhani <hmadhani@marvell.com> --- drivers/scsi/qla2xxx/qla_isr.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)