@@ -2471,6 +2471,8 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
BUG();
}
+ ufshcd_init_lrb(hba, lrbp, tag);
+
WARN_ON_ONCE(!ufshcd_is_scsi(cmd->request));
if (!down_read_trylock(&hba->clk_scaling_lock))
@@ -2713,6 +2715,8 @@ static int ufshcd_exec_dev_cmd(struct ufs_hba *hba,
hba->dev_cmd.complete = &wait;
+ ufshcd_init_lrb(hba, lrbp, tag);
+
ufshcd_add_query_upiu_trace(hba, tag, "query_send");
/* Make sure descriptors are ready before ringing the doorbell */
wmb();
@@ -5900,6 +5904,7 @@ static int ufshcd_issue_devman_upiu_cmd(struct ufs_hba *hba,
init_completion(&wait);
lrbp = ufshcd_req_to_lrb(req);
+ ufshcd_init_lrb(hba, lrbp, tag);
lrbp->sense_bufflen = 0;
lrbp->sense_buffer = NULL;
lrbp->task_tag = tag;
The paramter cmd of ufshcd_init_cmd_priv() didn't take correct tag value, this results in all pointers of lrbp points to first the lrbp. As this is just observed, this patch is for referecen so others who want to use latest UFS driver can avoid this issue. Fixes: 34656dda81ac ("scsi: ufs: Let the SCSI core allocate per-command UFS data") --- drivers/scsi/ufs/ufshcd.c | 5 +++++ 1 file changed, 5 insertions(+)