| Message ID | 20200327102730.22351-3-njavali@marvell.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | qla2xxx: Updates for the driver | expand |
On 3/27/2020 5:27 AM, Nilesh Javali wrote: > From: Arun Easi <aeasi@marvell.com> > > In NPIV environment, a NPIV host may use a queue pair created > by base host or other NPIVs, so the check for a queue pair > created by this NPIV is not correct, and can cause an abort > to fail, which in turn means the NVME command not returned. > This leads to hang in nvme_fc layer in nvme_fc_delete_association() > which waits for all I/Os to be returned, which is seen as hang > in the application. > > Signed-off-by: Arun Easi <aeasi@marvell.com> > Signed-off-by: Nilesh Javali <njavali@marvell.com> > --- > drivers/scsi/qla2xxx/qla_mbx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c > index 9fd83d1bffe0..7cefe35d61d1 100644 > --- a/drivers/scsi/qla2xxx/qla_mbx.c > +++ b/drivers/scsi/qla2xxx/qla_mbx.c > @@ -3153,7 +3153,7 @@ qla24xx_abort_command(srb_t *sp) > ql_dbg(ql_dbg_mbx + ql_dbg_verbose, vha, 0x108c, > "Entered %s.\n", __func__); > > - if (vha->flags.qpairs_available && sp->qpair) > + if (sp->qpair) > req = sp->qpair->req; > else > return QLA_FUNCTION_FAILED; > Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 9fd83d1bffe0..7cefe35d61d1 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -3153,7 +3153,7 @@ qla24xx_abort_command(srb_t *sp) ql_dbg(ql_dbg_mbx + ql_dbg_verbose, vha, 0x108c, "Entered %s.\n", __func__); - if (vha->flags.qpairs_available && sp->qpair) + if (sp->qpair) req = sp->qpair->req; else return QLA_FUNCTION_FAILED;