diff mbox series

scsi: mvsas: make mvst_host_attrs static

Message ID 20200415085044.7460-1-yanaijie@huawei.com (mailing list archive)
State Mainlined
Commit a677ab35a9670f3dd1f16398d1d94bb22efed38f
Headers show
Series scsi: mvsas: make mvst_host_attrs static | expand

Commit Message

Jason Yan April 15, 2020, 8:50 a.m. UTC
Fix the following sparse warning:

drivers/scsi/mvsas/mv_init.c:28:25: warning: symbol 'mvst_host_attrs'
was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/scsi/mvsas/mv_init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Martin K. Petersen April 17, 2020, 9:32 p.m. UTC | #1
Jason,

> Fix the following sparse warning:
>
> drivers/scsi/mvsas/mv_init.c:28:25: warning: symbol 'mvst_host_attrs'
> was not declared. Should it be static?

Applied to 5.8/scsi-queue, thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
index 7af9173c4925..f82728b2c32f 100644
--- a/drivers/scsi/mvsas/mv_init.c
+++ b/drivers/scsi/mvsas/mv_init.c
@@ -25,7 +25,7 @@  static const struct mvs_chip_info mvs_chips[] = {
 	[chip_1320] =	{ 2, 4, 0x800, 17, 64, 8,  9, &mvs_94xx_dispatch, },
 };
 
-struct device_attribute *mvst_host_attrs[];
+static struct device_attribute *mvst_host_attrs[];
 
 #define SOC_SAS_NUM 2
 
@@ -785,7 +785,7 @@  static void __exit mvs_exit(void)
 	sas_release_transport(mvs_stt);
 }
 
-struct device_attribute *mvst_host_attrs[] = {
+static struct device_attribute *mvst_host_attrs[] = {
 	&dev_attr_driver_version,
 	&dev_attr_interrupt_coalescing,
 	NULL,