| Message ID | 20200415090513.5133-3-johannes.thumshirn@wdc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Introduce Zone Append for writing to zoned block devices | expand |
On Wed, Apr 15, 2020 at 06:05:04PM +0900, Johannes Thumshirn wrote: > blk_queue_zone_is_seq() and blk_queue_zone_no() have not been called with > CONFIG_BLK_DEV_ZONED disabled until now. > > The introduction of REQ_OP_ZONE_APPEND will change this, so we need to > provide noop fallbacks for the !CONFIG_BLK_DEV_ZONED case. > > Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> > Reviewed-by: Christoph Hellwig <hch@lst.de> > --- > include/linux/blkdev.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 32868fbedc9e..e47888a7d80b 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -729,6 +729,16 @@ static inline unsigned int blk_queue_nr_zones(struct request_queue *q) > { > return 0; > } > +static inline bool blk_queue_zone_is_seq(struct request_queue *q, > + sector_t sector) > +{ > + return false; > +} > +static inline unsigned int blk_queue_zone_no(struct request_queue *q, > + sector_t sector) > +{ > + return 0; > +} nit: blk_queue_zone_no is defined before blk_queue_zone_is_seq in the CONFIG_BLK_DEV_ZONED section. Besides that, Reviewed-by: Daniel Wagner <dwagner@suse.de>
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 32868fbedc9e..e47888a7d80b 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -729,6 +729,16 @@ static inline unsigned int blk_queue_nr_zones(struct request_queue *q) { return 0; } +static inline bool blk_queue_zone_is_seq(struct request_queue *q, + sector_t sector) +{ + return false; +} +static inline unsigned int blk_queue_zone_no(struct request_queue *q, + sector_t sector) +{ + return 0; +} #endif /* CONFIG_BLK_DEV_ZONED */ static inline bool rq_is_sync(struct request *rq)