| Message ID | 20200418184111.13401-10-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | fix -Wempty-body build warnings | expand |
--- linux-next-20200417.orig/drivers/target/target_core_pscsi.c +++ linux-next-20200417/drivers/target/target_core_pscsi.c @@ -18,6 +18,7 @@ #include <linux/slab.h> #include <linux/spinlock.h> #include <linux/genhd.h> +#include <linux/kernel.h> #include <linux/cdrom.h> #include <linux/ratelimit.h> #include <linux/module.h> @@ -621,7 +622,7 @@ static void pscsi_complete_cmd(struct se buf = transport_kmap_data_sg(cmd); if (!buf) - ; /* XXX: TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE */ + do_empty(); /* XXX: TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE */ if (cdb[0] == MODE_SENSE_10) { if (!(buf[3] & 0x80))
Fix gcc empty-body warning when -Wextra is used: ../drivers/target/target_core_pscsi.c:624:5: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: "Martin K. Petersen" <martin.petersen@oracle.com> Cc: linux-scsi@vger.kernel.org Cc: target-devel@vger.kernel.org --- drivers/target/target_core_pscsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)