| Message ID | 20200421034008.27865-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | b7a9d0c6603d233280fbfef9d58154664e4aa478 |
| Headers | show |
| Series | scsi: fcoe: remove unneeded semicolon in fcoe.c | expand |
On 4/21/20 5:40 AM, Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/scsi/fcoe/fcoe.c:1918:3-4: Unneeded semicolon > drivers/scsi/fcoe/fcoe.c:1930:3-4: Unneeded semicolon > > Signed-off-by: Jason Yan <yanaijie@huawei.com> > --- > drivers/scsi/fcoe/fcoe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c > index 25dae9f0b205..cb41d166e0c0 100644 > --- a/drivers/scsi/fcoe/fcoe.c > +++ b/drivers/scsi/fcoe/fcoe.c > @@ -1915,7 +1915,7 @@ static int fcoe_device_notification(struct notifier_block *notifier, > case FCOE_CTLR_ENABLED: > case FCOE_CTLR_UNUSED: > fcoe_ctlr_link_up(ctlr); > - }; > + } > } else if (fcoe_ctlr_link_down(ctlr)) { > switch (cdev->enabled) { > case FCOE_CTLR_DISABLED: > @@ -1927,7 +1927,7 @@ static int fcoe_device_notification(struct notifier_block *notifier, > stats->LinkFailureCount++; > put_cpu(); > fcoe_clean_pending_queue(lport); > - }; > + } > } > out: > return rc; > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
Jason, > Fix the following coccicheck warning: > > drivers/scsi/fcoe/fcoe.c:1918:3-4: Unneeded semicolon > drivers/scsi/fcoe/fcoe.c:1930:3-4: Unneeded semicolon Applied to 5.8/scsi-queue, thanks!
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c index 25dae9f0b205..cb41d166e0c0 100644 --- a/drivers/scsi/fcoe/fcoe.c +++ b/drivers/scsi/fcoe/fcoe.c @@ -1915,7 +1915,7 @@ static int fcoe_device_notification(struct notifier_block *notifier, case FCOE_CTLR_ENABLED: case FCOE_CTLR_UNUSED: fcoe_ctlr_link_up(ctlr); - }; + } } else if (fcoe_ctlr_link_down(ctlr)) { switch (cdev->enabled) { case FCOE_CTLR_DISABLED: @@ -1927,7 +1927,7 @@ static int fcoe_device_notification(struct notifier_block *notifier, stats->LinkFailureCount++; put_cpu(); fcoe_clean_pending_queue(lport); - }; + } } out: return rc;
Fix the following coccicheck warning: drivers/scsi/fcoe/fcoe.c:1918:3-4: Unneeded semicolon drivers/scsi/fcoe/fcoe.c:1930:3-4: Unneeded semicolon Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/scsi/fcoe/fcoe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)