diff mbox series

USB: uas: Add US_FL_NO_REPORT_OPCODES for LaCie 2Big Quadra USB3 external disk

Message ID 20200507131708.250871-1-hdegoede@redhat.com (mailing list archive)
State Not Applicable
Headers show
Series USB: uas: Add US_FL_NO_REPORT_OPCODES for LaCie 2Big Quadra USB3 external disk | expand

Commit Message

Hans de Goede May 7, 2020, 1:17 p.m. UTC
The LaCie 2Big Quadra USB3 external disk does not like the REPORT_OPCODES
request, causing probing it to take several minutes (and several resets).

Add US_FL_NO_REPORT_OPCODES flag for this model to fix the probing delay.

Reported-by: Julian Groß <julian.g@posteo.de>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/usb/storage/unusual_uas.h | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Greg KH May 7, 2020, 1:49 p.m. UTC | #1
On Thu, May 07, 2020 at 03:17:08PM +0200, Hans de Goede wrote:
> The LaCie 2Big Quadra USB3 external disk does not like the REPORT_OPCODES
> request, causing probing it to take several minutes (and several resets).
> 
> Add US_FL_NO_REPORT_OPCODES flag for this model to fix the probing delay.
> 
> Reported-by: Julian Groß <julian.g@posteo.de>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/usb/storage/unusual_uas.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> index 1b23741036ee..37157ed9a881 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -28,6 +28,13 @@
>   * and don't forget to CC: the USB development list <linux-usb@vger.kernel.org>
>   */
>  
> +/* Reported-by: Julian Groß <julian.g@posteo.de> */
> +UNUSUAL_DEV(0x059f, 0x105f, 0x0000, 0x9999,
> +		"LaCie",
> +		"2Big Quadra USB3",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> +		US_FL_NO_REPORT_OPCODES),
> +
>  /*
>   * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
>   * commands in UAS mode.  Observed with the 1.28 firmware; are there others?
> -- 
> 2.26.0
> 

Already in my tree and in linux-next and will go to Linus this week,
sorry.

greg k-h
Hans de Goede May 7, 2020, 1:56 p.m. UTC | #2
Hi,

On 5/7/20 3:49 PM, Greg Kroah-Hartman wrote:
> On Thu, May 07, 2020 at 03:17:08PM +0200, Hans de Goede wrote:
>> The LaCie 2Big Quadra USB3 external disk does not like the REPORT_OPCODES
>> request, causing probing it to take several minutes (and several resets).
>>
>> Add US_FL_NO_REPORT_OPCODES flag for this model to fix the probing delay.
>>
>> Reported-by: Julian Groß <julian.g@posteo.de>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>   drivers/usb/storage/unusual_uas.h | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
>> index 1b23741036ee..37157ed9a881 100644
>> --- a/drivers/usb/storage/unusual_uas.h
>> +++ b/drivers/usb/storage/unusual_uas.h
>> @@ -28,6 +28,13 @@
>>    * and don't forget to CC: the USB development list <linux-usb@vger.kernel.org>
>>    */
>>   
>> +/* Reported-by: Julian Groß <julian.g@posteo.de> */
>> +UNUSUAL_DEV(0x059f, 0x105f, 0x0000, 0x9999,
>> +		"LaCie",
>> +		"2Big Quadra USB3",
>> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>> +		US_FL_NO_REPORT_OPCODES),
>> +
>>   /*
>>    * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
>>    * commands in UAS mode.  Observed with the 1.28 firmware; are there others?
>> -- 
>> 2.26.0
>>
> 
> Already in my tree and in linux-next and will go to Linus this week,
> sorry.

No problem, I'm happy to see small but important fixes like this getting
picked up :)

Regards,

Hans
diff mbox series

Patch

diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
index 1b23741036ee..37157ed9a881 100644
--- a/drivers/usb/storage/unusual_uas.h
+++ b/drivers/usb/storage/unusual_uas.h
@@ -28,6 +28,13 @@ 
  * and don't forget to CC: the USB development list <linux-usb@vger.kernel.org>
  */
 
+/* Reported-by: Julian Groß <julian.g@posteo.de> */
+UNUSUAL_DEV(0x059f, 0x105f, 0x0000, 0x9999,
+		"LaCie",
+		"2Big Quadra USB3",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+		US_FL_NO_REPORT_OPCODES),
+
 /*
  * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
  * commands in UAS mode.  Observed with the 1.28 firmware; are there others?