| Message ID | 20200530072933.576851-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | af7b415a1ebf3b7f5ac100c14f0c182da2d41a11 |
| Headers | show |
| Series | scsi: powertec: Fix different dev_id between 'request_irq()' and 'free_irq()' | expand |
On Sat, 30 May 2020 09:29:33 +0200, Christophe JAILLET wrote: > The dev_id used in 'request_irq()' and 'free_irq()' should match. > So use 'host' in both cases. Applied to 5.8/scsi-queue, thanks! [1/1] scsi: powertec: Fix different dev_id between request_irq() and free_irq() https://git.kernel.org/mkp/scsi/c/af7b415a1ebf
Le 10/06/2020 à 04:41, Martin K. Petersen a écrit : > On Sat, 30 May 2020 09:29:33 +0200, Christophe JAILLET wrote: > >> The dev_id used in 'request_irq()' and 'free_irq()' should match. >> So use 'host' in both cases. > Applied to 5.8/scsi-queue, thanks! > > [1/1] scsi: powertec: Fix different dev_id between request_irq() and free_irq() > https://git.kernel.org/mkp/scsi/c/af7b415a1ebf > Please revert, the patch is bogus, as spotted by Russell King - ARM Linux admin <linux@armlinux.org.uk>. See [1]. I'll try to send the correct fix by this week-end. CJ [1]: https://marc.info/?l=linux-scsi&m=159083184215730&w=4
Christophe, >> [1/1] scsi: powertec: Fix different dev_id between request_irq() and free_irq() >> https://git.kernel.org/mkp/scsi/c/af7b415a1ebf >> > Please revert, Dropped (x2).
diff --git a/drivers/scsi/arm/powertec.c b/drivers/scsi/arm/powertec.c index 772a13e5fd91..723b80084498 100644 --- a/drivers/scsi/arm/powertec.c +++ b/drivers/scsi/arm/powertec.c @@ -354,7 +354,7 @@ static int powertecscsi_probe(struct expansion_card *ec, goto out_free; ret = request_irq(ec->irq, powertecscsi_intr, - 0, "powertec", info); + 0, "powertec", host); if (ret) { printk("scsi%d: IRQ%d not free: %d\n", host->host_no, ec->irq, ret);
The dev_id used in 'request_irq()' and 'free_irq()' should match. So use 'host' in both cases. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/scsi/arm/powertec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)