| Message ID | 20200708120221.3386672-14-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix a bunch more SCSI related W=1 warnings | expand |
On 08/07/2020 14:04, Lee Jones wrote: > Description should state 'remote' port, not 'local'. > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/libfc/fc_rport.c:1452: warning: Function parameter or member 'rdata_arg' not described in 'fc_rport_logo_resp' > drivers/scsi/libfc/fc_rport.c:1452: warning: Excess function parameter 'rport_arg' description in 'fc_rport_logo_resp' > > Cc: Hannes Reinecke <hare@suse.de> > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/scsi/libfc/fc_rport.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c > index ea99e69d4d89c..18663a82865f9 100644 > --- a/drivers/scsi/libfc/fc_rport.c > +++ b/drivers/scsi/libfc/fc_rport.c > @@ -1445,7 +1445,7 @@ static void fc_rport_recv_rtv_req(struct fc_rport_priv *rdata, > * fc_rport_logo_resp() - Handler for logout (LOGO) responses > * @sp: The sequence the LOGO was on > * @fp: The LOGO response frame > - * @rport_arg: The local port > + * @rdata_arg: The remote port > */ > static void fc_rport_logo_resp(struct fc_seq *sp, struct fc_frame *fp, > void *rdata_arg) > Please fold this into patch 11
On Wed, 08 Jul 2020, Johannes Thumshirn wrote: > On 08/07/2020 14:04, Lee Jones wrote: > > Description should state 'remote' port, not 'local'. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/scsi/libfc/fc_rport.c:1452: warning: Function parameter or member 'rdata_arg' not described in 'fc_rport_logo_resp' > > drivers/scsi/libfc/fc_rport.c:1452: warning: Excess function parameter 'rport_arg' description in 'fc_rport_logo_resp' > > > > Cc: Hannes Reinecke <hare@suse.de> > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > drivers/scsi/libfc/fc_rport.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c > > index ea99e69d4d89c..18663a82865f9 100644 > > --- a/drivers/scsi/libfc/fc_rport.c > > +++ b/drivers/scsi/libfc/fc_rport.c > > @@ -1445,7 +1445,7 @@ static void fc_rport_recv_rtv_req(struct fc_rport_priv *rdata, > > * fc_rport_logo_resp() - Handler for logout (LOGO) responses > > * @sp: The sequence the LOGO was on > > * @fp: The LOGO response frame > > - * @rport_arg: The local port > > + * @rdata_arg: The remote port > > */ > > static void fc_rport_logo_resp(struct fc_seq *sp, struct fc_frame *fp, > > void *rdata_arg) > > > > > Please fold this into patch 11 Yes, will do.
On Wed, 08 Jul 2020, Lee Jones wrote: > On Wed, 08 Jul 2020, Johannes Thumshirn wrote: > > > On 08/07/2020 14:04, Lee Jones wrote: > > > Description should state 'remote' port, not 'local'. > > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/scsi/libfc/fc_rport.c:1452: warning: Function parameter or member 'rdata_arg' not described in 'fc_rport_logo_resp' > > > drivers/scsi/libfc/fc_rport.c:1452: warning: Excess function parameter 'rport_arg' description in 'fc_rport_logo_resp' > > > > > > Cc: Hannes Reinecke <hare@suse.de> > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > --- > > > drivers/scsi/libfc/fc_rport.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c > > > index ea99e69d4d89c..18663a82865f9 100644 > > > --- a/drivers/scsi/libfc/fc_rport.c > > > +++ b/drivers/scsi/libfc/fc_rport.c > > > @@ -1445,7 +1445,7 @@ static void fc_rport_recv_rtv_req(struct fc_rport_priv *rdata, > > > * fc_rport_logo_resp() - Handler for logout (LOGO) responses > > > * @sp: The sequence the LOGO was on > > > * @fp: The LOGO response frame > > > - * @rport_arg: The local port > > > + * @rdata_arg: The remote port > > > */ > > > static void fc_rport_logo_resp(struct fc_seq *sp, struct fc_frame *fp, > > > void *rdata_arg) > > > > > > > > > Please fold this into patch 11 > > Yes, will do. Actually, Martin, is this something you can do when applying, or would you like me to do it and submit the entire set again?
diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index ea99e69d4d89c..18663a82865f9 100644 --- a/drivers/scsi/libfc/fc_rport.c +++ b/drivers/scsi/libfc/fc_rport.c @@ -1445,7 +1445,7 @@ static void fc_rport_recv_rtv_req(struct fc_rport_priv *rdata, * fc_rport_logo_resp() - Handler for logout (LOGO) responses * @sp: The sequence the LOGO was on * @fp: The LOGO response frame - * @rport_arg: The local port + * @rdata_arg: The remote port */ static void fc_rport_logo_resp(struct fc_seq *sp, struct fc_frame *fp, void *rdata_arg)
Description should state 'remote' port, not 'local'. Fixes the following W=1 kernel build warning(s): drivers/scsi/libfc/fc_rport.c:1452: warning: Function parameter or member 'rdata_arg' not described in 'fc_rport_logo_resp' drivers/scsi/libfc/fc_rport.c:1452: warning: Excess function parameter 'rport_arg' description in 'fc_rport_logo_resp' Cc: Hannes Reinecke <hare@suse.de> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/scsi/libfc/fc_rport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)