| Message ID | 20200718123224.1202-1-wanghai38@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 003015b890e1629a703af95823d16346798f835c |
| Headers | show |
| Series | [-next] scsi: dpt_i2o: remove some not needed memset | expand |
On Sat, 18 Jul 2020 20:32:24 +0800, Wang Hai wrote: > Fixes coccicheck warning: > > ./drivers/scsi/dpt_i2o.c:3070:11-29: WARNING: > dma_alloc_coherent use in sys_tbl already zeroes out memory, so memset is not needed > ./drivers/scsi/dpt_i2o.c:2780:10-28: WARNING: > dma_alloc_coherent use in status already zeroes out memory, so memset is not needed > ./drivers/scsi/dpt_i2o.c:2834:20-38: WARNING: > dma_alloc_coherent use in pHba -> reply_pool already zeroes out memory, so memset is not needed > ./drivers/scsi/dpt_i2o.c:1328:10-28: WARNING: > dma_alloc_coherent use in status already zeroes out memory, so memset is not needed Applied to 5.9/scsi-queue, thanks! [1/1] scsi: dpt_i2o: Remove superfluous memset() https://git.kernel.org/mkp/scsi/c/003015b890e1
diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c index 0497ef6a9453..f654ad8a3d69 100644 --- a/drivers/scsi/dpt_i2o.c +++ b/drivers/scsi/dpt_i2o.c @@ -1331,7 +1331,6 @@ static s32 adpt_i2o_reset_hba(adpt_hba* pHba) printk(KERN_ERR"IOP reset failed - no free memory.\n"); return -ENOMEM; } - memset(status,0,4); msg[0]=EIGHT_WORD_MSG_SIZE|SGL_OFFSET_0; msg[1]=I2O_CMD_ADAPTER_RESET<<24|HOST_TID<<12|ADAPTER_TID; @@ -2784,7 +2783,6 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba* pHba) pHba->name); return -ENOMEM; } - memset(status, 0, 4); writel(EIGHT_WORD_MSG_SIZE| SGL_OFFSET_6, &msg[0]); writel(I2O_CMD_OUTBOUND_INIT<<24 | HOST_TID<<12 | ADAPTER_TID, &msg[1]); @@ -2838,7 +2836,6 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba* pHba) printk(KERN_ERR "%s: Could not allocate reply pool\n", pHba->name); return -ENOMEM; } - memset(pHba->reply_pool, 0 , pHba->reply_fifo_size * REPLY_FRAME_SIZE * 4); for(i = 0; i < pHba->reply_fifo_size; i++) { writel(pHba->reply_pool_pa + (i * REPLY_FRAME_SIZE * 4), @@ -3073,7 +3070,6 @@ static int adpt_i2o_build_sys_table(void) printk(KERN_WARNING "SysTab Set failed. Out of memory.\n"); return -ENOMEM; } - memset(sys_tbl, 0, sys_tbl_len); sys_tbl->num_entries = hba_count; sys_tbl->version = I2OVERSION;
Fixes coccicheck warning: ./drivers/scsi/dpt_i2o.c:3070:11-29: WARNING: dma_alloc_coherent use in sys_tbl already zeroes out memory, so memset is not needed ./drivers/scsi/dpt_i2o.c:2780:10-28: WARNING: dma_alloc_coherent use in status already zeroes out memory, so memset is not needed ./drivers/scsi/dpt_i2o.c:2834:20-38: WARNING: dma_alloc_coherent use in pHba -> reply_pool already zeroes out memory, so memset is not needed ./drivers/scsi/dpt_i2o.c:1328:10-28: WARNING: dma_alloc_coherent use in status already zeroes out memory, so memset is not needed Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wang Hai <wanghai38@huawei.com> --- drivers/scsi/dpt_i2o.c | 4 ---- 1 file changed, 4 deletions(-)