diff mbox series

scsi: qedi: Remove redundant null check

Message ID 20200827092606.32148-1-vulab@iscas.ac.cn (mailing list archive)
State Accepted
Headers show
Series scsi: qedi: Remove redundant null check | expand

Commit Message

Wentao Liang Aug. 27, 2020, 9:26 a.m. UTC 
Because kfree_skb already checked NULL skb parameter,
so the additional check is unnecessary, just remove it.

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
 drivers/scsi/qedi/qedi_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Martin K. Petersen Sept. 9, 2020, 2:09 a.m. UTC | #1 
On Thu, 27 Aug 2020 09:26:06 +0000, Xu Wang wrote:

> Because kfree_skb already checked NULL skb parameter,
> so the additional check is unnecessary, just remove it.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: qedi: Remove redundant NULL check
      https://git.kernel.org/mkp/scsi/c/9535f2152ace
diff mbox series

Patch

diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 6f038ae5efca..e42437ec23a8 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -789,8 +789,7 @@  static void qedi_ll2_free_skbs(struct qedi_ctx *qedi)
 	spin_lock_bh(&qedi->ll2_lock);
 	list_for_each_entry_safe(work, work_tmp, &qedi->ll2_skb_list, list) {
 		list_del(&work->list);
-		if (work->skb)
-			kfree_skb(work->skb);
+		kfree_skb(work->skb);
 		kfree(work);
 	}
 	spin_unlock_bh(&qedi->ll2_lock);