| Message ID | 20201026190646.8727-2-ddiss@suse.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | scsi: target: COMPARE AND WRITE miscompare sense | expand |
On 2020-10-26 3:06 p.m., David Disseldorp wrote: > sg_copy_buffer() returns a size_t with the number of bytes copied. > Return 0 instead of false if the copy is skipped. > > Signed-off-by: David Disseldorp <ddiss@suse.de> > --- > lib/scatterlist.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/scatterlist.c b/lib/scatterlist.c > index 0a482ef988e5..a59778946404 100644 > --- a/lib/scatterlist.c > +++ b/lib/scatterlist.c > @@ -933,7 +933,7 @@ size_t sg_copy_buffer(struct scatterlist *sgl, unsigned int nents, void *buf, > sg_miter_start(&miter, sgl, nents, sg_flags); > > if (!sg_miter_skip(&miter, skip)) > - return false; > + return 0; > > while ((offset < buflen) && sg_miter_next(&miter)) { > unsigned int len; > This one probably should be sent by itself as a fix to: linux-block@vger.kernel.org and cc-ed to: axboe@kernel.dk on the assumption that Jens Axboe is the maintainer of lib/scatterlist.c . He put a fix of mine in sgl_alloc_order() into the kernel recently. Otherwise: Reviewed-by: Douglas Gilbert <dgilbert@interlog.com>
On Mon, 26 Oct 2020 16:50:53 -0400, Douglas Gilbert wrote: > On 2020-10-26 3:06 p.m., David Disseldorp wrote: > > sg_copy_buffer() returns a size_t with the number of bytes copied. > > Return 0 instead of false if the copy is skipped. > > > > Signed-off-by: David Disseldorp <ddiss@suse.de> > > --- > > lib/scatterlist.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/scatterlist.c b/lib/scatterlist.c > > index 0a482ef988e5..a59778946404 100644 > > --- a/lib/scatterlist.c > > +++ b/lib/scatterlist.c > > @@ -933,7 +933,7 @@ size_t sg_copy_buffer(struct scatterlist *sgl, unsigned int nents, void *buf, > > sg_miter_start(&miter, sgl, nents, sg_flags); > > > > if (!sg_miter_skip(&miter, skip)) > > - return false; > > + return 0; > > > > while ((offset < buflen) && sg_miter_next(&miter)) { > > unsigned int len; > > > > This one probably should be sent by itself as a fix to: > linux-block@vger.kernel.org > > and cc-ed to: > axboe@kernel.dk > > on the assumption that Jens Axboe is the maintainer of lib/scatterlist.c . > He put a fix of mine in sgl_alloc_order() into the kernel recently. > > Otherwise: > Reviewed-by: Douglas Gilbert <dgilbert@interlog.com> Sent. Thanks Douglas!
diff --git a/lib/scatterlist.c b/lib/scatterlist.c index 0a482ef988e5..a59778946404 100644 --- a/lib/scatterlist.c +++ b/lib/scatterlist.c @@ -933,7 +933,7 @@ size_t sg_copy_buffer(struct scatterlist *sgl, unsigned int nents, void *buf, sg_miter_start(&miter, sgl, nents, sg_flags); if (!sg_miter_skip(&miter, skip)) - return false; + return 0; while ((offset < buflen) && sg_miter_next(&miter)) { unsigned int len;
sg_copy_buffer() returns a size_t with the number of bytes copied. Return 0 instead of false if the copy is skipped. Signed-off-by: David Disseldorp <ddiss@suse.de> --- lib/scatterlist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)