From patchwork Mon Nov 2 14:23:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873995 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6E4ED14B2 for ; Mon, 2 Nov 2020 14:25:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43DCF2072C for ; Mon, 2 Nov 2020 14:25:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="j7ZsLrUu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726239AbgKBOYQ (ORCPT ); Mon, 2 Nov 2020 09:24:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726236AbgKBOYP (ORCPT ); Mon, 2 Nov 2020 09:24:15 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5375DC061A04 for ; Mon, 2 Nov 2020 06:24:15 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id x7so14847304wrl.3 for ; Mon, 02 Nov 2020 06:24:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ctr9VhfYZ+AJvPi8dDIyaqu3jXLLFUsXnVaAd6HF3ME=; b=j7ZsLrUuKjibSf84UEEvHvGstvtYaq3go94c4JsyMA7krTUz0IyHA3KrCfOZYtldrx QC8ppoamXbxKpbvQ3YLtIK2uzTHHI3bw4gylhO3tHuGGKKMz03KS8/BPwFnvkr00lycV QEWdJ8ACc4HlYOQJVV5wn9AmdM1SD066tRzEOLTC+YQdPiHV71YMV5dEOfOvxxfB/fHc 1gblOPAurhahu4cIukOVimQz6RrcxhmZmrjwpDJwZiJNWKeW6APK+zvIuDvqmMdCRfv2 VvDL+2QRxN766ax2JbTBIesxWhXf3ZYGkm6CIBnSlx2vooYhd1F7jKX13Lo64RAzf+ax rotQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ctr9VhfYZ+AJvPi8dDIyaqu3jXLLFUsXnVaAd6HF3ME=; b=AXEPUNtjKTOvMPF5BqJxMV2Gzr7cOtVOGS6cOfAPngJjUett140b4gGoOqpFUZjMKy kksBaHuPHXKCGHxMQAfCw4+K2SEtIu7N6j5ONRDYlymCXlnG54HnhSUiphQlHEyVUF9p zhxVvuyL4Ql0St4G+lBrwg+01Xa6DTTmlrdW6eHlhexewfGjK5nIRt7grfNlOtcEopdn v2nkhDLEy6Mlv1I9+S5KCXhNeC8jUETEA8uM/paGxiST2lzWlWHiM5Ep2r+ypzLf6ew4 wPE/j+3+J8ywhuR2udrdN8lLW3NXWMJfB+sEAvM7A1VR9D1t1KslS77wQILo7+GkeTsd ylbQ== X-Gm-Message-State: AOAM5334PzT6rOZULWePLeJfGiBbbz5iYFPjCVTrDWaXDK7CplDu6LeW FTx912jFMSaROF/vF8Bkb2aEJg== X-Google-Smtp-Source: ABdhPJw+3QrE/nqtCDYVidZGKvxqC++goqqqygI261m8Ft1/TniRpbgavFjRAZOkUwVZPwzKvxzMlQ== X-Received: by 2002:a5d:50cf:: with SMTP id f15mr20866404wrt.324.1604327054049; Mon, 02 Nov 2020 06:24:14 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f7sm23542501wrx.64.2020.11.02.06.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 06:24:13 -0800 (PST) From: Lee Jones To: martin.petersen@oracle.com, jejb@linux.ibm.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Bradley Grove Subject: [RESEND 08/19] scsi: esas2r: esas2r_disc: Place brackets around a potentially empty if() Date: Mon, 2 Nov 2020 14:23:48 +0000 Message-Id: <20201102142359.561122-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102142359.561122-1-lee.jones@linaro.org> References: <20201102142359.561122-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/esas2r/esas2r_disc.c: In function ‘esas2r_disc_get_phys_addr’: drivers/scsi/esas2r/esas2r_disc.c:1035:17: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] Cc: Bradley Grove Signed-off-by: Lee Jones --- drivers/scsi/esas2r/esas2r_disc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/esas2r/esas2r_disc.c b/drivers/scsi/esas2r/esas2r_disc.c index 1c079f4300a56..ba42536d1e87a 100644 --- a/drivers/scsi/esas2r/esas2r_disc.c +++ b/drivers/scsi/esas2r/esas2r_disc.c @@ -1031,8 +1031,9 @@ static u32 esas2r_disc_get_phys_addr(struct esas2r_sg_context *sgc, u64 *addr) { struct esas2r_adapter *a = sgc->adapter; - if (sgc->length > ESAS2R_DISC_BUF_LEN) + if (sgc->length > ESAS2R_DISC_BUF_LEN) { esas2r_bugon(); + } *addr = a->uncached_phys + (u64)((u8 *)a->disc_buffer - a->uncached);