| Message ID | 20201208220505.24488-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | SCSI: cxgb4i: fix TLS dependency | expand |
Randy, > SCSI_CXGB4_ISCSI selects CHELSIO_T4. The latter depends on > TLS || TLS=n, so since 'select' does not check dependencies of > the selected symbol, SCSI_CXGB4_ISCSI should also depend on > TLS || TLS=n. > > This prevents the following kconfig warning and restricts > SCSI_CXGB4_ISCSI to 'm' whenever TLS=m. Applied to 5.11/scsi-staging, thanks!
--- linux-next-20201208.orig/drivers/scsi/cxgbi/cxgb4i/Kconfig +++ linux-next-20201208/drivers/scsi/cxgbi/cxgb4i/Kconfig @@ -4,6 +4,7 @@ config SCSI_CXGB4_ISCSI depends on PCI && INET && (IPV6 || IPV6=n) depends on THERMAL || !THERMAL depends on ETHERNET + depends on TLS || TLS=n select NET_VENDOR_CHELSIO select CHELSIO_T4 select CHELSIO_LIB
SCSI_CXGB4_ISCSI selects CHELSIO_T4. The latter depends on TLS || TLS=n, so since 'select' does not check dependencies of the selected symbol, SCSI_CXGB4_ISCSI should also depend on TLS || TLS=n. This prevents the following kconfig warning and restricts SCSI_CXGB4_ISCSI to 'm' whenever TLS=m. WARNING: unmet direct dependencies detected for CHELSIO_T4 Depends on [m]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_CHELSIO [=y] && PCI [=y] && (IPV6 [=y] || IPV6 [=y]=n) && (TLS [=m] || TLS [=m]=n) Selected by [y]: - SCSI_CXGB4_ISCSI [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && PCI [=y] && INET [=y] && (IPV6 [=y] || IPV6 [=y]=n) && ETHERNET [=y] Fixes: 7b36b6e03b0d ("[SCSI] cxgb4i v5: iscsi driver") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Karen Xie <kxie@chelsio.com> Cc: linux-scsi@vger.kernel.org Cc: "James E.J. Bottomley" <jejb@linux.ibm.com> Cc: "Martin K. Petersen" <martin.petersen@oracle.com> --- Found in linux-next but applies to mainline as well. I'm not sure about which commit ID to use in Fixes:. drivers/scsi/cxgbi/cxgb4i/Kconfig | 1 + 1 file changed, 1 insertion(+)