| Message ID | 20210303144631.3175331-13-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Rid W=1 warnings in SCSI | expand |
> -----Original Message----- > From: Lee Jones <lee.jones@linaro.org> > Sent: Wednesday, March 3, 2021 8:16 PM > To: lee.jones@linaro.org > Cc: linux-kernel@vger.kernel.org; Nilesh Javali <njavali@marvell.com>; > Manish Rangankar <mrangankar@marvell.com>; GR-QLogic-Storage- > Upstream <GR-QLogic-Storage-Upstream@marvell.com>; James E.J. > Bottomley <jejb@linux.ibm.com>; Martin K. Petersen > <martin.petersen@oracle.com>; linux-scsi@vger.kernel.org > Subject: [EXT] [PATCH 12/30] scsi: qla4xxx: ql4_os: Fix formatting issues - > missing '-' and '_' > > External Email > > ---------------------------------------------------------------------- > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/qla4xxx/ql4_os.c:631: warning: expecting prototype for > qla4xxx_create chap_list(). Prototype was for qla4xxx_create_chap_list() > instead > drivers/scsi/qla4xxx/ql4_os.c:9643: warning: expecting prototype for gets > called if(). Prototype was for qla4xxx_pci_mmio_enabled() instead > > Cc: Nilesh Javali <njavali@marvell.com> > Cc: Manish Rangankar <mrangankar@marvell.com> > Cc: GR-QLogic-Storage-Upstream@marvell.com > Cc: "James E.J. Bottomley" <jejb@linux.ibm.com> > Cc: "Martin K. Petersen" <martin.petersen@oracle.com> > Cc: linux-scsi@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/scsi/qla4xxx/ql4_os.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c > index 7bd9a4a04ad5d..597a64d91fe92 100644 > --- a/drivers/scsi/qla4xxx/ql4_os.c > +++ b/drivers/scsi/qla4xxx/ql4_os.c > @@ -618,7 +618,7 @@ static umode_t qla4_attr_is_visible(int param_type, > int param) > } > > /** > - * qla4xxx_create chap_list - Create CHAP list from FLASH > + * qla4xxx_create_chap_list - Create CHAP list from FLASH > * @ha: pointer to adapter structure > * > * Read flash and make a list of CHAP entries, during login when a CHAP > entry > @@ -9633,7 +9633,7 @@ qla4xxx_pci_error_detected(struct pci_dev *pdev, > pci_channel_state_t state) > } > > /** > - * qla4xxx_pci_mmio_enabled() gets called if > + * qla4xxx_pci_mmio_enabled() - gets called if > * qla4xxx_pci_error_detected() returns PCI_ERS_RESULT_CAN_RECOVER > * and read/write to the device still works. > * @pdev: PCI device pointer > -- > 2.27.0 Lee, Thanks for the patch. Ack-by: Nilesh Javali <njavali@marvell.com>
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 7bd9a4a04ad5d..597a64d91fe92 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -618,7 +618,7 @@ static umode_t qla4_attr_is_visible(int param_type, int param) } /** - * qla4xxx_create chap_list - Create CHAP list from FLASH + * qla4xxx_create_chap_list - Create CHAP list from FLASH * @ha: pointer to adapter structure * * Read flash and make a list of CHAP entries, during login when a CHAP entry @@ -9633,7 +9633,7 @@ qla4xxx_pci_error_detected(struct pci_dev *pdev, pci_channel_state_t state) } /** - * qla4xxx_pci_mmio_enabled() gets called if + * qla4xxx_pci_mmio_enabled() - gets called if * qla4xxx_pci_error_detected() returns PCI_ERS_RESULT_CAN_RECOVER * and read/write to the device still works. * @pdev: PCI device pointer
Fixes the following W=1 kernel build warning(s): drivers/scsi/qla4xxx/ql4_os.c:631: warning: expecting prototype for qla4xxx_create chap_list(). Prototype was for qla4xxx_create_chap_list() instead drivers/scsi/qla4xxx/ql4_os.c:9643: warning: expecting prototype for gets called if(). Prototype was for qla4xxx_pci_mmio_enabled() instead Cc: Nilesh Javali <njavali@marvell.com> Cc: Manish Rangankar <mrangankar@marvell.com> Cc: GR-QLogic-Storage-Upstream@marvell.com Cc: "James E.J. Bottomley" <jejb@linux.ibm.com> Cc: "Martin K. Petersen" <martin.petersen@oracle.com> Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/scsi/qla4xxx/ql4_os.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)