| Message ID | 20210311012212.428068-1-tyreld@linux.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | ibmvfc: free channel_setup_buf during device tear down | expand |
On Wed, 10 Mar 2021 19:22:12 -0600, Tyrel Datwyler wrote: > The buffer for negotiating channel setup is DMA allocated at device > probe time. However, the remove path fails to free this allocation which > will prevent the hypervisor from releasing the virtual device in the > case of a hotplug remove. > > Fix this issue by freeing the buffer allocation in ibmvfc_free_mem(). Applied to 5.12/scsi-fixes, thanks! [1/1] ibmvfc: free channel_setup_buf during device tear down https://git.kernel.org/mkp/scsi/c/febb0cc847e7
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c index e663085a8944..76531eec49de 100644 --- a/drivers/scsi/ibmvscsi/ibmvfc.c +++ b/drivers/scsi/ibmvscsi/ibmvfc.c @@ -5770,6 +5770,8 @@ static void ibmvfc_free_mem(struct ibmvfc_host *vhost) vhost->disc_buf_dma); dma_free_coherent(vhost->dev, sizeof(*vhost->login_buf), vhost->login_buf, vhost->login_buf_dma); + dma_free_coherent(vhost->dev, sizeof(*vhost->channel_setup_buf), + vhost->channel_setup_buf, vhost->channel_setup_dma); dma_pool_destroy(vhost->sg_pool); ibmvfc_free_queue(vhost, async_q); LEAVE;
The buffer for negotiating channel setup is DMA allocated at device probe time. However, the remove path fails to free this allocation which will prevent the hypervisor from releasing the virtual device in the case of a hotplug remove. Fix this issue by freeing the buffer allocation in ibmvfc_free_mem(). Fixes: e95eef3fc0bc ("scsi: ibmvfc: Implement channel enquiry and setup commands") Signed-off-by: Tyrel Datwyler <tyreld@linux.ibm.com> --- drivers/scsi/ibmvscsi/ibmvfc.c | 2 ++ 1 file changed, 2 insertions(+)