From patchwork Fri Mar 12 09:47:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134143 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB8D3C41621 for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCDB864FE0 for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233276AbhCLJsr (ORCPT ); Fri, 12 Mar 2021 04:48:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233116AbhCLJsQ (ORCPT ); Fri, 12 Mar 2021 04:48:16 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDC82C0613D8 for ; Fri, 12 Mar 2021 01:48:15 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id l11so4427965wrp.7 for ; Fri, 12 Mar 2021 01:48:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xPFThlMI/y/qW18pAnI543DROCiFDU71wLqLjBXMJAs=; b=vWEqgTD6oQYZpNz4Hu1OvSSZxt00P0xGD9TIfy49FIbvAkqx8vRrKch/at62za/YT6 4V4KRKTExIvkMZmZYIS3QtI4C4dhGcI1THNQI0SOMB5DowheGfsLWehHmPdmqOOLFjVa 9O07v3hRnNM8HijKAURKU7M52PiNWZgWEOWh3f6HJT2E3ypVayJeGPRqTQm6qgCMtkyq iYni+LSLtMPnTuYa+XE1+PjRfO4DO7MJgFSksEyP6030iVWvsIijj2CW/wzRk/rPluGO zwBxJa+wj8pDmEJsrdHPcP/PU5XtGX22Kbdi8FM5kvEKXIAiS/LncOzyK9cDyYSf/Obg Lw1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xPFThlMI/y/qW18pAnI543DROCiFDU71wLqLjBXMJAs=; b=ACA/T2Wn3qBTt+5IjRiuYTR3PisaTr2M3sZ/LtH50hcFWlpsuq6Bne/7XwPVuQQsh7 7eRorx/TwIXGuM8KKeb+NdnlK5WuaBEyo5jMR7OtSGcWrAf/EcgpIROB2IAOvKqfMJzD lrw1/2zZ5dCxmYg3IQcEV8dvXh8IIXLL+iXA6BsYXg9sJKQZ2pSiDUWumr+qclllB5tl S+Kfst/kMEehU40QZtl6xS+W12yJA0EP3w0GuT9M66VWSAEIhZslz0uVoz5qo+5bDCMN i7hjjITTH7GNX3Z9aFrIDgqQIJ6ChLZk/i58/Lm80ENptRC0YSV8nEfZVTIKBTP8mpFM R1Yw== X-Gm-Message-State: AOAM532Pa2QDyXFC4NHO7DFl30dteS7hkozJerLbIRphH9V+iuWYuulp zyOp2qi5c86QuasoPf1L0HWAkpofDnjq5g== X-Google-Smtp-Source: ABdhPJzshM/m3B1yoxb1O5Wp3hm0MJi/SrIcPq8v19/2Od7pFzDJa/Q/tmVdDZQf9HK6DIIkGVSE2w== X-Received: by 2002:adf:83c2:: with SMTP id 60mr12961301wre.386.1615542494728; Fri, 12 Mar 2021 01:48:14 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , Marcelo Tosatti , linux-scsi@vger.kernel.org Subject: [PATCH 26/30] scsi: atp870u: Fix naming and demote incorrect and non-conformant kernel-doc header Date: Fri, 12 Mar 2021 09:47:34 +0000 Message-Id: <20210312094738.2207817-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/atp870u.c:623: warning: expecting prototype for atp870u_queuecommand(). Prototype was for atp870u_queuecommand_lck() instead drivers/scsi/atp870u.c:724: warning: Function parameter or member 'dev' not described in 'send_s870' drivers/scsi/atp870u.c:724: warning: Function parameter or member 'c' not described in 'send_s870' drivers/scsi/atp870u.c:724: warning: Excess function parameter 'host' description in 'send_s870' Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Marcelo Tosatti Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/atp870u.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/atp870u.c b/drivers/scsi/atp870u.c index da6ca2b153d85..9d179cd15bb84 100644 --- a/drivers/scsi/atp870u.c +++ b/drivers/scsi/atp870u.c @@ -612,7 +612,7 @@ static irqreturn_t atp870u_intr_handle(int irq, void *dev_id) return IRQ_HANDLED; } /** - * atp870u_queuecommand - Queue SCSI command + * atp870u_queuecommand_lck - Queue SCSI command * @req_p: request block * @done: completion function * @@ -711,16 +711,15 @@ static int atp870u_queuecommand_lck(struct scsi_cmnd *req_p, static DEF_SCSI_QCMD(atp870u_queuecommand) -/** +/* * send_s870 - send a command to the controller - * @host: host * * On entry there is work queued to be done. We move some of that work to the * controller itself. * * Caller holds the host lock. */ -static void send_s870(struct atp_unit *dev,unsigned char c) +static void send_s870(struct atp_unit *dev, unsigned char c) { struct scsi_cmnd *workreq = NULL; unsigned int i;//,k;