| Message ID | 20210330125911.1050879-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next] scsi: fnic: remove unnecessary spin_lock_init() and INIT_LIST_HEAD() | expand |
On Tue, 30 Mar 2021 20:59:11 +0800, Yang Yingliang wrote: > The spinlock and list head of fnic_list is initialized statically. > It is unnecessary to initialize by spin_lock_init() and INIT_LIST_HEAD(). Applied to 5.13/scsi-queue, thanks! [1/1] scsi: fnic: remove unnecessary spin_lock_init() and INIT_LIST_HEAD() https://git.kernel.org/mkp/scsi/c/aa6f2fccd711
diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c index 186c3ab4456b..786f9d2704b6 100644 --- a/drivers/scsi/fnic/fnic_main.c +++ b/drivers/scsi/fnic/fnic_main.c @@ -1100,9 +1100,6 @@ static int __init fnic_init_module(void) goto err_create_fnic_workq; } - spin_lock_init(&fnic_list_lock); - INIT_LIST_HEAD(&fnic_list); - fnic_fip_queue = create_singlethread_workqueue("fnic_fip_q"); if (!fnic_fip_queue) { printk(KERN_ERR PFX "fnic FIP work queue create failed\n");
The spinlock and list head of fnic_list is initialized statically. It is unnecessary to initialize by spin_lock_init() and INIT_LIST_HEAD(). Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/scsi/fnic/fnic_main.c | 3 --- 1 file changed, 3 deletions(-)