diff mbox series

[31/40] advansys: do not set message byte in SCSI status

Message ID	20210427083046.31620-32-hare@suse.de (mailing list archive)
State	Changes Requested
Headers	show Return-Path: <linux-scsi-owner@kernel.org> From: Hannes Reinecke <hare@suse.de> To: "Martin K. Petersen" <martin.petersen@oracle.com> Cc: Christoph Hellwig <hch@lst.de>, James Bottomley <james.bottomley@hansenpartnership.com>, Bart van Assche <bvanassche@acm.org>, linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de> Subject: [PATCH 31/40] advansys: do not set message byte in SCSI status Date: Tue, 27 Apr 2021 10:30:37 +0200 Message-Id: <20210427083046.31620-32-hare@suse.de> In-Reply-To: <20210427083046.31620-1-hare@suse.de> References: <20210427083046.31620-1-hare@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	SCSI result cleanup, part 2 \| expand [PATCHv3,00/40] SCSI result cleanup, part 2 [01/40] st: return error code in st_scsi_execute() [02/40] scsi_ioctl: return error code when blk_rq_map_kern() fails [03/40] scsi: Fixup calling convention for scsi_mode_sense() [04/40] scsi: reshuffle response handling in scsi_mode_sense() [05/40] scsi_dh_alua: check for negative result value [06/40] scsi: stop using DRIVER_ERROR [07/40] scsi: introduce scsi_build_sense() [08/40] scsi: introduce scsi_status_is_check_condition() [09/40] scsi: Kill DRIVER_SENSE [10/40] scsi: do not use DRIVER_INVALID [11/40] scsi_error: use DID_TIME_OUT instead of DRIVER_TIMEOUT [12/40] xen-scsiback: use DID_ERROR instead of DRIVER_ERROR [13/40] xen-scsifront: compability status handling [14/40] scsi: Drop the now obsolete driver_byte definitions [15/40] NCR5380: Fold SCSI message ABORT onto DID_ABORT [16/40] scsi: add get_{status,host}_byte() accessor function [17/40] scsi: add scsi_msg_to_host_byte() [18/40] dc395: use standard macros to set SCSI result [19/40] dc395: translate message bytes [20/40] qlogicfas408: make ql_pcmd() a void function [21/40] qlogicfas408: whitespace cleanup [22/40] qlogicfas408: translate message to host byte status [23/40] nsp32: whitespace cleanup [24/40] nsp32: do not set message byte [25/40] wd33c93: translate message byte to host byte [26/40] mesh: translate message to host byte status [27/40] acornscsi: remove acornscsi_reportstatus() [28/40] acornscsi: translate message byte to host byte [29/40] aha152x: modify done() to use separate status bytes [30/40] aha152x: do not set message byte when calling scsi_done() [31/40] advansys: do not set message byte in SCSI status [32/40] fas216: translate message to host byte status [33/40] fas216: Use get_status_byte() to avoid using linux-specific status codes [34/40] FlashPoint: Use standard SCSI definitions [35/40] fdomain: drop last argument to fdomain_finish_cmd() [36/40] fdomain: translate message to host byte status [37/40] scsi: drop message byte helper [38/40] scsi: kill message byte [39/40] target: use standard SAM status types [40/40] scsi: drop obsolete linux-specific SCSI status codes

Commit Message

Hannes Reinecke April 27, 2021, 8:30 a.m. UTC

The host byte in the SCSI status takes precedence during error recovery,
so there is no point in setting the message byte in addition to a host byte
which is not DID_OK.

Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/scsi/advansys.c | 2 --
 1 file changed, 2 deletions(-)

diff mbox series

Patch

diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 77c99fe11c81..28748df36c2f 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -6773,14 +6773,12 @@  static void asc_isr_callback(ASC_DVC_VAR *asc_dvc_varp, ASC_QDONE_INFO *qdonep)
 	case QD_ABORTED_BY_HOST:
 		ASC_DBG(1, "QD_ABORTED_BY_HOST\n");
 		set_status_byte(scp, qdonep->d3.scsi_stat);
-		set_msg_byte(scp, qdonep->d3.scsi_msg);
 		set_host_byte(scp, DID_ABORT);
 		break;
 
 	default:
 		ASC_DBG(1, "done_stat 0x%x\n", qdonep->d3.done_stat);
 		set_status_byte(scp, qdonep->d3.scsi_stat);
-		set_msg_byte(scp, qdonep->d3.scsi_msg);
 		set_host_byte(scp, DID_ERROR);
 		break;
 	}