From patchwork Thu May 20 15:25:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kashyap Desai X-Patchwork-Id: 12270895 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MIME_HEADER_CTYPE_ONLY, SPF_HELO_NONE,SPF_PASS,T_TVD_MIME_NO_HEADERS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B97EC433ED for ; Thu, 20 May 2021 15:22:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDD0561073 for ; Thu, 20 May 2021 15:22:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232245AbhETPYG (ORCPT ); Thu, 20 May 2021 11:24:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237345AbhETPXc (ORCPT ); Thu, 20 May 2021 11:23:32 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30FFBC06138D for ; Thu, 20 May 2021 08:22:07 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id n6-20020a17090ac686b029015d2f7aeea8so5632379pjt.1 for ; Thu, 20 May 2021 08:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UxLeCtlwDsJ5Z6q21Xmrb5rYI3Bs+rzvNkaXA8TdtOQ=; b=bmzlF4/oH1ui6lg5hbd28JZ9oaU8wTTi6la+hvp+rP3pEhFJ/DRDlB71TlFE2aBNWr WuFyli8cMwlpq7cZaDxqlj/XAQbEAcoMqvYn/4eZDIXW/Y+eq2Rpt+Dq15InU7hoX/9N iqou363FfRLKHos1olVMMGX5ajgK7t087ZxNo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=UxLeCtlwDsJ5Z6q21Xmrb5rYI3Bs+rzvNkaXA8TdtOQ=; b=JLdXpmaj6I6CZWPcmahgtDygjvisfFcmx0Pm/Q+z7xptBQz+K7ftJPz1VOKF03wNR4 z/12mrkMCLLxIP4DqlHTH/acFEnrsvmwDdNjQZ9XsVuWaBcM4s+9EFIyfkHQErGi8KjB buFQ3JXbLxWVpw3PA5Y4Y+1tGMAL+KHlcBKaLHpFQJ6+WS6WjjffIgkSgtaIrdbuyMKy ArejrdNS0vNIizJdQjJmHWXmdrXGGJwMtzDCzNOiQzf4BSUg/t15dEjuTibwoS4ziBKh Ecoz7jxZMVaqrH7v0E4CEPeHmXDwGqsJAQ3v80UcJh/rjh8RIgfSrVRMVRKZsRymw3P3 fIxQ== X-Gm-Message-State: AOAM532B4ybsom0X4IudDhMWXRcOZ7QXWqhXO1K8Oisn+Z8eR7J1Wffz kXru8MQL4YCYHXV5vSfvZVxmk6777GB/IotHtpoLHXEmI3B59mMkzOmDL9WaHAwDaPF7OI0jSI7 DcMVRB73uHkdsr4r/h5L7NglxLrR6h/1T/5bQBUbbY20zV7emp/p5oViFvOAr3nPk9n/4IVLQP7 zSIV8B7g== X-Google-Smtp-Source: ABdhPJwXTJ6grQlYbFCsZoo7Mpza2/FSwxgX34+oLTsMWWZ/d7dAZhfuzKTUfHiXG2Nmp4ftK0dJ3g== X-Received: by 2002:a17:90a:f3c8:: with SMTP id ha8mr5478149pjb.185.1621524126310; Thu, 20 May 2021 08:22:06 -0700 (PDT) Received: from drv-bst-rhel8.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id s8sm2250557pfe.112.2021.05.20.08.22.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 May 2021 08:22:05 -0700 (PDT) From: Kashyap Desai To: linux-scsi@vger.kernel.org Cc: jejb@linux.ibm.com, martin.petersen@oracle.com, steve.hagan@broadcom.com, peter.rivera@broadcom.com, mpi3mr-linuxdrv.pdl@broadcom.com, Kashyap Desai , sathya.prakash@broadcom.com Subject: [PATCH v6 15/24] mpi3mr: allow certain commands during pci-remove hook Date: Thu, 20 May 2021 20:55:36 +0530 Message-Id: <20210520152545.2710479-16-kashyap.desai@broadcom.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20210520152545.2710479-1-kashyap.desai@broadcom.com> References: <20210520152545.2710479-1-kashyap.desai@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org This patch allows SSU and Sync Cache commands to be sent to the controller instead of driver returning DID_NO_CONNECT during driver unload to flush any cached data from the drive. Signed-off-by: Kashyap Desai Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl Reviewed-by: Himanshu Madhani Cc: sathya.prakash@broadcom.com --- drivers/scsi/mpi3mr/mpi3mr_os.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c index 0a0e42d..221a850 100644 --- a/drivers/scsi/mpi3mr/mpi3mr_os.c +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c @@ -2767,6 +2767,26 @@ static int mpi3mr_target_alloc(struct scsi_target *starget) return retval; } +/** + * mpi3mr_allow_scmd_to_fw - Command is allowed during shutdown + * @scmd: SCSI Command reference + * + * Checks whether a cdb is allowed during shutdown or not. + * + * Return: TRUE for allowed commands, FALSE otherwise. + */ + +inline bool mpi3mr_allow_scmd_to_fw(struct scsi_cmnd *scmd) +{ + switch (scmd->cmnd[0]) { + case SYNCHRONIZE_CACHE: + case START_STOP: + return true; + default: + return false; + } +} + /** * mpi3mr_qcmd - I/O request despatcher * @shost: SCSI Host reference @@ -2802,7 +2822,8 @@ static int mpi3mr_qcmd(struct Scsi_Host *shost, goto out; } - if (mrioc->stop_drv_processing) { + if (mrioc->stop_drv_processing && + !(mpi3mr_allow_scmd_to_fw(scmd))) { scmd->result = DID_NO_CONNECT << 16; scmd->scsi_done(scmd); goto out;