| Message ID | 20210527155817.15006-2-alice.chao@mediatek.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/1] scsi: ufs-mediatek: Fix HWReset timing | expand |
> -----Original Message----- > From: Alice <alice.chao@mediatek.com> > Sent: 27 May 2021 21:28 > To: stanley.chu@mediatek.com; linux-scsi@vger.kernel.org; > martin.petersen@oracle.com; avri.altman@wdc.com; > alim.akhtar@samsung.com; jejb@linux.ibm.com > Cc: wsd_upstream@mediatek.com; peter.wang@mediatek.com; chun- > hung.wu@mediatek.com; alice.chao@mediatek.com; > jonathan.hsu@mediatek.com; powen.kao@mediatek.com; > cc.chou@mediatek.com; chaotian.jing@mediatek.com; > jiajie.hao@mediatek.com > Subject: [PATCH 1/1] scsi: ufs-mediatek: Fix HWReset timing > > From: "Alice.Chao" <alice.chao@mediatek.com> > > HCI disable before HW Reset. > Because of the property of mtk ufshci, > we need to change reset flow to avoid potential issues. > Please re-format the commit message and mention few wards about potential issues. > Change-Id: I3eb917fd2953b58dcf7e021286d1de71c9232cfb Hmm, run a checkpatch before submitting any patch. > Signed-off-by: Alice.Chao <alice.chao@mediatek.com> > CR-Id: ALPS05728133 What are these ID? Please remove. > Feature: UFS(Universal Flash Storage) Please check Documentation/process/submitting-patches.rst, before submitting patches. > --- > drivers/scsi/ufs/ufs-mediatek.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c > index a981f261b304..c62603ed3d33 100644 > --- a/drivers/scsi/ufs/ufs-mediatek.c > +++ b/drivers/scsi/ufs/ufs-mediatek.c > @@ -846,6 +846,9 @@ static int ufs_mtk_device_reset(struct ufs_hba *hba) > { > struct arm_smccc_res res; > > + /* disable hba before device reset */ > + ufshcd_hba_stop(hba); > + > ufs_mtk_device_reset_ctrl(0, res); > > /* > -- > 2.18.0
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c index a981f261b304..c62603ed3d33 100644 --- a/drivers/scsi/ufs/ufs-mediatek.c +++ b/drivers/scsi/ufs/ufs-mediatek.c @@ -846,6 +846,9 @@ static int ufs_mtk_device_reset(struct ufs_hba *hba) { struct arm_smccc_res res; + /* disable hba before device reset */ + ufshcd_hba_stop(hba); + ufs_mtk_device_reset_ctrl(0, res); /*