| Message ID | 20210604051105.1122667-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [-next] scsi: mpi3mr: Make some symbols static | expand |
On Fri, 2021-06-04 at 13:11 +0800, Yang Yingliang wrote: > Fix the following warnings: > > drivers/scsi/mpi3mr/mpi3mr_os.c:24:5: warning: symbol 'prot_mask' was not declared. Should it be static? > drivers/scsi/mpi3mr/mpi3mr_os.c:28:5: warning: symbol 'prot_guard_mask' was not declared. Should it be static? > drivers/scsi/mpi3mr/mpi3mr_os.c:31:5: warning: symbol 'logging_level' was not declared. Should it be static? [] > diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c [] > @@ -21,14 +21,14 @@ MODULE_LICENSE(MPI3MR_DRIVER_LICENSE); > MODULE_VERSION(MPI3MR_DRIVER_VERSION); > > > /* Module parameters*/ > -int prot_mask = -1; > +static int prot_mask = -1; > module_param(prot_mask, int, 0); > MODULE_PARM_DESC(prot_mask, "Host protection capabilities mask, def=0x07"); drivers/scsi/mpi3mr/mpi3mr_fw.c:extern int prot_mask; drivers/scsi/mpi3mr/mpi3mr_fw.c: if (prot_mask & (SHOST_DIX_TYPE0_PROTEC> This should probably be put in a .h file instead.
diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c index a54aa009ec5a..52f844fb8175 100644 --- a/drivers/scsi/mpi3mr/mpi3mr_os.c +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c @@ -21,14 +21,14 @@ MODULE_LICENSE(MPI3MR_DRIVER_LICENSE); MODULE_VERSION(MPI3MR_DRIVER_VERSION); /* Module parameters*/ -int prot_mask = -1; +static int prot_mask = -1; module_param(prot_mask, int, 0); MODULE_PARM_DESC(prot_mask, "Host protection capabilities mask, def=0x07"); -int prot_guard_mask = 3; +static int prot_guard_mask = 3; module_param(prot_guard_mask, int, 0); MODULE_PARM_DESC(prot_guard_mask, " Host protection guard mask, def=3"); -int logging_level; +static int logging_level; module_param(logging_level, int, 0); MODULE_PARM_DESC(logging_level, " bits for enabling additional logging info (default=0)");
Fix the following warnings: drivers/scsi/mpi3mr/mpi3mr_os.c:24:5: warning: symbol 'prot_mask' was not declared. Should it be static? drivers/scsi/mpi3mr/mpi3mr_os.c:28:5: warning: symbol 'prot_guard_mask' was not declared. Should it be static? drivers/scsi/mpi3mr/mpi3mr_os.c:31:5: warning: symbol 'logging_level' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/scsi/mpi3mr/mpi3mr_os.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)