| Message ID | 20210619155641.19942-1-jsmart2021@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | elx: libefc_sli: fix anding with zero bit value | expand |
James,
> flags value is being set to constant and'd 0 which always results in 0
Applied to 5.14/scsi-staging, thanks!
On Sat, 19 Jun 2021 08:56:41 -0700, James Smart wrote: > flags value is being set to constant and'd 0 which always results in 0 > > Remove the assignment line. Applied to 5.14/scsi-queue, thanks! [1/1] elx: libefc_sli: fix anding with zero bit value https://git.kernel.org/mkp/scsi/c/f6060eb13447
diff --git a/drivers/scsi/elx/libefc_sli/sli4.c b/drivers/scsi/elx/libefc_sli/sli4.c index fc24a50c5d6b..6c6c04e1b74d 100644 --- a/drivers/scsi/elx/libefc_sli/sli4.c +++ b/drivers/scsi/elx/libefc_sli/sli4.c @@ -2381,8 +2381,6 @@ sli_xmit_els_rsp64_wqe(struct sli4 *sli, void *buf, struct efc_dma *rsp, els->ox_id = cpu_to_le16(params->ox_id); - els->flags2 |= SLI4_ELS_IOD & SLI4_ELS_REQUEST64_DIR_WRITE; - els->flags2 |= SLI4_ELS_QOSD; els->cmd_type_wqec = SLI4_ELS_REQUEST64_CMD_GEN;
flags value is being set to constant and'd 0 which always results in 0 Remove the assignment line. Fixes: 1628f5b4976f ("scsi: elx: libefc_sli: Populate and post different WQEs") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Co-developed-by: Ram Vegesna <ram.vegesna@broadcom.com> Signed-off-by: Ram Vegesna <ram.vegesna@broadcom.com> Signed-off-by: James Smart <james.smart@broadcom.com> --- drivers/scsi/elx/libefc_sli/sli4.c | 2 -- 1 file changed, 2 deletions(-)