| Message ID | 20210706181618.27960-4-don.brace@microchip.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | smartpqi updates | expand |
Dear Kevin, dear Don, Am 06.07.21 um 20:16 schrieb Don Brace: > From: Kevin Barnett <kevin.barnett@microchip.com> > > Updated copyright notices and company name strings to reflect … from Microsemi to Microchip … > Microchip ownership. You also change the driver name. Maybe do that in a separate commit with a dedicated commit messages summary. Name changes affecting strings showing up in log messages are always confusing for people’s muscle memory. No idea, if it’d be better to include both names in the driver name until the next Linux LTS series is released. Kind regards, Paul > Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com> > Reviewed-by: Scott Benesh <scott.benesh@microchip.com> > Reviewed-by: Scott Teel <scott.teel@microchip.com> > Signed-off-by: Kevin Barnett <kevin.barnett@microchip.com> > Signed-off-by: Don Brace <don.brace@microchip.com> > --- > drivers/scsi/smartpqi/smartpqi.h | 6 +++--- > drivers/scsi/smartpqi/smartpqi_init.c | 12 ++++++------ > drivers/scsi/smartpqi/smartpqi_sas_transport.c | 4 ++-- > drivers/scsi/smartpqi/smartpqi_sis.c | 4 ++-- > drivers/scsi/smartpqi/smartpqi_sis.h | 4 ++-- > 5 files changed, 15 insertions(+), 15 deletions(-) > > diff --git a/drivers/scsi/smartpqi/smartpqi.h b/drivers/scsi/smartpqi/smartpqi.h > index d7dac5572274..f340afc011b5 100644 > --- a/drivers/scsi/smartpqi/smartpqi.h > +++ b/drivers/scsi/smartpqi/smartpqi.h > @@ -1,7 +1,7 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > /* > - * driver for Microsemi PQI-based storage controllers > - * Copyright (c) 2019-2020 Microchip Technology Inc. and its subsidiaries > + * driver for Microchip PQI-based storage controllers > + * Copyright (c) 2019-2021 Microchip Technology Inc. and its subsidiaries > * Copyright (c) 2016-2018 Microsemi Corporation > * Copyright (c) 2016 PMC-Sierra, Inc. > * > @@ -59,7 +59,7 @@ struct pqi_device_registers { > /* > * controller registers > * > - * These are defined by the Microsemi implementation. > + * These are defined by the Microchip implementation. > * > * Some registers (those named sis_*) are only used when in > * legacy SIS mode before we transition the controller into > diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c > index 7958316841a4..5ce1c41a758d 100644 > --- a/drivers/scsi/smartpqi/smartpqi_init.c > +++ b/drivers/scsi/smartpqi/smartpqi_init.c > @@ -1,7 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * driver for Microsemi PQI-based storage controllers > - * Copyright (c) 2019-2020 Microchip Technology Inc. and its subsidiaries > + * driver for Microchip PQI-based storage controllers > + * Copyright (c) 2019-2021 Microchip Technology Inc. and its subsidiaries > * Copyright (c) 2016-2018 Microsemi Corporation > * Copyright (c) 2016 PMC-Sierra, Inc. > * > @@ -39,7 +39,7 @@ > #define DRIVER_RELEASE 8 > #define DRIVER_REVISION 45 > > -#define DRIVER_NAME "Microsemi PQI Driver (v" \ > +#define DRIVER_NAME "Microchip SmartPQI Driver (v" \ > DRIVER_VERSION BUILD_TIMESTAMP ")" > #define DRIVER_NAME_SHORT "smartpqi" > > @@ -48,8 +48,8 @@ > #define PQI_POST_RESET_DELAY_SECS 5 > #define PQI_POST_OFA_RESET_DELAY_UPON_TIMEOUT_SECS 10 > > -MODULE_AUTHOR("Microsemi"); > -MODULE_DESCRIPTION("Driver for Microsemi Smart Family Controller version " > +MODULE_AUTHOR("Microchip"); > +MODULE_DESCRIPTION("Driver for Microchip Smart Family Controller version " > DRIVER_VERSION); > MODULE_VERSION(DRIVER_VERSION); > MODULE_LICENSE("GPL"); > @@ -8448,7 +8448,7 @@ static void pqi_print_ctrl_info(struct pci_dev *pci_dev, > if (id->driver_data) > ctrl_description = (char *)id->driver_data; > else > - ctrl_description = "Microsemi Smart Family Controller"; > + ctrl_description = "Microchip Smart Family Controller"; > > dev_info(&pci_dev->dev, "%s found\n", ctrl_description); > } > diff --git a/drivers/scsi/smartpqi/smartpqi_sas_transport.c b/drivers/scsi/smartpqi/smartpqi_sas_transport.c > index dd628cc87f78..afd9bafebd1d 100644 > --- a/drivers/scsi/smartpqi/smartpqi_sas_transport.c > +++ b/drivers/scsi/smartpqi/smartpqi_sas_transport.c > @@ -1,7 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * driver for Microsemi PQI-based storage controllers > - * Copyright (c) 2019-2020 Microchip Technology Inc. and its subsidiaries > + * driver for Microchip PQI-based storage controllers > + * Copyright (c) 2019-2021 Microchip Technology Inc. and its subsidiaries > * Copyright (c) 2016-2018 Microsemi Corporation > * Copyright (c) 2016 PMC-Sierra, Inc. > * > diff --git a/drivers/scsi/smartpqi/smartpqi_sis.c b/drivers/scsi/smartpqi/smartpqi_sis.c > index c954620628e0..d63c46a8e38b 100644 > --- a/drivers/scsi/smartpqi/smartpqi_sis.c > +++ b/drivers/scsi/smartpqi/smartpqi_sis.c > @@ -1,7 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * driver for Microsemi PQI-based storage controllers > - * Copyright (c) 2019-2020 Microchip Technology Inc. and its subsidiaries > + * driver for Microchip PQI-based storage controllers > + * Copyright (c) 2019-2021 Microchip Technology Inc. and its subsidiaries > * Copyright (c) 2016-2018 Microsemi Corporation > * Copyright (c) 2016 PMC-Sierra, Inc. > * > diff --git a/drivers/scsi/smartpqi/smartpqi_sis.h b/drivers/scsi/smartpqi/smartpqi_sis.h > index 12cd2ab1aead..d29c1352a826 100644 > --- a/drivers/scsi/smartpqi/smartpqi_sis.h > +++ b/drivers/scsi/smartpqi/smartpqi_sis.h > @@ -1,7 +1,7 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > /* > - * driver for Microsemi PQI-based storage controllers > - * Copyright (c) 2019-2020 Microchip Technology Inc. and its subsidiaries > + * driver for Microchip PQI-based storage controllers > + * Copyright (c) 2019-2021 Microchip Technology Inc. and its subsidiaries > * Copyright (c) 2016-2018 Microsemi Corporation > * Copyright (c) 2016 PMC-Sierra, Inc. > * >
-----Original Message----- From: Paul Menzel [mailto:pmenzel@molgen.mpg.de] Subject: Re: [smartpqi updates PATCH 3/9] smartpqi: update copyright notices Dear Kevin, dear Don, Am 06.07.21 um 20:16 schrieb Don Brace: > From: Kevin Barnett <kevin.barnett@microchip.com> > > Updated copyright notices and company name strings to reflect … from Microsemi to Microchip … > Microchip ownership. You also change the driver name. Maybe do that in a separate commit with a dedicated commit messages summary. Don: I'll separate the driver name from the copyright patches and send up a new patch in V2. Thanks for your review. Name changes affecting strings showing up in log messages are always confusing for people’s muscle memory. No idea, if it’d be better to include both names in the driver name until the next Linux LTS series is released. Don: We would rather just have one name. Kind regards, Paul > Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com> > Reviewed-by: Scott Benesh <scott.benesh@microchip.com> > Reviewed-by: Scott Teel <scott.teel@microchip.com> > Signed-off-by: Kevin Barnett <kevin.barnett@microchip.com> > Signed-off-by: Don Brace <don.brace@microchip.com> > --- > drivers/scsi/smartpqi/smartpqi.h | 6 +++--- > drivers/scsi/smartpqi/smartpqi_init.c | 12 ++++++------ > drivers/scsi/smartpqi/smartpqi_sas_transport.c | 4 ++-- > drivers/scsi/smartpqi/smartpqi_sis.c | 4 ++-- > drivers/scsi/smartpqi/smartpqi_sis.h | 4 ++-- > 5 files changed, 15 insertions(+), 15 deletions(-) > > diff --git a/drivers/scsi/smartpqi/smartpqi.h > b/drivers/scsi/smartpqi/smartpqi.h > index d7dac5572274..f340afc011b5 100644 > --- a/drivers/scsi/smartpqi/smartpqi.h > +++ b/drivers/scsi/smartpqi/smartpqi.h > @@ -1,7 +1,7 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > /* > - * driver for Microsemi PQI-based storage controllers > - * Copyright (c) 2019-2020 Microchip Technology Inc. and its subsidiaries > + * driver for Microchip PQI-based storage controllers > + * Copyright (c) 2019-2021 Microchip Technology Inc. and its subsidiaries > * Copyright (c) 2016-2018 Microsemi Corporation > * Copyright (c) 2016 PMC-Sierra, Inc. > * > @@ -59,7 +59,7 @@ struct pqi_device_registers { > /* > * controller registers > * > - * These are defined by the Microsemi implementation. > + * These are defined by the Microchip implementation. > * > * Some registers (those named sis_*) are only used when in > * legacy SIS mode before we transition the controller into diff > --git a/drivers/scsi/smartpqi/smartpqi_init.c > b/drivers/scsi/smartpqi/smartpqi_init.c > index 7958316841a4..5ce1c41a758d 100644 > --- a/drivers/scsi/smartpqi/smartpqi_init.c > +++ b/drivers/scsi/smartpqi/smartpqi_init.c > @@ -1,7 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * driver for Microsemi PQI-based storage controllers > - * Copyright (c) 2019-2020 Microchip Technology Inc. and its subsidiaries > + * driver for Microchip PQI-based storage controllers > + * Copyright (c) 2019-2021 Microchip Technology Inc. and its subsidiaries > * Copyright (c) 2016-2018 Microsemi Corporation > * Copyright (c) 2016 PMC-Sierra, Inc. > * > @@ -39,7 +39,7 @@ > #define DRIVER_RELEASE 8 > #define DRIVER_REVISION 45 > > -#define DRIVER_NAME "Microsemi PQI Driver (v" \ > +#define DRIVER_NAME "Microchip SmartPQI Driver (v" \ > DRIVER_VERSION BUILD_TIMESTAMP ")" > #define DRIVER_NAME_SHORT "smartpqi" > > @@ -48,8 +48,8 @@ > #define PQI_POST_RESET_DELAY_SECS 5 > #define PQI_POST_OFA_RESET_DELAY_UPON_TIMEOUT_SECS 10 > > -MODULE_AUTHOR("Microsemi"); > -MODULE_DESCRIPTION("Driver for Microsemi Smart Family Controller version " > +MODULE_AUTHOR("Microchip"); > +MODULE_DESCRIPTION("Driver for Microchip Smart Family Controller version " > DRIVER_VERSION); > MODULE_VERSION(DRIVER_VERSION); > MODULE_LICENSE("GPL"); > @@ -8448,7 +8448,7 @@ static void pqi_print_ctrl_info(struct pci_dev *pci_dev, > if (id->driver_data) > ctrl_description = (char *)id->driver_data; > else > - ctrl_description = "Microsemi Smart Family Controller"; > + ctrl_description = "Microchip Smart Family Controller"; > > dev_info(&pci_dev->dev, "%s found\n", ctrl_description); > } > diff --git a/drivers/scsi/smartpqi/smartpqi_sas_transport.c > b/drivers/scsi/smartpqi/smartpqi_sas_transport.c > index dd628cc87f78..afd9bafebd1d 100644 > --- a/drivers/scsi/smartpqi/smartpqi_sas_transport.c > +++ b/drivers/scsi/smartpqi/smartpqi_sas_transport.c > @@ -1,7 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * driver for Microsemi PQI-based storage controllers > - * Copyright (c) 2019-2020 Microchip Technology Inc. and its subsidiaries > + * driver for Microchip PQI-based storage controllers > + * Copyright (c) 2019-2021 Microchip Technology Inc. and its subsidiaries > * Copyright (c) 2016-2018 Microsemi Corporation > * Copyright (c) 2016 PMC-Sierra, Inc. > * > diff --git a/drivers/scsi/smartpqi/smartpqi_sis.c > b/drivers/scsi/smartpqi/smartpqi_sis.c > index c954620628e0..d63c46a8e38b 100644 > --- a/drivers/scsi/smartpqi/smartpqi_sis.c > +++ b/drivers/scsi/smartpqi/smartpqi_sis.c > @@ -1,7 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * driver for Microsemi PQI-based storage controllers > - * Copyright (c) 2019-2020 Microchip Technology Inc. and its subsidiaries > + * driver for Microchip PQI-based storage controllers > + * Copyright (c) 2019-2021 Microchip Technology Inc. and its subsidiaries > * Copyright (c) 2016-2018 Microsemi Corporation > * Copyright (c) 2016 PMC-Sierra, Inc. > * > diff --git a/drivers/scsi/smartpqi/smartpqi_sis.h > b/drivers/scsi/smartpqi/smartpqi_sis.h > index 12cd2ab1aead..d29c1352a826 100644 > --- a/drivers/scsi/smartpqi/smartpqi_sis.h > +++ b/drivers/scsi/smartpqi/smartpqi_sis.h > @@ -1,7 +1,7 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > /* > - * driver for Microsemi PQI-based storage controllers > - * Copyright (c) 2019-2020 Microchip Technology Inc. and its subsidiaries > + * driver for Microchip PQI-based storage controllers > + * Copyright (c) 2019-2021 Microchip Technology Inc. and its subsidiaries > * Copyright (c) 2016-2018 Microsemi Corporation > * Copyright (c) 2016 PMC-Sierra, Inc. > * >
diff --git a/drivers/scsi/smartpqi/smartpqi.h b/drivers/scsi/smartpqi/smartpqi.h index d7dac5572274..f340afc011b5 100644 --- a/drivers/scsi/smartpqi/smartpqi.h +++ b/drivers/scsi/smartpqi/smartpqi.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * driver for Microsemi PQI-based storage controllers - * Copyright (c) 2019-2020 Microchip Technology Inc. and its subsidiaries + * driver for Microchip PQI-based storage controllers + * Copyright (c) 2019-2021 Microchip Technology Inc. and its subsidiaries * Copyright (c) 2016-2018 Microsemi Corporation * Copyright (c) 2016 PMC-Sierra, Inc. * @@ -59,7 +59,7 @@ struct pqi_device_registers { /* * controller registers * - * These are defined by the Microsemi implementation. + * These are defined by the Microchip implementation. * * Some registers (those named sis_*) are only used when in * legacy SIS mode before we transition the controller into diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index 7958316841a4..5ce1c41a758d 100644 --- a/drivers/scsi/smartpqi/smartpqi_init.c +++ b/drivers/scsi/smartpqi/smartpqi_init.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* - * driver for Microsemi PQI-based storage controllers - * Copyright (c) 2019-2020 Microchip Technology Inc. and its subsidiaries + * driver for Microchip PQI-based storage controllers + * Copyright (c) 2019-2021 Microchip Technology Inc. and its subsidiaries * Copyright (c) 2016-2018 Microsemi Corporation * Copyright (c) 2016 PMC-Sierra, Inc. * @@ -39,7 +39,7 @@ #define DRIVER_RELEASE 8 #define DRIVER_REVISION 45 -#define DRIVER_NAME "Microsemi PQI Driver (v" \ +#define DRIVER_NAME "Microchip SmartPQI Driver (v" \ DRIVER_VERSION BUILD_TIMESTAMP ")" #define DRIVER_NAME_SHORT "smartpqi" @@ -48,8 +48,8 @@ #define PQI_POST_RESET_DELAY_SECS 5 #define PQI_POST_OFA_RESET_DELAY_UPON_TIMEOUT_SECS 10 -MODULE_AUTHOR("Microsemi"); -MODULE_DESCRIPTION("Driver for Microsemi Smart Family Controller version " +MODULE_AUTHOR("Microchip"); +MODULE_DESCRIPTION("Driver for Microchip Smart Family Controller version " DRIVER_VERSION); MODULE_VERSION(DRIVER_VERSION); MODULE_LICENSE("GPL"); @@ -8448,7 +8448,7 @@ static void pqi_print_ctrl_info(struct pci_dev *pci_dev, if (id->driver_data) ctrl_description = (char *)id->driver_data; else - ctrl_description = "Microsemi Smart Family Controller"; + ctrl_description = "Microchip Smart Family Controller"; dev_info(&pci_dev->dev, "%s found\n", ctrl_description); } diff --git a/drivers/scsi/smartpqi/smartpqi_sas_transport.c b/drivers/scsi/smartpqi/smartpqi_sas_transport.c index dd628cc87f78..afd9bafebd1d 100644 --- a/drivers/scsi/smartpqi/smartpqi_sas_transport.c +++ b/drivers/scsi/smartpqi/smartpqi_sas_transport.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* - * driver for Microsemi PQI-based storage controllers - * Copyright (c) 2019-2020 Microchip Technology Inc. and its subsidiaries + * driver for Microchip PQI-based storage controllers + * Copyright (c) 2019-2021 Microchip Technology Inc. and its subsidiaries * Copyright (c) 2016-2018 Microsemi Corporation * Copyright (c) 2016 PMC-Sierra, Inc. * diff --git a/drivers/scsi/smartpqi/smartpqi_sis.c b/drivers/scsi/smartpqi/smartpqi_sis.c index c954620628e0..d63c46a8e38b 100644 --- a/drivers/scsi/smartpqi/smartpqi_sis.c +++ b/drivers/scsi/smartpqi/smartpqi_sis.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* - * driver for Microsemi PQI-based storage controllers - * Copyright (c) 2019-2020 Microchip Technology Inc. and its subsidiaries + * driver for Microchip PQI-based storage controllers + * Copyright (c) 2019-2021 Microchip Technology Inc. and its subsidiaries * Copyright (c) 2016-2018 Microsemi Corporation * Copyright (c) 2016 PMC-Sierra, Inc. * diff --git a/drivers/scsi/smartpqi/smartpqi_sis.h b/drivers/scsi/smartpqi/smartpqi_sis.h index 12cd2ab1aead..d29c1352a826 100644 --- a/drivers/scsi/smartpqi/smartpqi_sis.h +++ b/drivers/scsi/smartpqi/smartpqi_sis.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * driver for Microsemi PQI-based storage controllers - * Copyright (c) 2019-2020 Microchip Technology Inc. and its subsidiaries + * driver for Microchip PQI-based storage controllers + * Copyright (c) 2019-2021 Microchip Technology Inc. and its subsidiaries * Copyright (c) 2016-2018 Microsemi Corporation * Copyright (c) 2016 PMC-Sierra, Inc. *