diff mbox series

scsi: BusLogic: use %X for u32 sized integer rather than %lX

Message ID 20210730095031.26981-1-colin.king@canonical.com (mailing list archive)
State Accepted
Headers show
Series scsi: BusLogic: use %X for u32 sized integer rather than %lX | expand

Commit Message

Colin King July 30, 2021, 9:50 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

An earlier fix changed the print format specifier for adapter->bios_addr
to use %lX however the integer is a u32 so the fix was wrong. Fix this
by using the correct %X format specifier.

Addresses-Coverity: ("Invalid type in argument")
Fixes: 43622697117c ("scsi: BusLogic: use %lX for unsigned long rather than %X")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/scsi/BusLogic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Khalid Aziz July 30, 2021, 9:57 p.m. UTC | #1 
On 7/30/21 3:50 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> An earlier fix changed the print format specifier for adapter->bios_addr
> to use %lX however the integer is a u32 so the fix was wrong. Fix this
> by using the correct %X format specifier.
> 
> Addresses-Coverity: ("Invalid type in argument")
> Fixes: 43622697117c ("scsi: BusLogic: use %lX for unsigned long rather than %X")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/scsi/BusLogic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
> index adddcd589941..bd615db5c58c 100644
> --- a/drivers/scsi/BusLogic.c
> +++ b/drivers/scsi/BusLogic.c
> @@ -1711,7 +1711,7 @@ static bool __init blogic_reportconfig(struct blogic_adapter *adapter)
>  	if (adapter->adapter_bus_type != BLOGIC_PCI_BUS) {
>  		blogic_info("  DMA Channel: None, ", adapter);
>  		if (adapter->bios_addr > 0)
> -			blogic_info("BIOS Address: 0x%lX, ", adapter,
> +			blogic_info("BIOS Address: 0x%X, ", adapter,
>  					adapter->bios_addr);
>  		else
>  			blogic_info("BIOS Address: None, ", adapter);
> 

Acked-by: Khalid Aziz <khalid@gonehiking.org>
Martin K. Petersen Aug. 1, 2021, 5:28 p.m. UTC | #2 
Colin,

> An earlier fix changed the print format specifier for
> adapter->bios_addr to use %lX however the integer is a u32 so the fix
> was wrong. Fix this by using the correct %X format specifier.

Applied to 5.15/scsi-staging, thanks!
David Laight Aug. 2, 2021, 8:11 a.m. UTC | #3 
From: Colin King
> Sent: 30 July 2021 10:51
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> An earlier fix changed the print format specifier for adapter->bios_addr
> to use %lX however the integer is a u32 so the fix was wrong. Fix this
> by using the correct %X format specifier.

Is that right?
I bet one 32bit arch defines u32 as long.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
diff mbox series

Patch

diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
index adddcd589941..bd615db5c58c 100644
--- a/drivers/scsi/BusLogic.c
+++ b/drivers/scsi/BusLogic.c
@@ -1711,7 +1711,7 @@  static bool __init blogic_reportconfig(struct blogic_adapter *adapter)
 	if (adapter->adapter_bus_type != BLOGIC_PCI_BUS) {
 		blogic_info("  DMA Channel: None, ", adapter);
 		if (adapter->bios_addr > 0)
-			blogic_info("BIOS Address: 0x%lX, ", adapter,
+			blogic_info("BIOS Address: 0x%X, ", adapter,
 					adapter->bios_addr);
 		else
 			blogic_info("BIOS Address: None, ", adapter);