diff mbox series

[linux-next] scsi: megaraid: fix Coccinelle warnings

Message ID 20210820030805.12383-1-jing.yangyang@zte.com.cn (mailing list archive)
State Accepted
Headers show
Series [linux-next] scsi: megaraid: fix Coccinelle warnings | expand

Commit Message

CGEL Aug. 20, 2021, 3:08 a.m. UTC 
From: jing yangyang <jing.yangyang@zte.com.cn>

WARNING !A || A && B is equivalent to !A || B

This issue was detected with the help of Coccinelle.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
---
 drivers/scsi/megaraid/megaraid_sas_base.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Sumit Saxena Aug. 20, 2021, 8:16 a.m. UTC | #1 
On Fri, Aug 20, 2021 at 8:38 AM CGEL <cgel.zte@gmail.com> wrote:
>
> From: jing yangyang <jing.yangyang@zte.com.cn>
>
> WARNING !A || A && B is equivalent to !A || B
>
> This issue was detected with the help of Coccinelle.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
Martin K. Petersen Sept. 14, 2021, 3:43 a.m. UTC | #2 
On Thu, 19 Aug 2021 20:08:05 -0700, CGEL wrote:

> From: jing yangyang <jing.yangyang@zte.com.cn>
> 
> WARNING !A || A && B is equivalent to !A || B
> 
> This issue was detected with the help of Coccinelle.
> 
> 
> [...]

Applied to 5.15/scsi-fixes, thanks!

[1/1] scsi: megaraid: fix Coccinelle warnings
      https://git.kernel.org/mkp/scsi/c/17dfd54d391e
diff mbox series

Patch

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index e4298bf..17c87ac 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -8773,8 +8773,7 @@  int megasas_update_device_list(struct megasas_instance *instance,
 
 		if (event_type & SCAN_VD_CHANNEL) {
 			if (!instance->requestorId ||
-			    (instance->requestorId &&
-			     megasas_get_ld_vf_affiliation(instance, 0))) {
+			megasas_get_ld_vf_affiliation(instance, 0)) {
 				dcmd_ret = megasas_ld_list_query(instance,
 						MR_LD_QUERY_TYPE_EXPOSED_TO_HOST);
 				if (dcmd_ret != DCMD_SUCCESS)