| Message ID | 20210925125324.1760-1-caihuoqing@baidu.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [1/3] scsi: qla1280: Fix a function name in comments | expand |
Cai, > Use dma_map_single() instead of pci_map_single(), > because only dma_map_single() is called here. pci_map_single() was the appropriate interface when the change log entry was written. And the original entry accurately describes the change that was made to the code back then. Whereas your proposed fix does not. There is little benefit to having change logs in drivers in a modern context. However, these entries predate git history and should therefore be preserved.
On Sat, 25 Sep 2021 20:53:21 +0800, Cai Huoqing wrote: > Use dma_map_single() instead of pci_map_single(), > because only dma_map_single() is called here. > > Applied to 5.16/scsi-queue, thanks! [3/3] scsi: lpfc: Fix a function name in comments https://git.kernel.org/mkp/scsi/c/8d807a068090
diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c index d0b4e063bfe1..20b1709e8288 100644 --- a/drivers/scsi/qla1280.c +++ b/drivers/scsi/qla1280.c @@ -19,7 +19,7 @@ Rev 3.26, January 16, 2006 Jes Sorensen - Ditch all < 2.6 support Rev 3.25.1, February 10, 2005 Christoph Hellwig - - use pci_map_single to map non-S/G requests + - use dma_map_single to map non-S/G requests - remove qla1280_proc_info Rev 3.25, September 28, 2004, Christoph Hellwig - add support for ISP1020/1040
Use dma_map_single() instead of pci_map_single(), because only dma_map_single() is called here. Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- drivers/scsi/qla1280.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)