diff mbox series

[v1] scsi: ufs: ufshpb: Fix sparse warning in ufshpb_set_hpb_read_to_upiu()

Message ID 20211111222452.384089-1-huobean@gmail.com (mailing list archive)
State Accepted
Headers show
Series [v1] scsi: ufs: ufshpb: Fix sparse warning in ufshpb_set_hpb_read_to_upiu() | expand

Commit Message

Bean Huo Nov. 11, 2021, 10:24 p.m. UTC 
From: Bean Huo <beanhuo@micron.com>

This patch is to fix the following sparse warnings in ufshpb_set_hpb_read_to_upiu():

sparse warnings: (new ones prefixed by >>)
drivers/scsi/ufs/ufshpb.c:335:27: sparse: sparse: cast from restricted __be64
drivers/scsi/ufs/ufshpb.c:335:25: sparse: expected restricted __be64 [usertype] ppn_tmp
drivers/scsi/ufs/ufshpb.c:335:25: sparse: got unsigned long long [usertype]

Signed-off-by: Bean Huo <beanhuo@micron.com>
Reported-by: kernel test robot <lkp@intel.com>
---
 drivers/scsi/ufs/ufshpb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bart Van Assche Nov. 14, 2021, 12:27 a.m. UTC | #1 
On 11/11/21 14:24, Bean Huo wrote:
> -		ppn_tmp = swab64(ppn);
> +		ppn_tmp = (__force __be64)swab64((__force u64)ppn);

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Martin K. Petersen Nov. 19, 2021, 4:16 a.m. UTC | #2 
On Thu, 11 Nov 2021 23:24:52 +0100, Bean Huo wrote:

> From: Bean Huo <beanhuo@micron.com>
> 
> This patch is to fix the following sparse warnings in ufshpb_set_hpb_read_to_upiu():
> 
> sparse warnings: (new ones prefixed by >>)
> drivers/scsi/ufs/ufshpb.c:335:27: sparse: sparse: cast from restricted __be64
> drivers/scsi/ufs/ufshpb.c:335:25: sparse: expected restricted __be64 [usertype] ppn_tmp
> drivers/scsi/ufs/ufshpb.c:335:25: sparse: got unsigned long long [usertype]
> 
> [...]

Applied to 5.16/scsi-fixes, thanks!

[1/1] scsi: ufs: ufshpb: Fix sparse warning in ufshpb_set_hpb_read_to_upiu()
      https://git.kernel.org/mkp/scsi/c/73185a13773a
diff mbox series

Patch

diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index a86d0cc50de2..5c8bb6dcc559 100644
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -331,7 +331,7 @@  ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp,
 	cdb[0] = UFSHPB_READ;
 
 	if (hba->dev_quirks & UFS_DEVICE_QUIRK_SWAP_L2P_ENTRY_FOR_HPB_READ)
-		ppn_tmp = swab64(ppn);
+		ppn_tmp = (__force __be64)swab64((__force u64)ppn);
 
 	/* ppn value is stored as big-endian in the host memory */
 	memcpy(&cdb[6], &ppn_tmp, sizeof(__be64));