diff mbox series

scsi:elx: fix cond_no_effect.cocci warnings

Message ID 20211115055725.85631-1-chi.minghao@zte.com.cn (mailing list archive)
State Changes Requested
Headers show
Series scsi:elx: fix cond_no_effect.cocci warnings | expand

Commit Message

CGEL Nov. 15, 2021, 5:57 a.m. UTC 
From: chiminghao <chi.minghao@zte.com.cn>

Fix the following coccicheck WARNING:
./drivers/scsi/elx/libefc_sli/sli4.c, 2320, 2-4, WARNING
possible condition with no effect (if == else)

Reported-by: Zeal Robot <zealci@zte.com.cm>
Signed-off-by: chiminghao <chi.minghao@zte.com.cn>
---
 drivers/scsi/elx/libefc_sli/sli4.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comments

Martin K. Petersen Nov. 30, 2021, 4:29 a.m. UTC | #1 
> From: chiminghao <chi.minghao@zte.com.cn>
>
> Fix the following coccicheck WARNING:
> ./drivers/scsi/elx/libefc_sli/sli4.c, 2320, 2-4, WARNING
> possible condition with no effect (if == else)

The patch attribution is confusing.

Patch was submitted by <cgel.zte@gmail.com> but there is no signoff tag
reflecting this.

> Reported-by: Zeal Robot <zealci@zte.com.cm>

.cm?

> Signed-off-by: chiminghao <chi.minghao@zte.com.cn>
diff mbox series

Patch

diff --git a/drivers/scsi/elx/libefc_sli/sli4.c b/drivers/scsi/elx/libefc_sli/sli4.c
index 907d67aeac23..b74065a4e5c1 100644
--- a/drivers/scsi/elx/libefc_sli/sli4.c
+++ b/drivers/scsi/elx/libefc_sli/sli4.c
@@ -2317,12 +2317,8 @@  sli_xmit_bls_rsp64_wqe(struct sli4 *sli, void *buf,
 		SLI4_GENERIC_CONTEXT_VPI << SLI4_BLS_RSP_WQE_CT_SHFT;
 		bls->context_tag = cpu_to_le16(params->vpi);
 
-		if (params->s_id != U32_MAX)
-			bls->local_n_port_id_dword |=
-				cpu_to_le32(params->s_id & 0x00ffffff);
-		else
-			bls->local_n_port_id_dword |=
-				cpu_to_le32(params->s_id & 0x00ffffff);
+		bls->local_n_port_id_dword |=
+			cpu_to_le32(params->s_id & 0x00ffffff);
 
 		dw_ridflags = (dw_ridflags & ~SLI4_BLS_RSP_RID) |
 			       (params->d_id & SLI4_BLS_RSP_RID);