From patchwork Wed Nov 17 12:32:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sreekanth Reddy X-Patchwork-Id: 12624491 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCF53C433FE for ; Wed, 17 Nov 2021 12:24:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CE3F61544 for ; Wed, 17 Nov 2021 12:24:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237262AbhKQM1X (ORCPT ); Wed, 17 Nov 2021 07:27:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233318AbhKQM1W (ORCPT ); Wed, 17 Nov 2021 07:27:22 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D36BC061570 for ; Wed, 17 Nov 2021 04:24:24 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id w33-20020a17090a6ba400b001a722a06212so4333173pjj.0 for ; Wed, 17 Nov 2021 04:24:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:mime-version; bh=FyZnQATfmBEocUPJamwyU6YqoVMNOgdnEJtyZC2ZT1A=; b=YF62MwTbWkioswLrjaM3lJlEBwgauvEWdwZfPV+27OPsFqoYacNIn+nKiQMmB+r2A5 UCfTc64jLJzsEw7Rt02DeuAzHY4/OSuNeEFTUNfmiBnXJ36yLAk0huZBz8lqymOrB94o aviykVQtO7iuehgiWscRE64Fhh2XZmMrnJwn0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=FyZnQATfmBEocUPJamwyU6YqoVMNOgdnEJtyZC2ZT1A=; b=ZO2OIGvJOM9d2P+Mf2OBkASaspKsovH+uhAHtHc44rsWlLIi+o12B8eLIemVjBlmoH 1wbTSI9DXQwUpNZb2PtwuTYB+QbTQELcDRH+F5sclJzSXic7PnodFrGX4p2NeITDXoKA dlOrV1u0jhBFHcy1UeISY2vvKOSQPJXiBg8yBvaDDQXYt44jnxUTtxVL7BzR+KJtp5kj oiTa8Gux2Widftrifi+5nFABz/8sQwVJx+/263Lt22NdYVUIA5sE9numbXc0eWQtr5b0 7CuhCSAgWkRL1F0TzBicxruxIO1rcjq7leG6etv19mU6LCoPTnJmVo7iO7lbyxPJYJnL /iWQ== X-Gm-Message-State: AOAM532XyBRqH+x3I7B9rsWQqNCHhINBwCcVi+ERUUyQfTTMaVBL3x80 SOITCQRgQHanVqZ5UMUGTgxMk+I/tB3brppgwrfdSzbxWsviGIEGTqhlHH7jXw7ddkQ38kX8BWW q5sQ9DWELLpaXCnVx4gCsmgvPgu0cO5A7qms5Og8iMhVLMBR/JHWwXcjhWfk6zRHH4rGB/mUBYC 4jklNidS11 X-Google-Smtp-Source: ABdhPJxlap/vq2b/7uDDADtMSc3S5+Lpkxime9dSyAwCdzKfs25Rd948PskrT2psw2qs5L43bLcYwQ== X-Received: by 2002:a17:90b:4f84:: with SMTP id qe4mr9170763pjb.102.1637151863253; Wed, 17 Nov 2021 04:24:23 -0800 (PST) Received: from dhcp-10-123-20-36.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id bf13sm5013257pjb.47.2021.11.17.04.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Nov 2021 04:24:22 -0800 (PST) From: Sreekanth Reddy To: linux-scsi@vger.kernel.org, martin.petersen@oracle.com Cc: suganath-prabu.subramani@broadcom.com, Sreekanth Reddy Subject: [PATCH] mpt3sas: Fix incorrect system timestamp showed in IOC FW Date: Wed, 17 Nov 2021 18:02:15 +0530 Message-Id: <20211117123215.25487-1-sreekanth.reddy@broadcom.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org For updating the IOC Fimrware's timestamp with system timestamp, driver issues the Mpi26IoUnitControlRequest message. While framing the Mpi26IoUnitControlRequest driver should copy the current timestamp value's lower 32 bits in IOCParameterValue field and higher 32 bits in Reserved7 field. Fixes: f98790c00375("mpt3sas: Sync time periodically between driver and firmware") Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 27eb652b564f..81dab9b82f79 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -639,8 +639,8 @@ static void _base_sync_drv_fw_timestamp(struct MPT3SAS_ADAPTER *ioc) mpi_request->IOCParameter = MPI26_SET_IOC_PARAMETER_SYNC_TIMESTAMP; current_time = ktime_get_real(); TimeStamp = ktime_to_ms(current_time); - mpi_request->Reserved7 = cpu_to_le32(TimeStamp & 0xFFFFFFFF); - mpi_request->IOCParameterValue = cpu_to_le32(TimeStamp >> 32); + mpi_request->Reserved7 = cpu_to_le32(TimeStamp >> 32); + mpi_request->IOCParameterValue = cpu_to_le32(TimeStamp & 0xFFFFFFFF); init_completion(&ioc->scsih_cmds.done); ioc->put_smid_default(ioc, smid); dinitprintk(ioc, ioc_info(ioc,