| Message ID | 20220210114218.632725-4-damien.lemoal@opensource.wdc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | libsas and pm8001 fixes | expand |
On 10/02/2022 11:42, Damien Le Moal wrote: > sas_task_alloc() sets the state flag SAS_TASK_STATE_PENDING for any > new task allocated. So there is no need to set this flag again in > sas_ata_qc_issue() after the task allocation. > > Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> I think that my colleague Xiang Chen had the same patch queued locally, but yours got to the list first.. Reviewed-by: John Garry <john.garry@huawei.com> > --- > drivers/scsi/libsas/sas_ata.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c > index 99549862c9c7..a03a841921db 100644 > --- a/drivers/scsi/libsas/sas_ata.c > +++ b/drivers/scsi/libsas/sas_ata.c > @@ -204,7 +204,6 @@ static unsigned int sas_ata_qc_issue(struct ata_queued_cmd *qc) > } > task->scatter = qc->sg; > task->ata_task.retry_count = 1; > - task->task_state_flags = SAS_TASK_STATE_PENDING; > qc->lldd_task = task; > > task->ata_task.use_ncq = ata_is_ncq(qc->tf.protocol);
diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index 99549862c9c7..a03a841921db 100644 --- a/drivers/scsi/libsas/sas_ata.c +++ b/drivers/scsi/libsas/sas_ata.c @@ -204,7 +204,6 @@ static unsigned int sas_ata_qc_issue(struct ata_queued_cmd *qc) } task->scatter = qc->sg; task->ata_task.retry_count = 1; - task->task_state_flags = SAS_TASK_STATE_PENDING; qc->lldd_task = task; task->ata_task.use_ncq = ata_is_ncq(qc->tf.protocol);
sas_task_alloc() sets the state flag SAS_TASK_STATE_PENDING for any new task allocated. So there is no need to set this flag again in sas_ata_qc_issue() after the task allocation. Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> --- drivers/scsi/libsas/sas_ata.c | 1 - 1 file changed, 1 deletion(-)