| Message ID | 20220412073647.3808493-2-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | treewide: scsi: ufs: Add support for Renesas R-Car UFS controller | expand |
On 12/04/2022 09:36, Yoshihiro Shimoda wrote: > Document Renesas R-Car UFS host controller for R-Car S4-8 (r8a779f0). > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > .../devicetree/bindings/ufs/renesas,ufs.yaml | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/ufs/renesas,ufs.yaml > Thank you for your patch. There is something to discuss/improve. > +allOf: > + - $ref: ufs-common.yaml > + > +properties: > + compatible: > + items: No items, so just "const: renesas,...." > + - const: renesas,r8a779f0-ufs > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 2 > + > + clock-names: > + maxItems: 2 No need for maxItems. Please test your bindings with dt_binding_check, because you should see a warning about it, AFAIR. > + items: > + - const: fck > + - const: ref_clk > + > + power-domains: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + No phys. Are you sure you don't need one? > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - power-domains> + - resets > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/r8a779f0-cpg-mssr.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/r8a779f0-sysc.h> > + > + ufs: scsi@e686000 { Node name "ufs". Best regards, Krzysztof
On Tue, 12 Apr 2022 16:36:41 +0900, Yoshihiro Shimoda wrote: > Document Renesas R-Car UFS host controller for R-Car S4-8 (r8a779f0). > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > .../devicetree/bindings/ufs/renesas,ufs.yaml | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/ufs/renesas,ufs.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/ufs/renesas,ufs.yaml: properties:clock-names: {'maxItems': 2, 'items': [{'const': 'fck'}, {'const': 'ref_clk'}]} should not be valid under {'required': ['maxItems']} hint: "maxItems" is not needed with an "items" list from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/ufs/renesas,ufs.yaml: ignoring, error in schema: properties: clock-names Documentation/devicetree/bindings/ufs/renesas,ufs.example.dtb:0:0: /example-0/scsi@e686000: failed to match any schema with compatible: ['renesas,r8a779f0-ufs'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi Krzysztof, Thank you for your review! > From: Krzysztof Kozlowski, Sent: Tuesday, April 12, 2022 9:23 PM > > On 12/04/2022 09:36, Yoshihiro Shimoda wrote: > > Document Renesas R-Car UFS host controller for R-Car S4-8 (r8a779f0). > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > --- > > .../devicetree/bindings/ufs/renesas,ufs.yaml | 63 +++++++++++++++++++ > > 1 file changed, 63 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/ufs/renesas,ufs.yaml > > > > Thank you for your patch. There is something to discuss/improve. > > > +allOf: > > + - $ref: ufs-common.yaml > > + > > +properties: > > + compatible: > > + items: > > No items, so just "const: renesas,...." I got it. I'll fix it. > > + - const: renesas,r8a779f0-ufs > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 2 > > + > > + clock-names: > > + maxItems: 2 > > No need for maxItems. Please test your bindings with dt_binding_check, > because you should see a warning about it, AFAIR. I'll fix it. I should have checked dt_binding_check before submitting a patch... # I thought I had already checked it, but I didn't check it... > > + items: > > + - const: fck > > + - const: ref_clk > > + > > + power-domains: > > + maxItems: 1 > > + > > + resets: > > + maxItems: 1 > > + > > No phys. Are you sure you don't need one? The phy doesn't have any memory map area. The host controller can access it via vender specific registers. But, the vender specific registers are used for initialization of both the controller and phy. So, I don't need phys on the ufs node. > > +required: > > + - compatible > > + - reg > > + - clocks > > + - clock-names > > + - power-domains> + - resets > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/r8a779f0-cpg-mssr.h> > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + #include <dt-bindings/power/r8a779f0-sysc.h> > > + > > + ufs: scsi@e686000 { > > Node name "ufs". I got it. I'll fix it. Best regards, Yoshihiro Shimoda > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/ufs/renesas,ufs.yaml b/Documentation/devicetree/bindings/ufs/renesas,ufs.yaml new file mode 100644 index 000000000000..04ff0ffd6efb --- /dev/null +++ b/Documentation/devicetree/bindings/ufs/renesas,ufs.yaml @@ -0,0 +1,63 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/ufs/renesas,ufs.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Renesas R-Car UFS Host Controller + +maintainers: + - Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> + +allOf: + - $ref: ufs-common.yaml + +properties: + compatible: + items: + - const: renesas,r8a779f0-ufs + + reg: + maxItems: 1 + + clocks: + maxItems: 2 + + clock-names: + maxItems: 2 + items: + - const: fck + - const: ref_clk + + power-domains: + maxItems: 1 + + resets: + maxItems: 1 + +required: + - compatible + - reg + - clocks + - clock-names + - power-domains + - resets + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/r8a779f0-cpg-mssr.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/power/r8a779f0-sysc.h> + + ufs: scsi@e686000 { + compatible = "renesas,r8a779f0-ufs"; + reg = <0xe6860000 0x100>; + interrupts = <GIC_SPI 235 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 1514>, <&ufs30_clk>; + clock-names = "fck", "ref_clk"; + freq-table-hz = <200000000 200000000>, <38400000 38400000>; + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>; + resets = <&cpg 1514>; + };
Document Renesas R-Car UFS host controller for R-Car S4-8 (r8a779f0). Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- .../devicetree/bindings/ufs/renesas,ufs.yaml | 63 +++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/ufs/renesas,ufs.yaml