diff mbox series

scsi: qla2xxx: remove unneeded flush_workqueue

Message ID 20220424062413.3220315-1-ran.jianping@zte.com.cn (mailing list archive)
State Accepted
Headers show
Series scsi: qla2xxx: remove unneeded flush_workqueue | expand

Commit Message

CGEL April 24, 2022, 6:24 a.m. UTC 
From: ran jianping <ran.jianping@zte.com.cn>

All work currently pending will be done first by calling destroy_workqueue,
so there is no need to flush it explicitly.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
---
 drivers/scsi/qla2xxx/qla_os.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Martin K. Petersen May 3, 2022, 12:51 a.m. UTC | #1 
On Sun, 24 Apr 2022 06:24:13 +0000, cgel.zte@gmail.com wrote:

> From: ran jianping <ran.jianping@zte.com.cn>
> 
> All work currently pending will be done first by calling destroy_workqueue,
> so there is no need to flush it explicitly.
> 
> 

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: qla2xxx: remove unneeded flush_workqueue
      https://git.kernel.org/mkp/scsi/c/cf97628fe1a1
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 762229d495a8..73073fb08369 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -3933,7 +3933,6 @@  qla2x00_free_device(scsi_qla_host_t *vha)
 
 	/* Flush the work queue and remove it */
 	if (ha->wq) {
-		flush_workqueue(ha->wq);
 		destroy_workqueue(ha->wq);
 		ha->wq = NULL;
 	}