| Message ID | 20220811161053.54081-1-alim.akhtar@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] scsi: ufs: host: ufs-exynos: staticize fsd_ufs_drvs | expand |
On 8/11/22 09:10, Alim Akhtar wrote: > struct fsd_ufs_drvs is not used outside this file, so made it static. > This fixes sparse warning: > > drivers/ufs/host/ufs-exynos.c:1721:28: sparse: sparse: > symbol 'fsd_ufs_drvs' was not declared. Should it be static? `staticize' is not a verb. Anyway: Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Alim, > struct fsd_ufs_drvs is not used outside this file, so made it static. > This fixes sparse warning: > > drivers/ufs/host/ufs-exynos.c:1721:28: sparse: sparse: > symbol 'fsd_ufs_drvs' was not declared. Should it be static? Applied to 5.20/scsi-staging, thanks!
diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index eced97538082..c3628a8645a5 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -1711,7 +1711,7 @@ static struct exynos_ufs_uic_attr fsd_uic_attr = { .pa_dbg_option_suite = 0x2E820183, }; -struct exynos_ufs_drv_data fsd_ufs_drvs = { +static const struct exynos_ufs_drv_data fsd_ufs_drvs = { .uic_attr = &fsd_uic_attr, .quirks = UFSHCD_QUIRK_PRDT_BYTE_GRAN | UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR |
struct fsd_ufs_drvs is not used outside this file, so made it static. This fixes sparse warning: drivers/ufs/host/ufs-exynos.c:1721:28: sparse: sparse: symbol 'fsd_ufs_drvs' was not declared. Should it be static? Reported-by: kernel test robot <lkp@intel.com> Fixes: 216f74e8059a ("scsi: ufs: host: ufs-exynos: Add support for FSD UFS HCI") Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- * Changes since v1 - Addressed Krzysztof's review comment drivers/ufs/host/ufs-exynos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)