[v3,3/3] scsi: ufs: core: Use is_visible to control UFS unit descriptor sysfs nodes

Commit Message

Bean Huo Oct. 18, 2022, 6:16 p.m. UTC

From: Bean Huo <[e-mail]>

UFS Boot and Device W-LUs do not have unit descriptors, and PRMB does not
support WB, we can use is_visible() to control which nodes are visible
and which are not.

Signed-off-by: Bean Huo <[e-mail]>
---
 drivers/ufs/core/ufs-sysfs.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Bart Van Assche Oct. 18, 2022, 6:23 p.m. UTC | #1

On 10/18/22 11:16, Bean Huo wrote:
> From: Bean Huo <[e-mail]>
> 
> UFS Boot and Device W-LUs do not have unit descriptors, and PRMB does not
                                                               ^^^^
                                                               RPMB?
> support WB, we can use is_visible() to control which nodes are visible
> and which are not.

Otherwise this patch looks good to me. Hence:

Reviewed-by: Bart Van Assche <[e-mail]>

Patch

diff --git a/drivers/ufs/core/ufs-sysfs.c b/drivers/ufs/core/ufs-sysfs.c
index eb6b278c4e79..883f0e44b54e 100644
--- a/drivers/ufs/core/ufs-sysfs.c
+++ b/drivers/ufs/core/ufs-sysfs.c
@@ -1285,9 +1285,27 @@  static struct attribute *ufs_sysfs_unit_descriptor[] = {
 	NULL,
 };
 
+static umode_t ufs_unit_descriptor_is_visible(struct kobject *kobj, struct attribute *attr, int n)
+{
+	struct device *dev = container_of(kobj, struct device, kobj);
+	struct scsi_device *sdev = to_scsi_device(dev);
+	u8 lun = ufshcd_scsi_to_upiu_lun(sdev->lun);
+	umode_t mode = attr->mode;
+
+	if (lun == UFS_UPIU_BOOT_WLUN || lun == UFS_UPIU_UFS_DEVICE_WLUN)
+		/* Boot and device WLUN have no unit descriptors */
+		mode = 0;
+	if (lun == UFS_UPIU_RPMB_WLUN && attr == &dev_attr_wb_buf_alloc_units.attr)
+		mode = 0;
+
+	return mode;
+}
+
+
 const struct attribute_group ufs_sysfs_unit_descriptor_group = {
 	.name = "unit_descriptor",
 	.attrs = ufs_sysfs_unit_descriptor,
+	.is_visible = ufs_unit_descriptor_is_visible,
 };
 
 static ssize_t dyn_cap_needed_attribute_show(struct device *dev,