| Message ID | 20221111014449.1649968-1-shinichiro.kawasaki@wdc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] scsi: mpi3mr: suppress command reply debug prints | expand |
On 11/11/22 10:44, Shin'ichiro Kawasaki wrote: > After it receives command reply, mpi3mr driver checks command result. If > the result is not zero, it prints out command information. This debug > information is confusing since they are printed even when the non-zero > result is expected. "Power-on or device reset occurred" is printed for > Test Unit Ready command at drive detection. Inquiry failure for > unsupported VPD page header is also printed. They are harmless but look > like failures. > > To avoid the confusion, print the command reply debug information only > when the module parameter logging_level has value MPI3_DEBUG_SCSI_ERROR= > 64, in same manner as mpt3sas driver. > > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> > --- > Changes from v1: > * Changed logging_level flag from MPI3_DEBUG_REPLY to MPI3_DEBUG_SCSI_ERROR > > drivers/scsi/mpi3mr/mpi3mr_os.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c > index f77ee4051b00..3306de7170f6 100644 > --- a/drivers/scsi/mpi3mr/mpi3mr_os.c > +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c > @@ -3265,7 +3265,8 @@ void mpi3mr_process_op_reply_desc(struct mpi3mr_ioc *mrioc, > } > > if (scmd->result != (DID_OK << 16) && (scmd->cmnd[0] != ATA_12) && > - (scmd->cmnd[0] != ATA_16)) { > + (scmd->cmnd[0] != ATA_16) && > + mrioc->logging_level & MPI3_DEBUG_SCSI_ERROR) { > ioc_info(mrioc, "%s :scmd->result 0x%x\n", __func__, > scmd->result); > scsi_print_command(scmd); Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
On Fri, 11 Nov 2022 10:44:49 +0900, Shin'ichiro Kawasaki wrote: > After it receives command reply, mpi3mr driver checks command result. If > the result is not zero, it prints out command information. This debug > information is confusing since they are printed even when the non-zero > result is expected. "Power-on or device reset occurred" is printed for > Test Unit Ready command at drive detection. Inquiry failure for > unsupported VPD page header is also printed. They are harmless but look > like failures. > > [...] Applied to 6.1/scsi-fixes, thanks! [1/1] scsi: mpi3mr: suppress command reply debug prints https://git.kernel.org/mkp/scsi/c/7d21fcfb4095
diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c index f77ee4051b00..3306de7170f6 100644 --- a/drivers/scsi/mpi3mr/mpi3mr_os.c +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c @@ -3265,7 +3265,8 @@ void mpi3mr_process_op_reply_desc(struct mpi3mr_ioc *mrioc, } if (scmd->result != (DID_OK << 16) && (scmd->cmnd[0] != ATA_12) && - (scmd->cmnd[0] != ATA_16)) { + (scmd->cmnd[0] != ATA_16) && + mrioc->logging_level & MPI3_DEBUG_SCSI_ERROR) { ioc_info(mrioc, "%s :scmd->result 0x%x\n", __func__, scmd->result); scsi_print_command(scmd);
After it receives command reply, mpi3mr driver checks command result. If the result is not zero, it prints out command information. This debug information is confusing since they are printed even when the non-zero result is expected. "Power-on or device reset occurred" is printed for Test Unit Ready command at drive detection. Inquiry failure for unsupported VPD page header is also printed. They are harmless but look like failures. To avoid the confusion, print the command reply debug information only when the module parameter logging_level has value MPI3_DEBUG_SCSI_ERROR= 64, in same manner as mpt3sas driver. Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> --- Changes from v1: * Changed logging_level flag from MPI3_DEBUG_REPLY to MPI3_DEBUG_SCSI_ERROR drivers/scsi/mpi3mr/mpi3mr_os.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)